public inbox for [email protected]  

help / color / mirror / Atom feed

From: Amit Kapila <[email protected]>
To: Tom Lane <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Hou, Zhijie/侯 志杰 <[email protected]>
Subject: Re: Bugs in pgoutput.c
Date: Fri, 4 Feb 2022 17:50:46 +0530
Message-ID: <CAA4eK1+vKM9xUMuWjpGvDCAAdpfpHhoQzqGL8++nfHS4ehp03Q@mail.gmail.com> (raw)
In-Reply-To: <CAA4eK1KYdLj7yhN858SxLrwbtxtre1d=z94bpibZWwueYuHCnw@mail.gmail.com>
References: <[email protected]>
	<CAA4eK1JACZTJqu_pzTu_2Nf-zGAsupqyfk6KBqHe9puVZGQfvw@mail.gmail.com>
	<CAA4eK1+uJZ6qYcZxp_A19ZCByhdhui3T3PZ2_ipnJDpwuuzo-w@mail.gmail.com>
	<[email protected]>
	<CAA4eK1KYdLj7yhN858SxLrwbtxtre1d=z94bpibZWwueYuHCnw@mail.gmail.com>

On Thu, Feb 3, 2022 at 5:24 PM Amit Kapila <[email protected]> wrote:
>
> On Thu, Feb 3, 2022 at 8:18 AM Tom Lane <[email protected]> wrote:
> >
> > Amit Kapila <[email protected]> writes:
> > > Tom, is it okay for you if I go ahead with this patch after some testing?
> >
> > I've been too busy to get back to it, so sure.
> >
>
> Thanks. I have tested the patch by generating an invalidation message
> for table DDL before accessing the syscache in
> logicalrep_write_tuple(). I see that it correctly invalidates the
> entry and rebuilds it for the next operation. I couldn't come up with
> some automatic test for it so used the debugger to test it. I have
> made a minor change in one of the comments. I am planning to push this
> tomorrow unless there are comments or suggestions.
>

Pushed!

-- 
With Regards,
Amit Kapila.

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Bugs in pgoutput.c
  In-Reply-To: <CAA4eK1+vKM9xUMuWjpGvDCAAdpfpHhoQzqGL8++nfHS4ehp03Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox