MIME-Version: 1.0
References: <CAA4eK1KEYtgC3mB683iEq-CQUUSA8=3ZRYB9ZMbWHaU8hey2uA@mail.gmail.com>
 <20230824075044.cn4slf6wgvkpdc7f@alvherre.pgsql> <CAA4eK1JQEaHra+of4eQFyBFzONLhXNscT0miCVHeqgQp7+00AQ@mail.gmail.com>
 <CAA4eK1Jg32htSrjKCAcrvFu+bztUNhdWem8RubuTwgABKjXGDg@mail.gmail.com> <CAHut+PuwaF4Sb41pWQk69d2WO_ZJQpj-_2JkQvP=1jwozUpcCQ@mail.gmail.com>
In-Reply-To: <CAHut+PuwaF4Sb41pWQk69d2WO_ZJQpj-_2JkQvP=1jwozUpcCQ@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Tue, 29 Aug 2023 09:48:11 +0530
Message-ID: <CAA4eK1+yLPNN5jj2ezONZ5rZ7bc2JYNtYCfwWh3A4Y0g3vghmw@mail.gmail.com>
Subject: Re: subscription/015_stream sometimes breaks
To: Peter Smith <smithpb2250@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, 
	"Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, Thomas Munro <thomas.munro@gmail.com>, 
	pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAA4eK1%2ByLPNN5jj2ezONZ5rZ7bc2JYNtYCfwWh3A4Y0g3vghmw%40mail.gmail.com>
Precedence: bulk

On Mon, Aug 28, 2023 at 5:35=E2=80=AFAM Peter Smith <smithpb2250@gmail.com>=
 wrote:
>
> On Fri, Aug 25, 2023 at 8:15=E2=80=AFPM Amit Kapila <amit.kapila16@gmail.=
com> wrote:
>
> IMO there are inconsistencies in the second patch that was pushed.
>
> 1. In the am_xxx functions, why is there Assert 'in_use' only for the
> APPLY / PARALLEL_APPLY workers but not for TABLESYNC workers?
>
> 2. In the am_xxx functions there is now Assert 'in_use', so why are we
> still using macros to check again what we already asserted is not
> possible? (Or, if the checking overkill was a deliberate choice then
> why is there no isLeaderApplyWorker macro?)
>
> ~
>
> PSA a small patch to address these.
>

I find your suggestions reasonable. Alvaro, do you have any comments?

--=20
With Regards,
Amit Kapila.