public inbox for [email protected]
help / color / mirror / Atom feedFrom: Amit Kapila <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: Gyan Sreejith <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: shveta malik <[email protected]>
Cc: Shlok Kyal <[email protected]>
Cc: vignesh C <[email protected]>
Cc: Euler Taveira <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [Proposal] Adding Log File Capability to pg_createsubscriber
Date: Wed, 8 Apr 2026 11:00:58 +0530
Message-ID: <CAA4eK1+yp31nyES9eO39TjT75XLO6M-siQPRV2AwwVRjOaHqYg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <OSOPR01MB1215385EAC6A76650444E40B0F54FA@OSOPR01MB12153.jpnprd01.prod.outlook.com>
<CAA4eK1JiAzaY7UYnya7uDhX-kAL1PrsOAxBtys7c35t4q4H3_A@mail.gmail.com>
<CAEqnbaVF0yXQk=VVzr-8V23E=iUpUqyah6hxx2fy0ZVJh+CaGA@mail.gmail.com>
<CAJpy0uAwPNG3GN5+jTajnccLe+F1mW6dZh-9112u3QQQYugA=Q@mail.gmail.com>
<CAA4eK1JyYHPgaPTow5co8wBh8Ga+fx=vqHLhk2zHeqdOGYN4Vg@mail.gmail.com>
<OS9PR01MB12149FECFFF25973C167F9CFAF54BA@OS9PR01MB12149.jpnprd01.prod.outlook.com>
<CAEqnbaULSSQcir8Z8KDXduV4o4NZvJLeBMZN0VW3wh5QZjpEnw@mail.gmail.com>
<OS9PR01MB1214926DB01BF19C09368188EF548A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
<CAHut+PsmdpYZnXKLYJ8n07-ftaPAbvxH9xuNrvm2c6zxS09z7Q@mail.gmail.com>
<CAEqnbaWsrDhsrBJucqiL7Bx9MKgB3F6imFAE7tF63MZ6okRmAg@mail.gmail.com>
<CAA4eK1JSg3HKm-cFDv0D5adSk8Kbsd6OG=B=HaOU-tLQt2NZ6Q@mail.gmail.com>
<[email protected]>
<OS9PR01MB121494EEBAB83F0076218BB62F550A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
<[email protected]>
On Tue, Apr 7, 2026 at 7:07 PM Peter Eisentraut <[email protected]> wrote:
>
> On 01.04.26 07:05, Hayato Kuroda (Fujitsu) wrote:
> > Dear Peter E.,
> >
> >> Instead of creating a new logging API in pg_createsubscriber locally,
> >> why not extend logging.c to support a log file.
> >
> > I had a concern to extend the common module. Do you have possible idea to use
> > pg_logging_set_logfile() on others? I cannot, tee command on linux seems enough
> > for others.
>
> pg_upgrade was mentioned.
>
I see that pg_upgrade has some specific requirements related to
verbose/status/report kind of messages which doesn't seem to be
directly handled by the generic API pg_log_generic(). For example,
apart from other things, we need to unset/reset log_file when we want
to send messages only to the terminal and quite some specific handling
for status or other kinds of messages. If you think pg_log_generic
could be extended to handle various upgrade cases then I think it
would be a good use case for it and we should go-ahead with what you
are proposing. OTOH, maybe we can give it a separate try and use the
resulting API for both pg_createsubscriber and pg_upgrade. I am fine
either way you would like to go-ahead with this.
--
With Regards,
Amit Kapila.
view thread (55+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [Proposal] Adding Log File Capability to pg_createsubscriber
In-Reply-To: <CAA4eK1+yp31nyES9eO39TjT75XLO6M-siQPRV2AwwVRjOaHqYg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox