MIME-Version: 1.0
References: <CAJpy0uBSCQz1yMD-WiEthzEe23dti2-Kr_pitVb7vAPFbFKm=A@mail.gmail.com>
 <CAEze2Wgm=TvEeDmmyR3pF70k1vhbQFC25fUrV3cRk2HdEECxvg@mail.gmail.com>
 <CAA4eK1+LO+x6RREH434TGw4E_TK1UnrDK8nTL0xLQb4uFEdVMg@mail.gmail.com> <CAJpy0uAx_dw6m1-yCtumgZ7jD3t4EP3V0QnDwhg4G3h6yAi8hA@mail.gmail.com>
In-Reply-To: <CAJpy0uAx_dw6m1-yCtumgZ7jD3t4EP3V0QnDwhg4G3h6yAi8hA@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Mon, 11 Mar 2024 16:36:18 +0530
Message-ID: <CAA4eK1J+k_7Z1+D108zaTZKiSszAnjdAMhogs6a7cKEsGFsjjQ@mail.gmail.com>
Subject: Re: Regardign RecentFlushPtr in WalSndWaitForWal()
To: shveta malik <shveta.malik@gmail.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>, 
	pgsql-hackers <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAA4eK1J%2Bk_7Z1%2BD108zaTZKiSszAnjdAMhogs6a7cKEsGFsjjQ%40mail.gmail.com>
Precedence: bulk

On Mon, Mar 11, 2024 at 4:17=E2=80=AFPM shveta malik <shveta.malik@gmail.co=
m> wrote:
>
> On Sat, Mar 2, 2024 at 4:44=E2=80=AFPM Amit Kapila <amit.kapila16@gmail.c=
om> wrote:
> >
> > Right, I think the quoted code has check "if (!RecoveryInProgress())".
> >
> > >
> >  But apart from that, your
> > > observation seems accurate, yes.
> > >
> >
> > I also find the observation correct and the code has been like that
> > since commit 5a991ef8 [1]. So, let's wait to see if Robert or Andres
> > remembers the reason, otherwise, we should probably nuke this code.
>
> Please find the patch attached for the same.
>

LGTM. I'll push this tomorrow unless I see any comments/objections to
this change.

--=20
With Regards,
Amit Kapila.