MIME-Version: 1.0
References: <514f6f2f-6833-4539-39f1-96cd1e011f23@enterprisedb.com>
 <18dbc929-a281-8552-4f1d-7e4d0e4eedba@enterprisedb.com> <646acd8d-9896-ed8d-2ab4-0bf11b3285d4@enterprisedb.com>
 <20220205195944.drwc3psrb5udt2cw@alap3.anarazel.de> <CAE9k0PnGmQ97ikLy2oBDoom72FsV_x+H9JuptJ4ysx=CFM-+kQ@mail.gmail.com>
 <20220207203222.22aktwxrt3fcllru@alap3.anarazel.de> <CAE9k0Pn80FMhkUZAPyPCLWDYnOcTmxKN3Q3TNNv1m4V99qG-Ew@mail.gmail.com>
 <YgWH4/4tK1AMIOYG@momjian.us> <ac40e8f8-46f5-7bb4-c08b-df3c9e6f1599@enterprisedb.com>
 <aa626ffb-2cb1-8683-5188-dad6031a4623@gmail.com> <b5cc7fd2-ebbc-512f-40fc-5c7ce93b8bdf@gmail.com>
 <aeab9f12-93a6-743d-4ac6-5f2c73f9bfea@gmail.com> <CAA4eK1LrZuDLGu6saZ8RDs7gKLM0dmafq+9oqRPKKN1cEEao_Q@mail.gmail.com>
 <CAJpy0uCMNz3XERP-Vzp-7rHFztJgc6d+xsmUVCqsxWPkZvQz0Q@mail.gmail.com>
 <CALj2ACUV6QzAvzjDDbu2oyhrVgAP98ypobY25b-dQGFom7Gjtw@mail.gmail.com>
 <CAJpy0uCdENWu1eTAcDStBPQeomXgbR1LS7OzDVmsg8wt51uCZg@mail.gmail.com>
 <CALj2ACV+VX9McnogGNyFCjZW+qnPvdmjnBjttotygs8+7D5JuA@mail.gmail.com>
 <CAA4eK1J2h_KhaJNG-Q1W38pgHHpOV+aaC9VN-GuLPTyRfUtgDg@mail.gmail.com> <CAJpy0uCaB30Y7saZD7ZWwOsJbsZwsOaqfRKSoRDxwv47AcahAg@mail.gmail.com>
In-Reply-To: <CAJpy0uCaB30Y7saZD7ZWwOsJbsZwsOaqfRKSoRDxwv47AcahAg@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Thu, 27 Jul 2023 10:54:57 +0530
Message-ID: <CAA4eK1J0AAHSCxQVDA1kOjKB_PWCzk5SqrHA+FxDZCB3TTS43g@mail.gmail.com>
Subject: Re: Synchronizing slots from primary to standby
To: shveta malik <shveta.malik@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, 
	"Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>, 
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Bruce Momjian <bruce@momjian.us>, 
	Ashutosh Sharma <ashu.coek88@gmail.com>, Andres Freund <andres@anarazel.de>, 
	pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAA4eK1J0AAHSCxQVDA1kOjKB_PWCzk5SqrHA%2BFxDZCB3TTS43g%40mail.gmail.com>
Precedence: bulk

On Wed, Jul 26, 2023 at 10:31=E2=80=AFAM shveta malik <shveta.malik@gmail.c=
om> wrote:
>
> On Mon, Jul 24, 2023 at 9:00=E2=80=AFAM Amit Kapila <amit.kapila16@gmail.=
com> wrote:
> >
> > On Mon, Jul 24, 2023 at 8:03=E2=80=AFAM Bharath Rupireddy
> > <bharath.rupireddyforpostgres@gmail.com> wrote:
> > >
> > > Is having one (or a few more - not
> > > necessarily one for each logical slot) worker for all logical slots
> > > enough?
> > >
> >
> > I guess for a large number of slots the is a possibility of a large
> > gap in syncing the slots which probably means we need to retain
> > corresponding WAL for a much longer time on the primary. If we can
> > prove that the gap won't be large enough to matter then this would be
> > probably worth considering otherwise, I think we should find a way to
> > scale the number of workers to avoid the large gap.
> >
>
> How about this:
>
> 1) On standby, spawn 1 worker per database in the start (as it is
> doing currently).
>
> 2) Maintain statistics on activity against each primary's database on
> standby by any means. Could be by maintaining 'last_synced_time' and
> 'last_activity_seen time'.  The last_synced_time is updated every time
> we sync/recheck slots for that particular database. The
> 'last_activity_seen_time' changes only if we get any slot on that
> database where actually confirmed_flush or say restart_lsn has changed
> from what was maintained already.
>
> 3) If at any moment, we find that 'last_synced_time' -
> 'last_activity_seen' goes beyond a threshold, that means that DB is
> not active currently. Add it to list of inactive DB
>

I think we should also increase the next_sync_time if in current sync,
there is no update.

> 4) Launcher on the other hand is always checking if it needs to spawn
> any other extra worker for any new DB. It will additionally check if
> number of inactive databases (maintained on standby) has gone higher
> (> some threshold), then it brings down the workers for those and
> starts a common worker which takes care of all such inactive databases
> (or merge all in 1), while workers for active databases remain as such
> (i.e. one per db). Each worker maintains the list of DBs which it is
> responsible for.
>
> 5) If in the list of these inactive databases, we again find any
> active database using the above logic, then the launcher will spawn a
> separate worker for that.
>

I wonder if we anyway some sort of design like this because we
shouldn't allow to spawn as many workers as the number of databases.
There has to be some existing or new GUC like max_sync_slot_workers
which decided the number of workers.

Overall, this sounds to be a more workload-adaptive approach as
compared to the current one.

--=20
With Regards,
Amit Kapila.