MIME-Version: 1.0
References: <TYCPR01MB837340F78F4A16F542589195EDFF9@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <CAJpy0uC2Czf2iJ17yHf4gnMb9pVJyc2QXVe6_NfxiwHhdNLmVg@mail.gmail.com>
 <TYAPR01MB5866D0527B1B8D589F1C2551F5FC9@TYAPR01MB5866.jpnprd01.prod.outlook.com>
 <20230112.120338.534662300633460797.horikyota.ntt@gmail.com>
 <TYCPR01MB83739C6133B50DDA8BAD1601EDFD9@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <CALDaNm2d=+WBGye015DoACY_PzrRKdmwjeZwDa+Y9LXFqnT0Ow@mail.gmail.com>
 <TYCPR01MB8373F3E780D5BB60E441ECF3EDC69@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <CAHut+PsydEoqQaDv861qS_366hBovYAE8RRoDu3=+sBM=yo3Dg@mail.gmail.com>
 <CAHut+PtzoVdm7wj69fKDrh-KLvUHd4scdTunBsQLo97sZNFLGg@mail.gmail.com>
 <TYCPR01MB8373F5162C7A0E6224670CF0EDC49@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <CAHut+Puwrb_DEV_7ANSKrQr23-dAmL9vrNV8ww7XsAP+kej0uw@mail.gmail.com>
 <TYCPR01MB8373BED9E390C4839AF56685EDC59@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <TYCPR01MB8373A23EFC25B22CB132383AEDCB9@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <ea766b46-c46c-494d-adc7-b6666e9424e9@app.fastmail.com>
In-Reply-To: <ea766b46-c46c-494d-adc7-b6666e9424e9@app.fastmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Mon, 6 Feb 2023 17:26:33 +0530
Message-ID: <CAA4eK1J0cLtAKUg1ezJdHZ1EaSrs-XY0imcNd=16AVS9gSrXxA@mail.gmail.com>
Subject: Re: Time delayed LR (WAS Re: logical replication restrictions)
To: Euler Taveira <euler@eulerto.com>
Cc: "osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>, Peter Smith <smithpb2250@gmail.com>, 
	vignesh C <vignesh21@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, 
	"kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, 
	"shveta.malik@gmail.com" <shveta.malik@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, 
	Melih Mutlu <m.melihmutlu@gmail.com>, Andres Freund <andres@anarazel.de>, 
	Marcos Pegoraro <marcos@f10.com.br>, pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAA4eK1J0cLtAKUg1ezJdHZ1EaSrs-XY0imcNd%3D16AVS9gSrXxA%40mail.gmail.com>
Precedence: bulk

On Tue, Jan 24, 2023 at 5:02 AM Euler Taveira <euler@eulerto.com> wrote:
>
>
> -   elog(DEBUG2, "sending feedback (force %d) to recv %X/%X, write %X/%X, flush %X/%X in-delayed: %d",
> +   elog(DEBUG2, "sending feedback (force %d) to recv %X/%X, write %X/%X, flush %X/%X, apply delay: %s",
>          force,
>          LSN_FORMAT_ARGS(recvpos),
>          LSN_FORMAT_ARGS(writepos),
>          LSN_FORMAT_ARGS(flushpos),
> -        in_delayed_apply);
> +        in_delayed_apply? "yes" : "no");
>
> It is better to use a string to represent the yes/no option.
>

I think it is better to be consistent with the existing force
parameter which is also boolean, otherwise, it will look odd.

-- 
With Regards,
Amit Kapila.