MIME-Version: 1.0
References: <3222278.1716139817@sss.pgh.pa.us> <61182a55-87e6-4019-9274-5f2cc5c38f31@app.fastmail.com>
In-Reply-To: <61182a55-87e6-4019-9274-5f2cc5c38f31@app.fastmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Mon, 20 May 2024 12:12:26 +0530
Message-ID: <CAA4eK1J22UEfrqx222h5j9DQ7nxGrTbAa_BC+=mQXdXs-RCsew@mail.gmail.com>
Subject: Re: State of pg_createsubscriber
To: Euler Taveira <euler@eulerto.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org, 
	Euler Taveira <euler.taveira@enterprisedb.com>, Peter Eisentraut <peter@eisentraut.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAA4eK1J22UEfrqx222h5j9DQ7nxGrTbAa_BC%2B%3DmQXdXs-RCsew%40mail.gmail.com>
Precedence: bulk

On Sun, May 19, 2024 at 11:20=E2=80=AFPM Euler Taveira <euler@eulerto.com> =
wrote:
>
> On Sun, May 19, 2024, at 2:30 PM, Tom Lane wrote:
>
> I'm fairly disturbed about the readiness of pg_createsubscriber.
> The 040_pg_createsubscriber.pl TAP test is moderately unstable
> in the buildfarm [1], and there are various unaddressed complaints
> at the end of the patch thread (pretty much everything below [2]).
> I guess this is good enough to start beta with, but it's far from
> being good enough to ship, IMO.  If there were active work going
> on to fix these things, I'd feel better, but neither the C code
> nor the test script have been touched since 1 April.
>
>
> My bad. :( I'll post patches soon to address all of the points.
>

Just to summarize, apart from BF failures for which we had some
discussion, I could recall the following open points:

1. After promotion, the pre-existing replication objects should be
removed (either optionally or always), otherwise, it can lead to a new
subscriber not being able to restart or getting some unwarranted data.
[1][2].

2. Retaining synced slots on new subscribers can lead to unnecessary
WAL retention and dead rows [3].

3. We need to consider whether some of the messages displayed in
--dry-run mode are useful or not [4].

[1] - https://www.postgresql.org/message-id/CAA4eK1L6HOhT1qifTyuestXkPpkRwY=
9bOqFd4wydKsN6C3hePA%40mail.gmail.com
[2] - https://www.postgresql.org/message-id/flat/3fa9ef0f-b277-4c13-850a-8c=
cc04de1406%40eisentraut.org#152dacecfc8f0cf08cbd8ecb79d6d38f
[3] - https://www.postgresql.org/message-id/CAA4eK1KdCb%2B5sjYu6qCMXXdCX1y_=
ihr8kFzMozq0%3DP%3DauYxgog%40mail.gmail.com
[4] - https://www.postgresql.org/message-id/flat/3fa9ef0f-b277-4c13-850a-8c=
cc04de1406%40eisentraut.org#152dacecfc8f0cf08cbd8ecb79d6d38f

--=20
With Regards,
Amit Kapila.