MIME-Version: 1.0
References: 
 <TYCPR01MB8373DC922E549FF3F031E9DAED8E9@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <CAJcOf-cMU_1VJ1c+9fwEBgimkj+=hHcCjj_SUfbHvKTuN=1tuw@mail.gmail.com>
 <TYCPR01MB8373B1614522B90BA96883E0ED929@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <CALDaNm3-QTZnd4rxbrUfKMM4u_vgb23LO+KW3O9LX7X6b8mr8A@mail.gmail.com>
 <CALDaNm130T4jr2RvpgY19SCY87UQ75wVbjrhjGj43bHV=9-LpQ@mail.gmail.com>
 <TYCPR01MB8373FEB287F733C81C1E4D42ED989@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <TYCPR01MB8373D7AE0B6C62E5CDB03C6CED989@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <TYCPR01MB8373CFDCD60CCDB1C35CFA45ED999@TYCPR01MB8373.jpnprd01.prod.outlook.com>
 <CAD21AoBAREVDtAM+JGR3DcnwnOi1Nw7E_5m68ZwFUGkOkfDn1Q@mail.gmail.com>
 <TYCPR01MB8373271BE5D4619302C05B00ED9A9@TYCPR01MB8373.jpnprd01.prod.outlook.com>
In-Reply-To: 
 <TYCPR01MB8373271BE5D4619302C05B00ED9A9@TYCPR01MB8373.jpnprd01.prod.outlook.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Wed, 17 Nov 2021 18:30:04 +0530
Message-ID: 
 <CAA4eK1JCbhxuO8fEaAaw8e30=5kEDaFRXpV2+opAdMoEOH5LEg@mail.gmail.com>
Subject: Re: Failed transaction statistics to measure the logical replication
 progress
To: "osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, vignesh C <vignesh21@gmail.com>,
	Greg Nancarrow <gregn4422@gmail.com>,
 "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA4eK1JCbhxuO8fEaAaw8e30%3D5kEDaFRXpV2%2BopAdMoEOH5LEg%40mail.gmail.com>
Precedence: bulk

On Wed, Nov 17, 2021 at 9:44 AM osumi.takamichi@fujitsu.com
<osumi.takamichi@fujitsu.com> wrote:
>
> On Wednesday, November 17, 2021 12:19 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> > On Tue, Nov 16, 2021 at 9:34 PM osumi.takamichi@fujitsu.com
> > <osumi.takamichi@fujitsu.com> wrote:
> > >
> > > On Monday, November 15, 2021 9:14 PM I wrote:
> > > > I've conducted some update for this.
> > > > (The rebased part is only C code and checked by pgindent)
> > > I'll update my patches since a new skip xid patch has been shared in
> > > [1].
> > >
> > > This version includes some minor renames of functions that are related
> > > to transaction sizes.
> >
> > I've looked at v12-0001 patch. Here are some comments:
> Thank you for paying attention to this thread !
>
>
> > -   TupleDescInitEntry(tupdesc, (AttrNumber) 3, "relid",
> > +   TupleDescInitEntry(tupdesc, (AttrNumber) 3, "last_error_relid",
> >                        OIDOID, -1, 0);
> > -   TupleDescInitEntry(tupdesc, (AttrNumber) 4, "command",
> > +   TupleDescInitEntry(tupdesc, (AttrNumber) 4, "last_error_command",
> >                        TEXTOID, -1, 0);
> > -   TupleDescInitEntry(tupdesc, (AttrNumber) 5, "xid",
> > +   TupleDescInitEntry(tupdesc, (AttrNumber) 5, "last_error_xid",
> >                        XIDOID, -1, 0);
> > -   TupleDescInitEntry(tupdesc, (AttrNumber) 6, "error_count",
> > +   TupleDescInitEntry(tupdesc, (AttrNumber) 6, "last_error_count",
> >                        INT8OID, -1, 0);
> > -   TupleDescInitEntry(tupdesc, (AttrNumber) 7, "error_message",
> > +   TupleDescInitEntry(tupdesc, (AttrNumber) 7, "last_error_message",
> >
> > If renaming column names clarifies those meanings, the above changes should
> > be included into my patch that introduces pg_stat_subscription_workers
> > view?

Right.

> At first, your column names of pg_stat_subscription_workers look totally OK to me by itself
> and I thought I should take care of those renaming at the commit timing of my stats patches.
>

Can you please tell us why you think the names in your proposed patch
are better than the existing names proposed in Sawada-San's patch? Is
it because those fields always contain the information of the last or
latest error that occurred in the corresponding subscription worker?
If so, I am not very sure if that is a good reason to increase the
length of most of the column names but if you and others feel that is
helpful then it is better to do it as part of Sawada-San's patch.

-- 
With Regards,
Amit Kapila.