MIME-Version: 1.0
References: <CAFiTN-tLrc-f042EGUtYHxenOASc0LhEWt4s9EOddi_JCDJeEA@mail.gmail.com>
In-Reply-To: <CAFiTN-tLrc-f042EGUtYHxenOASc0LhEWt4s9EOddi_JCDJeEA@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Fri, 8 Nov 2024 16:26:05 +0530
Message-ID: <CAA4eK1JEotM3K9JrDwhNJmfEuOW9bpV5Eh+TTneaOQiLJYfW6w@mail.gmail.com>
Subject: Re: Fix small typo, use InvalidRelFileNumber instead of InvalidOid
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAA4eK1JEotM3K9JrDwhNJmfEuOW9bpV5Eh%2BTTneaOQiLJYfW6w%40mail.gmail.com>
Precedence: bulk

On Fri, Nov 8, 2024 at 3:17=E2=80=AFPM Dilip Kumar <dilipbalaut@gmail.com> =
wrote:
>
> It appears that we are passing InvalidOid instead of InvalidRelFileNumber=
 when calling index_create(). While this isn=E2=80=99t technically a bug, s=
ince InvalidRelFileNumber is defined as InvalidOid, it=E2=80=99s preferable=
 to use the correct identifier for clarity and consistency.
>

Agreed. We already use InvalidRelFileNumber at one of the other
callers in index_concurrently_create_copy(). Your patch looks good to
me.

--=20
With Regards,
Amit Kapila.