public inbox for [email protected]  

help / color / mirror / Atom feed

From: Amit Kapila <[email protected]>
To: shveta malik <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Cc: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Zhijie Hou (Fujitsu) <[email protected]>
Cc: Doruk Yilmaz <[email protected]>
Subject: Re: [Patch] add new parameter to pg_replication_origin_session_setup
Date: Thu, 26 Mar 2026 12:10:08 +0530
Message-ID: <CAA4eK1JJHvaUNfxHqOXLQ7ERwDQT2iKT9wU8B1RYT7gmjtZD-g@mail.gmail.com> (raw)
In-Reply-To: <CAJpy0uB-orRxTL-8MJ+i9riBZkvVdP_T+p71GyHnJRYw-MrXVg@mail.gmail.com>
References: <CAJpy0uB19aKEgVgh8gwzj87NUyDgOf01boa-6xJZK+nhb=3W4g@mail.gmail.com>
	<CAA4eK1+h4mOvRqRaGfUtSgZuBhzWWmrBcY3jQ4DDV=cEJ4dwnQ@mail.gmail.com>
	<TY7PR01MB145543A74547443E49E4993E7F58EA@TY7PR01MB14554.jpnprd01.prod.outlook.com>
	<CAJpy0uD6D294d=Hq4oROmtKAew5DfKERNxs=DsAwUFBFF2kERg@mail.gmail.com>
	<TY7PR01MB14554FB7D02601425DE3752DEF58FA@TY7PR01MB14554.jpnprd01.prod.outlook.com>
	<CAA4eK1JvYROk5usAX0Uy=00VACB=w1rvUcyoKvRuke5EMfmi3Q@mail.gmail.com>
	<[email protected]>
	<CAJpy0uD5T692uyaRr0GKqd1eLHW55A0=MH-V8tRPicTxDqMu=g@mail.gmail.com>
	<CAA4eK1LN+T1pLfGBxDW-gps5h-YX6FAjRwkKaV2wwQDDVdi6fw@mail.gmail.com>
	<CAJpy0uBm7m5AFgg6xgWB6msGrivusoDe7PKg9XKHYm_JYQnegg@mail.gmail.com>
	<CAA4eK1JWM_GxnDn8T0+B3+dEqzACkUj7rvfy_B_ukq5myvqxGg@mail.gmail.com>
	<CAJpy0uB-orRxTL-8MJ+i9riBZkvVdP_T+p71GyHnJRYw-MrXVg@mail.gmail.com>

On Wed, Mar 25, 2026 at 3:03 PM shveta malik <[email protected]> wrote:
>
> On Wed, Mar 25, 2026 at 1:51 PM Amit Kapila <[email protected]> wrote:
> >
> > On Wed, Feb 11, 2026 at 5:09 PM shveta malik <[email protected]> wrote:
> > >
> > > On Wed, Feb 11, 2026 at 3:41 PM Amit Kapila <[email protected]> wrote:
> > > >
> > > >
> > > > I see your point but one advantage with the proposed code change is
> > > > that it started to appear that we can extend this part of code easily
> > > > in the future as it separates most of the handling related to when a
> > > > user has given acquired_by parameter's value as zero and non-zero.
> > >
> > > Okay, yes. So I am okay with it. The slight change I suggested (if to
> > > else-if) and a comment will make it more clean.
> > >
> >
> > I have tried to address both your suggestions in the attached. See, if
> > this looks okay to you now?
> >
>
> LGTM now, thanks!
>

Pushed.

-- 
With Regards,
Amit Kapila.

view thread (30+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [Patch] add new parameter to pg_replication_origin_session_setup
  In-Reply-To: <CAA4eK1JJHvaUNfxHqOXLQ7ERwDQT2iKT9wU8B1RYT7gmjtZD-g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox