MIME-Version: 1.0
References: <CAFPTHDZXX9WQ_X1ZfEvS248T+pKuk6SmCnXcvgPM059N1xPUfA@mail.gmail.com>
 <CAJpy0uDLUEjHHME8om1vAf6qkXCeRR6cBvkpK8yWBAC=T0ZFLA@mail.gmail.com>
 <CAFPTHDZg1JrunGgOj332hr+gUuH_Jm7skqPpYSvd-QE3yEdRDQ@mail.gmail.com>
 <CAJpy0uBz7MCSUkvFJD9ij65vBahNmY+bfCgdGKRqXovYs+K_TA@mail.gmail.com>
 <CAJpy0uDsuNqjWd-TmGBxqSS1rnVCJ3B8=SYrtxQ=Vs8kb71QFA@mail.gmail.com>
 <CAJpy0uAMWg3KcXtVBS7B0rnchLNrCCVYBByJCzAp=u5LERgtfA@mail.gmail.com>
 <CAFPTHDZwEhxhDAeqcPi0GuYN6xBs8gFXHOMUnbg3u2Xigcz4Zg@mail.gmail.com>
 <CAE9k0PmTyCU1A9YEf+MRgfeZ8yK1bAYJu=o0bH8DNUTzXejQyQ@mail.gmail.com>
 <CAA4eK1L6czEzG4mLNZSyjYC5nX0FMSjjk3csKuxPD3Ph5-7Yvw@mail.gmail.com>
 <CAJpy0uAhGQJ=msVsn2GsqWXr+YESJK6x9NBvrUtKvtvp1OVuKQ@mail.gmail.com>
 <CAJpy0uAOuu-M6wobH2wHOdTymm-cX9+MqwPyRNoOt=sPKBdCew@mail.gmail.com>
 <CAFPTHDZiWYXoKoo4VcBYNH9a=gxDZhfkcBeXt5w6cLw4_ysyKw@mail.gmail.com>
 <OS9PR01MB12149D9054CC7F2DC3F0D26A1F577A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
 <CAA4eK1KYxQALt46k5uWOO6SUtNjvjOaXwfNjH0AU656YrcGZEw@mail.gmail.com>
 <CAFPTHDZYonM+SXG19VVjgWduXQJSuDhcOUWq0NCiiuQubCSt6g@mail.gmail.com> <CAFPTHDYud1zr0VyizhyhEQXfHMgXVcHrPzE56WUKGCFNskQq2A@mail.gmail.com>
In-Reply-To: <CAFPTHDYud1zr0VyizhyhEQXfHMgXVcHrPzE56WUKGCFNskQq2A@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Fri, 27 Feb 2026 16:37:28 +0530
Message-ID: <CAA4eK1JTau3fV7br6xwAV+LXXwM65RuGCuM2J3PQpCONtL1KXA@mail.gmail.com>
Subject: Re: [PATCH] Support automatic sequence replication
To: Ajin Cherian <itsajin@gmail.com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, shveta malik <shveta.malik@gmail.com>, 
	Ashutosh Sharma <ashu.coek88@gmail.com>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000f7a37a064bcc3e71"
Archived-At: <https://www.postgresql.org/message-id/CAA4eK1JTau3fV7br6xwAV%2BLXXwM65RuGCuM2J3PQpCONtL1KXA%40mail.gmail.com>
Precedence: bulk

--000000000000f7a37a064bcc3e71
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 26, 2026 at 1:07=E2=80=AFPM Ajin Cherian <itsajin@gmail.com> wr=
ote:
>

Few comments:
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
1.
+ oldctx =3D MemoryContextSwitchTo(SequenceSyncContext);

- initStringInfo(&app_name);
- appendStringInfo(&app_name, "pg_%u_sequence_sync_" UINT64_FORMAT,
- MySubscription->oid, GetSystemIdentifier());
+ /* Process sequences */
+ sequence_copied =3D copy_sequences(conn, seqinfos);

- /*
- * Establish the connection to the publisher for sequence synchronization.
- */
- LogRepWorkerWalRcvConn =3D
- walrcv_connect(MySubscription->conninfo, true, true,
-    must_use_password,
-    app_name.data, &err);
- if (LogRepWorkerWalRcvConn =3D=3D NULL)
- ereport(ERROR,
- errcode(ERRCODE_CONNECTION_FAILURE),
- errmsg("sequencesync worker for subscription \"%s\" could not
connect to the publisher: %s",
-    MySubscription->name, err));
-
- pfree(app_name.data);
-
- copy_sequences(LogRepWorkerWalRcvConn);
+ MemoryContextSwitchTo(oldctx);

It is better to switch to SequenceSyncContext at the caller of
LogicalRepSyncSequences similar to what we are doing for
ApplyMessageContext.

2.
@@ -4221,6 +4221,7 @@ LogicalRepApplyLoop(XLogRecPtr last_received)
  ProcessConfigFile(PGC_SIGHUP);
  }

+
  if (rc & WL_TIMEOUT)

Spurious line addition.

3. Apart from above, the attached patch contains comments and cosmetic chan=
ges.

--=20
With Regards,
Amit Kapila.

--000000000000f7a37a064bcc3e71
Content-Type: text/plain; charset="US-ASCII"; name="v7_amit_1.patch.txt"
Content-Disposition: attachment; filename="v7_amit_1.patch.txt"
Content-Transfer-Encoding: base64
Content-ID: <f_mm4sflgi0>
X-Attachment-Id: f_mm4sflgi0

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL2xvZ2ljYWwvc2VxdWVuY2VzeW5j
LmMgYi9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi9sb2dpY2FsL3NlcXVlbmNlc3luYy5jCmluZGV4
IGZmYmJkMTI1N2QwLi4zODk4YjMxNWJiOCAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvcmVwbGlj
YXRpb24vbG9naWNhbC9zZXF1ZW5jZXN5bmMuYworKysgYi9zcmMvYmFja2VuZC9yZXBsaWNhdGlv
bi9sb2dpY2FsL3NlcXVlbmNlc3luYy5jCkBAIC0xMTEsOCArMTExLDggQEAgc3RhdGljIE1lbW9y
eUNvbnRleHQgU2VxdWVuY2VTeW5jQ29udGV4dCA9IE5VTEw7CiAgKiB1bnN5bmNocm9uaXplZCBh
ZnRlciBpdCBleGl0cywgYSBuZXcgd29ya2VyIGNhbiBiZSBzdGFydGVkIGluIHRoZSBuZXh0CiAg
KiBpdGVyYXRpb24uCiAgKgotICogVGhlIHBvaW50ZXIgdG8gdGhlIHNlcXVlbmNlc3luYyB3b3Jr
ZXIgaXMgY2FjaGVkIHRvIGF2b2lkIGFjcXVpcmluZyBhbgotICogTFdMb2NrIGFuZCBzY2Fubmlu
ZyB0aGUgd29ya2VycyBhcnJheSBlYWNoIHRpbWUgdmlhIGxvZ2ljYWxyZXBfd29ya2VyX2ZpbmQo
KS4KKyAqIFRoZSBwb2ludGVyIHRvIHRoZSBzZXF1ZW5jZXN5bmMgd29ya2VyIGlzIGNhY2hlZCB0
byBhdm9pZCBzY2FubmluZyB0aGUKKyAqIHdvcmtlcnMgYXJyYXkgZWFjaCB0aW1lIHZpYSBsb2dp
Y2FscmVwX3dvcmtlcl9maW5kKCkuCiAgKi8KIHZvaWQKIE1heWJlTGF1bmNoU2VxdWVuY2VTeW5j
V29ya2VyKHZvaWQpCkBAIC0xMzcsNyArMTM3LDcgQEAgTWF5YmVMYXVuY2hTZXF1ZW5jZVN5bmNX
b3JrZXIodm9pZCkKIAlMV0xvY2tBY3F1aXJlKExvZ2ljYWxSZXBXb3JrZXJMb2NrLCBMV19TSEFS
RUQpOwogCiAJLyoKLQkgKiBSZXR1cm4gaWYgdGhlIHNlcXVlbmNlIHN5bmMgd29ya2VyIGZvciB0
aGUgY3VycmVudCBzdWJzY3JpcHRpb24gaXMKKwkgKiBRdWljayBleGl0IGlmIHRoZSBzZXF1ZW5j
ZSBzeW5jIHdvcmtlciBmb3IgdGhlIGN1cnJlbnQgc3Vic2NyaXB0aW9uIGlzCiAJICogYWxyZWFk
eSBhbGl2ZS4KIAkgKi8KIAlpZiAoc2VxdWVuY2VzeW5jX3dvcmtlciAmJgpAQCAtNTg2LDkgKzU4
Niw4IEBAIGNvcHlfc2VxdWVuY2VzKFdhbFJlY2VpdmVyQ29ubiAqY29ubiwgTGlzdCAqc2VxaW5m
b3MpCiAJCQl7CiAJCQkJY2FzZSBDT1BZU0VRX1NVQ0NFU1M6CiAJCQkJCWVsb2coREVCVUcxLAot
CQkJCQkJICJsb2dpY2FsIHJlcGxpY2F0aW9uIHN5bmNocm9uaXphdGlvIGZvciBzdWJzY3JpcHRp
b24gXCIlc1wiLCBzZXF1ZW5jZSBcIiVzLiVzXCIgaGFzIGJlZW4gdXBkYXRlZCIsCi0JCQkJCQkg
TXlTdWJzY3JpcHRpb24tPm5hbWUsIHNlcWluZm8tPm5zcG5hbWUsCi0JCQkJCQkgc2VxaW5mby0+
c2VxbmFtZSk7CisJCQkJCQkgImxvZ2ljYWwgcmVwbGljYXRpb24gc3luY2hyb25pemF0aW9uIGhh
cyB1cGRhdGVkIHNlcXVlbmNlIFwiJXMuJXNcIiBpbiBzdWJzY3JpcHRpb24gXCIlc1wiIiwKKwkJ
CQkJCSBzZXFpbmZvLT5uc3BuYW1lLCBzZXFpbmZvLT5zZXFuYW1lLCBNeVN1YnNjcmlwdGlvbi0+
bmFtZSk7CiAJCQkJCWJhdGNoX3N1Y2NlZWRlZF9jb3VudCsrOwogCQkJCQlzZXF1ZW5jZV9jb3Bp
ZWQgPSB0cnVlOwogCQkJCQlicmVhazsKQEAgLTc2NSwxNCArNzY0LDEyIEBAIExvZ2ljYWxSZXBT
eW5jU2VxdWVuY2VzKFdhbFJlY2VpdmVyQ29ubiAqY29ubikKIAkJICogYWxsb2NhdGUgdGhlbSB1
bmRlciBTZXF1ZW5jZVN5bmNDb250ZXh0LgogCQkgKi8KIAkJb2xkY3R4ID0gTWVtb3J5Q29udGV4
dFN3aXRjaFRvKFNlcXVlbmNlU3luY0NvbnRleHQpOwotCiAJCXNlcSA9IHBhbGxvYzBfb2JqZWN0
KExvZ2ljYWxSZXBTZXF1ZW5jZUluZm8pOwogCQlzZXEtPmxvY2FscmVsaWQgPSBzdWJyZWwtPnNy
cmVsaWQ7CiAJCXNlcS0+bnNwbmFtZSA9IGdldF9uYW1lc3BhY2VfbmFtZShSZWxhdGlvbkdldE5h
bWVzcGFjZShzZXF1ZW5jZV9yZWwpKTsKIAkJc2VxLT5zZXFuYW1lID0gcHN0cmR1cChSZWxhdGlv
bkdldFJlbGF0aW9uTmFtZShzZXF1ZW5jZV9yZWwpKTsKIAkJc2VxLT5yZWxzdGF0ZSA9IHJlbHN0
YXRlOwogCQlzZXFpbmZvcyA9IGxhcHBlbmQoc2VxaW5mb3MsIHNlcSk7Ci0KIAkJTWVtb3J5Q29u
dGV4dFN3aXRjaFRvKG9sZGN0eCk7CiAKIAkJdGFibGVfY2xvc2Uoc2VxdWVuY2VfcmVsLCBOb0xv
Y2spOwpAQCAtODYwLDcgKzg1Nyw2IEBAIHN0YXJ0X3NlcXVlbmNlX3N5bmModm9pZCkKIAogCQkJ
LyogUHJvY2VzcyBhbnkgaW52YWxpZGF0aW9uIG1lc3NhZ2VzIHRoYXQgbWlnaHQgaGF2ZSBhY2N1
bXVsYXRlZCAqLwogCQkJQWNjZXB0SW52YWxpZGF0aW9uTWVzc2FnZXMoKTsKLQogCQkJbWF5YmVf
cmVyZWFkX3N1YnNjcmlwdGlvbigpOwogCiAJCQkvKgpAQCAtODc1LDcgKzg3MSw2IEBAIHN0YXJ0
X3NlcXVlbmNlX3N5bmModm9pZCkKIAkJCX0KIAkJCWVsc2UKIAkJCXsKLQogCQkJCS8qCiAJCQkJ
ICogRG91YmxlIHRoZSBzbGVlcCB0aW1lLCBidXQgbm90IGJleW9uZAogCQkJCSAqIHRoZSBtYXhp
bXVtIGFsbG93YWJsZSB2YWx1ZS4K
--000000000000f7a37a064bcc3e71--