MIME-Version: 1.0
References: 
 <CAA4eK1JQTDXTfvJ5d+L0ggG4+doyd0Xji=e0OJsb=qcn_jWALA@mail.gmail.com>
 <OS0PR01MB5716D6D2765E54DC739F288E940A9@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <OS0PR01MB5716997A7115715F9E4EE520940D9@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAA4eK1JEFVZcymteMYXhYghiX7Lb=MKuEsfxgD1VfaRrLCHyzg@mail.gmail.com>
 <OS0PR01MB571663F65904D00895AD159994109@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAA4eK1JuRPUY2Dx=vUToRksTmW0ptqMVT3K32g0368f_ZCk-zg@mail.gmail.com>
 <OS0PR01MB5716B802A1733548A99761AE94129@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAA4eK1LGKYUDFZ_jFPrU497wQf2HNvt5a+tCTpqSeWSG6kfpSA@mail.gmail.com>
 <CAA4eK1Jwh7j86Egk1cye=x2R_yrTjzXGj7Fx12wVybBAEq91kA@mail.gmail.com>
 <OS0PR01MB571690D6FF24E9D000ECBDBD94199@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <OS0PR01MB571639E4141EBF8A2C501E6994189@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAA4eK1+ELh2vPre3JHyoeKV0A9_V7aXQD0QBPv86WEn7P_rK-g@mail.gmail.com>
 <OS0PR01MB57166A377638E57823219E32941A9@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAA4eK1KpN=dZPcCj=TLwh3wk9uvPB-M1Jrjw7wt+-L62YrDHFQ@mail.gmail.com>
 <OS0PR01MB571604D401DE7A0659BD6609941D9@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAA4eK1LJMpBYbgDVz=g4qig8C2bM10PK=DgW7o1zn8X426vJ+Q@mail.gmail.com>
 <OS0PR01MB571663B4EC5D8BE749AACD98941E9@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAD21AoD_3ta_29sopuf_KJCExverP5808HjwDeqaHDrbqbxYww@mail.gmail.com>
 <OS0PR01MB5716D38323B07EB0A0D097F194E09@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAA4eK1Kumnc+AR86AGJ666+4Ebfny+nMbs_JZSW3O__UEiGp6w@mail.gmail.com>
 <OS0PR01MB57169DAA9A2A6E68EE5E05F094E19@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAD21AoA-i_Gr1Quo2JN56ORafL=phqD=5hUvbA40EHMRZjArQA@mail.gmail.com>
 <OS0PR01MB5716E94C5E503CC53177A22994E69@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAA4eK1KkrkAzO-=_k_6s5V1+uNUFkvxMK-33MaFw=JCw5Hqs3w@mail.gmail.com>
 <CAA4eK1LRqEXAmh2ZEG-8XK_xDLu2Zzdoj86v4iNXDy++B2SBnQ@mail.gmail.com>
 <OS0PR01MB5716C3561CF53027F22B47AF94E79@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAA4eK1KdVRffYEYiv9=4tVWhP=Jkfh1h6FM0A1R0NEe8cLT8+g@mail.gmail.com>
In-Reply-To: 
 <CAA4eK1KdVRffYEYiv9=4tVWhP=Jkfh1h6FM0A1R0NEe8cLT8+g@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Tue, 20 Dec 2022 14:41:52 +0530
Message-ID: 
 <CAA4eK1JU4J3-Z=fcMcyQw-iG-DNr=u6w_g-iM_4xwg1pKupkFQ@mail.gmail.com>
Subject: Re: Perform streaming logical transactions by background workers and
 parallel apply
To: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>,
	"wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>,
 Peter Smith <smithpb2250@gmail.com>,
	Dilip Kumar <dilipbalaut@gmail.com>,
 "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000504f4505f03ed477"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA4eK1JU4J3-Z%3DfcMcyQw-iG-DNr%3Du6w_g-iM_4xwg1pKupkFQ%40mail.gmail.com>
Precedence: bulk

--000000000000504f4505f03ed477
Content-Type: text/plain; charset="UTF-8"

On Mon, Dec 19, 2022 at 6:17 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Sat, Dec 17, 2022 at 7:34 PM houzj.fnst@fujitsu.com
> <houzj.fnst@fujitsu.com> wrote:
> >
> > Agreed. I have addressed all the comments and did some cosmetic changes.
> > Attach the new version patch set.
> >
>
> Few comments:
> ============
>

Few more minor points:
1.
-static inline void
+void
 changes_filename(char *path, Oid subid, TransactionId xid)
 {

This function seems to be used only in worker.c. So, what is the need
to make it extern?

2. I have made a few changes in the comments. See attached. This is
atop my yesterday's top-up patch.

I think we should merge the 0001 and 0002 patches as they need to be
committed together.

-- 
With Regards,
Amit Kapila.

--000000000000504f4505f03ed477
Content-Type: application/octet-stream; name="changes_amit_2.patch"
Content-Disposition: attachment; filename="changes_amit_2.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lbw0atn70>
X-Attachment-Id: f_lbw0atn70

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL2xvZ2ljYWwvd29ya2VyLmMgYi9z
cmMvYmFja2VuZC9yZXBsaWNhdGlvbi9sb2dpY2FsL3dvcmtlci5jCmluZGV4IGRmNjc4NTFhYzAu
Ljc1MTE5MTgzZGEgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL2xvZ2ljYWwv
d29ya2VyLmMKKysrIGIvc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vbG9naWNhbC93b3JrZXIuYwpA
QCAtMTg4Miw3ICsxODgyLDYgQEAgYXBwbHlfaGFuZGxlX3N0cmVhbV9hYm9ydChTdHJpbmdJbmZv
IHMpCiAJCQkJCXBhX3VubG9ja19zdHJlYW0oeGlkLCBBY2Nlc3NFeGNsdXNpdmVMb2NrKTsKIAkJ
CQkJKHZvaWQpIHBhX2ZyZWVfd29ya2VyKHdpbmZvKTsKIAkJCQl9Ci0KIAkJCQlicmVhazsKIAkJ
CX0KIApAQCAtMTkyNyw4ICsxOTI2LDggQEAgYXBwbHlfaGFuZGxlX3N0cmVhbV9hYm9ydChTdHJp
bmdJbmZvIHMpCiAJCQkgKiBXZSBuZWVkIHRvIHdhaXQgYWZ0ZXIgcHJvY2Vzc2luZyByb2xsYmFj
ayB0byBzYXZlcG9pbnQgZm9yIHRoZQogCQkJICogbmV4dCBzZXQgb2YgY2hhbmdlcy4KIAkJCSAq
Ci0JCQkgKiBXZSBoYXZlIGEgcmFjZSBjb25kaXRpb24gaGVyZSB3aGVuIHdlIGNhbiBzdGFydCB3
YWl0aW5nIGhlcmUKLQkJCSAqIHdoZW4gdGhlcmUgYXJlIG1vcmUgY2h1bmsgb2Ygc3RyZWFtcyBp
biB0aGUgcXVldWUuIFNlZQorCQkJICogV2UgaGF2ZSBhIHJhY2UgY29uZGl0aW9uIGhlcmUgZHVl
IHRvIHdoaWNoIHdlIGNhbiBzdGFydCB3YWl0aW5nCisJCQkgKiBoZXJlIHdoZW4gdGhlcmUgYXJl
IG1vcmUgY2h1bmsgb2Ygc3RyZWFtcyBpbiB0aGUgcXVldWUuIFNlZQogCQkJICogYXBwbHlfaGFu
ZGxlX3N0cmVhbV9zdG9wLgogCQkJICovCiAJCQlpZiAoIXRvcGxldmVsX3hhY3QpCkBAIC00MjQy
LDggKzQyNDEsOCBAQCBzdHJlYW1fd3JpdGVfY2hhbmdlKGNoYXIgYWN0aW9uLCBTdHJpbmdJbmZv
IHMpCiAgKgkgIFNlcmlhbGl6ZSBhIG1lc3NhZ2UgdG8gYSBmaWxlIGZvciB0aGUgZ2l2ZW4gdHJh
bnNhY3Rpb24uCiAgKgogICogVGhpcyBmdW5jdGlvbiBpcyBzaW1pbGFyIHRvIHN0cmVhbV93cml0
ZV9jaGFuZ2UgZXhjZXB0IHRoYXQgaXQgd2lsbCBvcGVuIHRoZQotICogdGFyZ2V0IGZpbGUgaWYg
bm90IGFscmVhZHkgYmVmb3JlIHdyaXRpbmcgdGhlIG1lc3NhZ2UgYW5kIGNsb3NlIGZpbGUgYXQg
dGhlCi0gKiBlbmQuCisgKiB0YXJnZXQgZmlsZSBpZiBub3QgYWxyZWFkeSBiZWZvcmUgd3JpdGlu
ZyB0aGUgbWVzc2FnZSBhbmQgY2xvc2UgdGhlIGZpbGUgYXQKKyAqIHRoZSBlbmQuCiAgKi8KIHN0
YXRpYyB2b2lkCiBzdHJlYW1fb3Blbl9hbmRfd3JpdGVfY2hhbmdlKFRyYW5zYWN0aW9uSWQgeGlk
LCBjaGFyIGFjdGlvbiwgU3RyaW5nSW5mbyBzKQpAQCAtNDkyNiwxMCArNDkyNSw5IEBAIHNldF9h
cHBseV9lcnJvcl9jb250ZXh0X29yaWdpbihjaGFyICpvcmlnaW5uYW1lKQogfQogCiAvKgotICog
UmV0dXJuIHRoZSBhY3Rpb24gdG8gdGFrZSBmb3IgdGhlIGdpdmVuIHRyYW5zYWN0aW9uLiAqd2lu
Zm8gaXMgYXNzaWduZWQgdG8KLSAqIHRoZSBkZXN0aW5hdGlvbiBwYXJhbGxlbCB3b3JrZXIgaW5m
byAoaWYgdGhlIGFjdGlvbiBpcwotICogVFJBTlNfTEVBREVSX1NFTkRfVE9fUEFSQUxMRUwgb3Ig
VFJBTlNfTEVBREVSX1BBUlRJQUxfU0VSSUFMSVpFKSwgb3RoZXJ3aXNlCi0gKiAqd2luZm8gaXMg
YXNzaWduZWQgTlVMTC4KKyAqIFJldHVybiB0aGUgYWN0aW9uIHRvIGJlIHRha2VuIGZvciB0aGUg
Z2l2ZW4gdHJhbnNhY3Rpb24uICp3aW5mbyBpcworICogYXNzaWduZWQgdG8gdGhlIGRlc3RpbmF0
aW9uIHBhcmFsbGVsIHdvcmtlciBpbmZvIHdoZW4gdGhlIGdpdmVuCisgKiB0cmFuc2FjdGlvbiBp
cyBiZWluZyBwcm9jZXNzZWQgdXNpbmcgYSBwYXJhbGxlbCBhcHBseSB3b3JrZXIuCiAgKi8KIHN0
YXRpYyBUcmFuc0FwcGx5QWN0aW9uCiBnZXRfdHJhbnNhY3Rpb25fYXBwbHlfYWN0aW9uKFRyYW5z
YWN0aW9uSWQgeGlkLCBQYXJhbGxlbEFwcGx5V29ya2VySW5mbyAqKndpbmZvKQpkaWZmIC0tZ2l0
IGEvc3JjL2luY2x1ZGUvcmVwbGljYXRpb24vd29ya2VyX2ludGVybmFsLmggYi9zcmMvaW5jbHVk
ZS9yZXBsaWNhdGlvbi93b3JrZXJfaW50ZXJuYWwuaAppbmRleCBhMzYyNjg4ZmRlLi4xYTc1Njg2
Yjc5IDEwMDY0NAotLS0gYS9zcmMvaW5jbHVkZS9yZXBsaWNhdGlvbi93b3JrZXJfaW50ZXJuYWwu
aAorKysgYi9zcmMvaW5jbHVkZS9yZXBsaWNhdGlvbi93b3JrZXJfaW50ZXJuYWwuaApAQCAtNTgs
MTAgKzU4LDEyIEBAIHR5cGVkZWYgc3RydWN0IExvZ2ljYWxSZXBXb3JrZXIKIAogCS8qCiAJICog
VXNlZCB0byBjcmVhdGUgdGhlIGNoYW5nZXMgYW5kIHN1YnhhY3QgZmlsZXMgZm9yIHRoZSBzdHJl
YW1pbmcKLQkgKiB0cmFuc2FjdGlvbnMuICBVcG9uIHRoZSBhcnJpdmFsIG9mIHRoZSBmaXJzdCBz
dHJlYW1pbmcgdHJhbnNhY3Rpb24sIHRoZQotCSAqIGZpbGVzZXQgd2lsbCBiZSBpbml0aWFsaXpl
ZCwgYW5kIGl0IHdpbGwgYmUgZGVsZXRlZCB3aGVuIHRoZSB3b3JrZXIKLQkgKiBleGl0cy4gIFVu
ZGVyIHRoaXMsIHNlcGFyYXRlIGJ1ZmZpbGVzIHdvdWxkIGJlIGNyZWF0ZWQgZm9yIGVhY2gKLQkg
KiB0cmFuc2FjdGlvbiB3aGljaCB3aWxsIGJlIGRlbGV0ZWQgYWZ0ZXIgdGhlIHRyYW5zYWN0aW9u
IGlzIGZpbmlzaGVkLgorCSAqIHRyYW5zYWN0aW9ucy4gIFVwb24gdGhlIGFycml2YWwgb2YgdGhl
IGZpcnN0IHN0cmVhbWluZyB0cmFuc2FjdGlvbiBvcgorCSAqIHdoZW4gdGhlIGZpcnN0LXRpbWUg
bGVhZGVyIGFwcGx5IHdvcmtlciB0aW1lcyBvdXQgd2hpbGUgc2VuZGluZyBjaGFuZ2VzCisJICog
dG8gdGhlIHBhcmFsbGVsIGFwcGx5IHdvcmtlciwgdGhlIGZpbGVzZXQgd2lsbCBiZSBpbml0aWFs
aXplZCwgYW5kIGl0CisJICogd2lsbCBiZSBkZWxldGVkIHdoZW4gdGhlIHdvcmtlciBleGl0cy4g
IFVuZGVyIHRoaXMsIHNlcGFyYXRlIGJ1ZmZpbGVzCisJICogd291bGQgYmUgY3JlYXRlZCBmb3Ig
ZWFjaCB0cmFuc2FjdGlvbiB3aGljaCB3aWxsIGJlIGRlbGV0ZWQgYWZ0ZXIgdGhlCisJICogdHJh
bnNhY3Rpb24gaXMgZmluaXNoZWQuCiAJICovCiAJRmlsZVNldCAgICAqc3RyZWFtX2ZpbGVzZXQ7
CiAKQEAgLTk2LDEyICs5OCwyMCBAQCB0eXBlZGVmIGVudW0gUGFyYWxsZWxUcmFuc1N0YXRlCiB9
IFBhcmFsbGVsVHJhbnNTdGF0ZTsKIAogLyoKLSAqIFN0YXRlIG9mIGZpbGVzZXQgaW4gbGVhZGVy
IGFwcGx5IHdvcmtlci4KKyAqIFN0YXRlIG9mIGZpbGVzZXQgdXNlZCB0byBjb21tdW5pY2F0ZSBj
aGFuZ2VzIGZyb20gbGVhZGVyIHRvIHBhcmFsbGVsCisgKiBhcHBseSB3b3JrZXIuCiAgKgotICog
RlNfU0VSSUFMSVpFX0lOX1BST0dSRVNTIG1lYW5zIHRoYXQgdGhlIGxlYWRlciBpcyBzZXJpYWxp
emluZyBjaGFuZ2VzIHRvIHRoZQotICogZmlsZS4gRlNfU0VSSUFMSVpFX0RPTkUgbWVhbnMgdGhh
dCB0aGUgbGVhZGVyIGhhcyBzZXJpYWxpemVkIGFsbCBjaGFuZ2VzIHRvCi0gKiB0aGUgZmlsZS4g
RlNfUkVBRFkgbWVhbnMgdGhhdCBpdCBpcyBub3cgb2sgZm9yIGEgcGFyYWxsZWwgYXBwbHkgd29y
a2VyIHJlYWQKKyAqIEZTX0VNUFRZIGluZGljYXRlcyBhbiBpbml0aWFsIHN0YXRlIHdoZXJlIHRo
ZSBsZWFkZXIgZG9lc24ndCBuZWVkIHRvIHVzZQorICogdGhlIGZpbGUgdG8gY29tbXVuaWNhdGUg
d2l0aCB0aGUgcGFyYWxsZWwgYXBwbHkgd29ya2VyLgorICoKKyAqIEZTX1NFUklBTElaRV9JTl9Q
Uk9HUkVTUyBpbmRpY2F0ZXMgdGhhdCB0aGUgbGVhZGVyIGlzIHNlcmlhbGl6aW5nIGNoYW5nZXMK
KyAqIHRvIHRoZSBmaWxlLgorICoKKyAqIEZTX1NFUklBTElaRV9ET05FIGluZGljYXRlcyB0aGF0
IHRoZSBsZWFkZXIgaGFzIHNlcmlhbGl6ZWQgYWxsIGNoYW5nZXMgdG8KICAqIHRoZSBmaWxlLgor
ICoKKyAqIEZTX1JFQURZIGluZGljYXRlcyB0aGF0IGl0IGlzIG5vdyBvayBmb3IgYSBwYXJhbGxl
bCBhcHBseSB3b3JrZXIgdG8KKyAqIHJlYWQgdGhlIGZpbGUuCiAgKi8KIHR5cGVkZWYgZW51bSBQ
YXJ0aWFsRmlsZVNldFN0YXRlCiB7Cg==
--000000000000504f4505f03ed477--