MIME-Version: 1.0
References: 
 <CAJpy0uB19aKEgVgh8gwzj87NUyDgOf01boa-6xJZK+nhb=3W4g@mail.gmail.com>
 <CAA4eK1+h4mOvRqRaGfUtSgZuBhzWWmrBcY3jQ4DDV=cEJ4dwnQ@mail.gmail.com>
 <TY7PR01MB145543A74547443E49E4993E7F58EA@TY7PR01MB14554.jpnprd01.prod.outlook.com>
 <CAJpy0uD6D294d=Hq4oROmtKAew5DfKERNxs=DsAwUFBFF2kERg@mail.gmail.com>
 <TY7PR01MB14554FB7D02601425DE3752DEF58FA@TY7PR01MB14554.jpnprd01.prod.outlook.com>
 <CAA4eK1JvYROk5usAX0Uy=00VACB=w1rvUcyoKvRuke5EMfmi3Q@mail.gmail.com>
 <e0508305-bc6a-417c-b969-36564d632f9e@iki.fi>
 <CAJpy0uD5T692uyaRr0GKqd1eLHW55A0=MH-V8tRPicTxDqMu=g@mail.gmail.com>
 <CAA4eK1LN+T1pLfGBxDW-gps5h-YX6FAjRwkKaV2wwQDDVdi6fw@mail.gmail.com>
 <CAJpy0uBm7m5AFgg6xgWB6msGrivusoDe7PKg9XKHYm_JYQnegg@mail.gmail.com>
In-Reply-To: 
 <CAJpy0uBm7m5AFgg6xgWB6msGrivusoDe7PKg9XKHYm_JYQnegg@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Wed, 25 Mar 2026 13:51:14 +0530
Message-ID: 
 <CAA4eK1JWM_GxnDn8T0+B3+dEqzACkUj7rvfy_B_ukq5myvqxGg@mail.gmail.com>
Subject: Re: [Patch] add new parameter to pg_replication_origin_session_setup
To: shveta malik <shveta.malik@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>,
 "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
	"Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>,
 Doruk Yilmaz <doruk@mixrank.com>
Content-Type: multipart/mixed; boundary="0000000000003b0da4064dd4f483"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA4eK1JWM_GxnDn8T0%2BB3%2BdEqzACkUj7rvfy_B_ukq5myvqxGg%40mail.gmail.com>
Precedence: bulk

--0000000000003b0da4064dd4f483
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 11, 2026 at 5:09=E2=80=AFPM shveta malik <shveta.malik@gmail.co=
m> wrote:
>
> On Wed, Feb 11, 2026 at 3:41=E2=80=AFPM Amit Kapila <amit.kapila16@gmail.=
com> wrote:
> >
> >
> > I see your point but one advantage with the proposed code change is
> > that it started to appear that we can extend this part of code easily
> > in the future as it separates most of the handling related to when a
> > user has given acquired_by parameter's value as zero and non-zero.
>
> Okay, yes. So I am okay with it. The slight change I suggested (if to
> else-if) and a comment will make it more clean.
>

I have tried to address both your suggestions in the attached. See, if
this looks okay to you now?

--=20
With Regards,
Amit Kapila.

--0000000000003b0da4064dd4f483
Content-Type: application/octet-stream;
	name="v2-0001-Simplify-replorigin_session_setup.patch"
Content-Disposition: attachment;
	filename="v2-0001-Simplify-replorigin_session_setup.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mn5rswr10>
X-Attachment-Id: f_mn5rswr10

RnJvbSA0OTRiMzFlNzlkY2UyYTA4ZmI1NmNlZTJiNmFmNTIxMjQyYmUwNDNmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbWl0IEthcGlsYSA8YWthcGlsYUBwb3N0Z3Jlc3FsLm9yZz4K
RGF0ZTogV2VkLCAyNSBNYXIgMjAyNiAxMzo0Mjo1MiArMDUzMApTdWJqZWN0OiBbUEFUQ0ggdjNd
IFNpbXBsaWZ5IHJlcGxvcmlnaW5fc2Vzc2lvbl9zZXR1cCgpCgotLS0KIHNyYy9iYWNrZW5kL3Jl
cGxpY2F0aW9uL2xvZ2ljYWwvb3JpZ2luLmMgfCA3OCArKysrKysrKysrKysrKy0tLS0tLS0tLS0K
IDEgZmlsZSBjaGFuZ2VkLCA0NiBpbnNlcnRpb25zKCspLCAzMiBkZWxldGlvbnMoLSkKCmRpZmYg
LS1naXQgYS9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi9sb2dpY2FsL29yaWdpbi5jIGIvc3JjL2Jh
Y2tlbmQvcmVwbGljYXRpb24vbG9naWNhbC9vcmlnaW4uYwppbmRleCAyNmFmZDhmMGFmOS4uMjZj
MzcyNWFhNjggMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL2xvZ2ljYWwvb3Jp
Z2luLmMKKysrIGIvc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vbG9naWNhbC9vcmlnaW4uYwpAQCAt
MTE4Niw1NSArMTE4Niw2OSBAQCByZXBsb3JpZ2luX3Nlc3Npb25fc2V0dXAoUmVwbE9yaWdpbklk
IG5vZGUsIGludCBhY3F1aXJlZF9ieSkKIAkJaWYgKGN1cnN0YXRlLT5yb2lkZW50ICE9IG5vZGUp
CiAJCQljb250aW51ZTsKIAotCQllbHNlIGlmIChjdXJzdGF0ZS0+YWNxdWlyZWRfYnkgIT0gMCAm
JiBhY3F1aXJlZF9ieSA9PSAwKQorCQlpZiAoYWNxdWlyZWRfYnkgPT0gMCkKIAkJewotCQkJZXJl
cG9ydChFUlJPUiwKLQkJCQkJKGVycmNvZGUoRVJSQ09ERV9PQkpFQ1RfSU5fVVNFKSwKLQkJCQkJ
IGVycm1zZygicmVwbGljYXRpb24gb3JpZ2luIHdpdGggSUQgJWQgaXMgYWxyZWFkeSBhY3RpdmUg
Zm9yIFBJRCAlZCIsCi0JCQkJCQkJY3Vyc3RhdGUtPnJvaWRlbnQsIGN1cnN0YXRlLT5hY3F1aXJl
ZF9ieSkpKTsKKwkJCS8qIFdpdGggYWNxdWlyZWRfYnkgPT0gMCwgd2UgbmVlZCB0aGUgb3JpZ2lu
IHRvIGJlIGZyZWUgKi8KKwkJCWlmIChjdXJzdGF0ZS0+YWNxdWlyZWRfYnkgIT0gMCkKKwkJCXsK
KwkJCQllcmVwb3J0KEVSUk9SLAorCQkJCQkJKGVycmNvZGUoRVJSQ09ERV9PQkpFQ1RfSU5fVVNF
KSwKKwkJCQkJCSBlcnJtc2coInJlcGxpY2F0aW9uIG9yaWdpbiB3aXRoIElEICVkIGlzIGFscmVh
ZHkgYWN0aXZlIGZvciBQSUQgJWQiLAorCQkJCQkJCQljdXJzdGF0ZS0+cm9pZGVudCwgY3Vyc3Rh
dGUtPmFjcXVpcmVkX2J5KSkpOworCQkJfQorCQkJZWxzZSBpZiAoY3Vyc3RhdGUtPnJlZmNvdW50
ID4gMCkKKwkJCXsKKwkJCQkvKgorCQkJCSAqIFRoZSBvcmlnaW4gaXMgaW4gdXNlLCBidXQgUElE
IGlzIG5vdCByZWNvcmRlZC4gVGhpcyBjYW4KKwkJCQkgKiBoYXBwZW4gaWYgdGhlIHByb2Nlc3Mg
dGhhdCBvcmlnaW5hbGx5IGFjcXVpcmVkIHRoZSBvcmlnaW4KKwkJCQkgKiBleGl0ZWQgd2l0aG91
dCByZWxlYXNpbmcgaXQuIFRvIGVuc3VyZSBjb3JyZWN0bmVzcywgb3RoZXIKKwkJCQkgKiBwcm9j
ZXNzZXMgY2Fubm90IGFjcXVpcmUgdGhlIG9yaWdpbiB1bnRpbCBhbGwgcHJvY2Vzc2VzCisJCQkJ
ICogY3VycmVudGx5IHVzaW5nIGl0IGhhdmUgcmVsZWFzZWQgaXQuCisJCQkJICovCisJCQkJZXJl
cG9ydChFUlJPUiwKKwkJCQkJCShlcnJjb2RlKEVSUkNPREVfT0JKRUNUX0lOX1VTRSksCisJCQkJ
CQkgZXJybXNnKCJyZXBsaWNhdGlvbiBvcmlnaW4gd2l0aCBJRCAlZCBpcyBhbHJlYWR5IGFjdGl2
ZSBpbiBhbm90aGVyIHByb2Nlc3MiLAorCQkJCQkJCQljdXJzdGF0ZS0+cm9pZGVudCkpKTsKKwkJ
CX0KIAkJfQotCi0JCWVsc2UgaWYgKGN1cnN0YXRlLT5hY3F1aXJlZF9ieSAhPSBhY3F1aXJlZF9i
eSkKKwkJZWxzZQogCQl7Ci0JCQllcmVwb3J0KEVSUk9SLAotCQkJCQkoZXJyY29kZShFUlJDT0RF
X09CSkVDVF9JTl9VU0UpLAotCQkJCQkgZXJybXNnKCJjb3VsZCBub3QgZmluZCByZXBsaWNhdGlv
biBzdGF0ZSBzbG90IGZvciByZXBsaWNhdGlvbiBvcmlnaW4gd2l0aCBPSUQgJXUgd2hpY2ggd2Fz
IGFjcXVpcmVkIGJ5ICVkIiwKLQkJCQkJCQlub2RlLCBhY3F1aXJlZF9ieSkpKTsKKwkJCS8qCisJ
CQkgKiBXaXRoIGFjcXVpcmVkX2J5ICE9IDAsIHdlIG5lZWQgdGhlIG9yaWdpbiB0byBiZSBhY3Rp
dmUgYnkgdGhlCisJCQkgKiBnaXZlbiBQSUQKKwkJCSAqLworCQkJaWYgKGN1cnN0YXRlLT5hY3F1
aXJlZF9ieSAhPSBhY3F1aXJlZF9ieSkKKwkJCQllcmVwb3J0KEVSUk9SLAorCQkJCQkJKGVycmNv
ZGUoRVJSQ09ERV9PQkpFQ1RfSU5fVVNFKSwKKwkJCQkJCSBlcnJtc2coInJlcGxpY2F0aW9uIG9y
aWdpbiB3aXRoIElEICVkIGlzIG5vdCBhY3RpdmUgZm9yIFBJRCAlZCIsCisJCQkJCQkJCWN1cnN0
YXRlLT5yb2lkZW50LCBhY3F1aXJlZF9ieSkpKTsKKwkJCS8qCisJCQkgKiBIZXJlLCBpdCBpcyBv
a2F5IHRvIGhhdmUgcmVmY291bnQgPiAwIGFzIG1vcmUgdGhhbiBvbmUgcHJvY2VzcworCQkJICog
Y2FuIHNhZmVseSByZS11c2UgdGhlIG9yaWdpbi4KKwkJCSAqLwogCQl9CiAKLQkJLyoKLQkJICog
VGhlIG9yaWdpbiBpcyBpbiB1c2UsIGJ1dCBQSUQgaXMgbm90IHJlY29yZGVkLiBUaGlzIGNhbiBo
YXBwZW4gaWYKLQkJICogdGhlIHByb2Nlc3MgdGhhdCBvcmlnaW5hbGx5IGFjcXVpcmVkIHRoZSBv
cmlnaW4gZXhpdGVkIHdpdGhvdXQKLQkJICogcmVsZWFzaW5nIGl0LiBUbyBlbnN1cmUgY29ycmVj
dG5lc3MsIG90aGVyIHByb2Nlc3NlcyBjYW5ub3QgYWNxdWlyZQotCQkgKiB0aGUgb3JpZ2luIHVu
dGlsIGFsbCBwcm9jZXNzZXMgY3VycmVudGx5IHVzaW5nIGl0IGhhdmUgcmVsZWFzZWQgaXQuCi0J
CSAqLwotCQllbHNlIGlmIChjdXJzdGF0ZS0+YWNxdWlyZWRfYnkgPT0gMCAmJiBjdXJzdGF0ZS0+
cmVmY291bnQgPiAwKQotCQkJZXJlcG9ydChFUlJPUiwKLQkJCQkJKGVycmNvZGUoRVJSQ09ERV9P
QkpFQ1RfSU5fVVNFKSwKLQkJCQkJIGVycm1zZygicmVwbGljYXRpb24gb3JpZ2luIHdpdGggSUQg
JWQgaXMgYWxyZWFkeSBhY3RpdmUgaW4gYW5vdGhlciBwcm9jZXNzIiwKLQkJCQkJCQljdXJzdGF0
ZS0+cm9pZGVudCkpKTsKLQogCQkvKiBvaywgZm91bmQgc2xvdCAqLwogCQlzZXNzaW9uX3JlcGxp
Y2F0aW9uX3N0YXRlID0gY3Vyc3RhdGU7CiAJCWJyZWFrOwogCX0KIAotCi0JaWYgKHNlc3Npb25f
cmVwbGljYXRpb25fc3RhdGUgPT0gTlVMTCAmJiBmcmVlX3Nsb3QgPT0gLTEpCi0JCWVyZXBvcnQo
RVJST1IsCi0JCQkJKGVycmNvZGUoRVJSQ09ERV9DT05GSUdVUkFUSU9OX0xJTUlUX0VYQ0VFREVE
KSwKLQkJCQkgZXJybXNnKCJjb3VsZCBub3QgZmluZCBmcmVlIHJlcGxpY2F0aW9uIHN0YXRlIHNs
b3QgZm9yIHJlcGxpY2F0aW9uIG9yaWdpbiB3aXRoIElEICVkIiwKLQkJCQkJCW5vZGUpLAotCQkJ
CSBlcnJoaW50KCJJbmNyZWFzZSBcIm1heF9hY3RpdmVfcmVwbGljYXRpb25fb3JpZ2luc1wiIGFu
ZCB0cnkgYWdhaW4uIikpKTsKLQllbHNlIGlmIChzZXNzaW9uX3JlcGxpY2F0aW9uX3N0YXRlID09
IE5VTEwpCisJaWYgKHNlc3Npb25fcmVwbGljYXRpb25fc3RhdGUgPT0gTlVMTCkKIAl7Ci0JCWlm
IChhY3F1aXJlZF9ieSkKKwkJaWYgKGFjcXVpcmVkX2J5ICE9IDApCiAJCQllcmVwb3J0KEVSUk9S
LAogCQkJCQkoZXJyY29kZShFUlJDT0RFX09CSkVDVF9OT1RfSU5fUFJFUkVRVUlTSVRFX1NUQVRF
KSwKIAkJCQkJIGVycm1zZygiY2Fubm90IHVzZSBQSUQgJWQgZm9yIGluYWN0aXZlIHJlcGxpY2F0
aW9uIG9yaWdpbiB3aXRoIElEICVkIiwKIAkJCQkJCQlhY3F1aXJlZF9ieSwgbm9kZSkpKTsKIAog
CQkvKiBpbml0aWFsaXplIG5ldyBzbG90ICovCisJCWlmIChmcmVlX3Nsb3QgPT0gLTEpCisJCQll
cmVwb3J0KEVSUk9SLAorCQkJCQkoZXJyY29kZShFUlJDT0RFX0NPTkZJR1VSQVRJT05fTElNSVRf
RVhDRUVERUQpLAorCQkJCQkgZXJybXNnKCJjb3VsZCBub3QgZmluZCBmcmVlIHJlcGxpY2F0aW9u
IHN0YXRlIHNsb3QgZm9yIHJlcGxpY2F0aW9uIG9yaWdpbiB3aXRoIElEICVkIiwKKwkJCQkJCQlu
b2RlKSwKKwkJCQkJIGVycmhpbnQoIkluY3JlYXNlIFwibWF4X2FjdGl2ZV9yZXBsaWNhdGlvbl9v
cmlnaW5zXCIgYW5kIHRyeSBhZ2Fpbi4iKSkpOworCiAJCXNlc3Npb25fcmVwbGljYXRpb25fc3Rh
dGUgPSAmcmVwbGljYXRpb25fc3RhdGVzW2ZyZWVfc2xvdF07CiAJCUFzc2VydCghWExvZ1JlY1B0
cklzVmFsaWQoc2Vzc2lvbl9yZXBsaWNhdGlvbl9zdGF0ZS0+cmVtb3RlX2xzbikpOwogCQlBc3Nl
cnQoIVhMb2dSZWNQdHJJc1ZhbGlkKHNlc3Npb25fcmVwbGljYXRpb25fc3RhdGUtPmxvY2FsX2xz
bikpOwotLSAKMi41Mi4wLndpbmRvd3MuMQoK
--0000000000003b0da4064dd4f483--