MIME-Version: 1.0
References: <TY3PR01MB118912125614599641CA881B782522@TY3PR01MB11891.jpnprd01.prod.outlook.com>
 <CABwTF4WczBfnRcqPpF+bfGbBXnv69TtauScokDSRYUvEHSSKDw@mail.gmail.com>
 <CA+Tgmoa_kC1T5PR0C7K0cGo1OEPx2c4zQ13ziwqm=pz7K_367g@mail.gmail.com>
 <CA+OCxoywke+6M7yO7-eUD4RwJiuGk-ydCJqh3bkbG3PjoLAhWg@mail.gmail.com>
 <TY3PR01MB118914759E215A415D418B42B82532@TY3PR01MB11891.jpnprd01.prod.outlook.com>
 <c03e069d-7220-453d-9c5d-9fcc74518be0@eisentraut.org> <CA+OCxoygUCBN833mWDVubLieW0f0U_3q8yRfd1b91Bd78YGdWg@mail.gmail.com>
In-Reply-To: <CA+OCxoygUCBN833mWDVubLieW0f0U_3q8yRfd1b91Bd78YGdWg@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Mon, 11 Nov 2024 16:41:51 +0530
Message-ID: <CAA4eK1JcN8ea6mL76+mOsMJa2UPbVfLF+f3BpP=+FQVDbpk1OQ@mail.gmail.com>
Subject: Re: doc: pgevent.dll location
To: Dave Page <dpage@pgadmin.org>
Cc: Peter Eisentraut <peter@eisentraut.org>, 
	"Ryohei Takahashi (Fujitsu)" <r.takahashi_2@fujitsu.com>, Robert Haas <robertmhaas@gmail.com>, 
	Gurjeet Singh <gurjeet@singh.im>, 
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAA4eK1JcN8ea6mL76%2BmOsMJa2UPbVfLF%2Bf3BpP%3D%2BFQVDbpk1OQ%40mail.gmail.com>
Precedence: bulk

On Thu, Nov 7, 2024 at 1:46=E2=80=AFPM Dave Page <dpage@pgadmin.org> wrote:
>
> Hi
>
> On Wed, 6 Nov 2024 at 16:11, Peter Eisentraut <peter@eisentraut.org> wrot=
e:
>>
>> On 06.11.24 13:57, Ryohei Takahashi (Fujitsu) wrote:
>> > The dll install paths are changed as follows on Windows.
>> >
>> > (1) pgevent.dll
>> > PG16: lib/
>> > PG17: bin/
>> >
>> > (2) dll for user (like libpq.dll, libecpg.dll)
>> > PG16: Both in lib/ and bin/
>> > PG17: bin/
>> >
>> > (3) contrib dll (like amcheck.dll)
>> > PG16: lib/
>> > PG17: lib/
>> >
>> >
>> > I understand that Dave says (1) and (2) should exist on bin/ directory
>> > and the paths in PG17 are correct.
>> >
>> > So, I think it is correct to update documentation.
>>
>> I don't have Windows handy to test it out, but looking at the respective
>> build system source files, in master, pgevent is built and installed
>> like a normal shared library in both meson.build and Makefile, so it
>> should end up somewhere in lib.
>>
>> In src/tools/msvc in REL_16_STABLE, I see some code that appears to
>> suggest that it installs in bin.
>>
>> Again, this is just reading the code, but it seems to be backwards from
>> what is claimed earlier.
>
>
> I downloaded the builds of v16 and v17 from
> https://github.com/dpage/winpgbuild/actions/runs/11639786998, a project w=
orked on by Andres, Dave Cramer, and myself.
>
> I've just double-checked I didn't get mixed up, and can confirm that in v=
17, pgevent.dll is installed into bin/ and in v16.4, it's in lib/
>

I can re-confirm that on my Windows setup, pgevent.dll is present in
bin/ for PG17 and HEAD and in lib/ for PG16.

--=20
With Regards,
Amit Kapila.