MIME-Version: 1.0
References: <CAFiTN-vTaWUh0Eq8UpETMk=ZGFEMkD-1gXtosODZeCiCfi92kQ@mail.gmail.com>
 <CAA4eK1KLR2BP1GULkA9FMj3aKFbOcQLvu6b5fAht+YjCVRkc1w@mail.gmail.com>
 <CAFiTN-skn=ffyC8PMzg7gfpyNLfx7v9roae-+W8HYbpzoO0mkg@mail.gmail.com>
 <OS0PR01MB57169DD55EC8D9D1EDB7A0C2946A2@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAA4eK1L74EUU7+Dr11joY+Xact_MsjZu9G12sX+vRUWJsptP8Q@mail.gmail.com>
 <CAA4eK1+ORhnb2zUUpO_FcgWUUbwvQX5+=tdCehx7x2nB2x8VMg@mail.gmail.com>
 <ZaAMOwuYPc+Aaf/I@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAA4eK1LDzUJDt3eeuGLh78fEvN8aJ_c86KW8c+hncPdt9_7xxw@mail.gmail.com>
 <ZaDeJ65cAOkuxQsC@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAA4eK1KQuUjbBamUuryM-EsM4aHzap+gR-E-fzwgWzSPT7qsJg@mail.gmail.com> <ZaT50TDdxI7OYXUS@ip-10-97-1-34.eu-west-3.compute.internal>
In-Reply-To: <ZaT50TDdxI7OYXUS@ip-10-97-1-34.eu-west-3.compute.internal>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Mon, 15 Jan 2024 16:09:26 +0530
Message-ID: <CAA4eK1Jdt2KMOAaVmLf_k5imWDOWCXNS8R82DqGU5c5OX6vGSg@mail.gmail.com>
Subject: Re: Synchronizing slots from primary to standby
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, Masahiko Sawada <sawada.mshk@gmail.com>, 
	Dilip Kumar <dilipbalaut@gmail.com>, shveta malik <shveta.malik@gmail.com>, 
	Peter Smith <smithpb2250@gmail.com>, Nisha Moond <nisha.moond412@gmail.com>, 
	"Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, 
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, 
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Bruce Momjian <bruce@momjian.us>, 
	Ashutosh Sharma <ashu.coek88@gmail.com>, Andres Freund <andres@anarazel.de>, 
	pgsql-hackers <pgsql-hackers@postgresql.org>, Ajin Cherian <itsajin@gmail.com>, 
	Alvaro Herrera <alvherre@alvh.no-ip.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAA4eK1Jdt2KMOAaVmLf_k5imWDOWCXNS8R82DqGU5c5OX6vGSg%40mail.gmail.com>
Precedence: bulk

On Mon, Jan 15, 2024 at 2:54=E2=80=AFPM Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
>
> On Sat, Jan 13, 2024 at 10:05:52AM +0530, Amit Kapila wrote:
> > On Fri, Jan 12, 2024 at 12:07=E2=80=AFPM Bertrand Drouvot
> > <bertranddrouvot.pg@gmail.com> wrote:
> > > Maybe the "best" approach would be to have a way to detect that a slo=
t has been
> > > re-created on the primary (but that would mean rely on more than the =
slot name
> > > to "identify" a slot and probably add a new member to the struct to d=
o so).
> > >
> >
> > Right, I also thought so but not sure further complicating the slot
> > machinery is worth detecting this case explicitly. If we see any
> > problem with the idea discussed then we may need to think something
> > along those lines.
>
> Yeah, let's see. On one side that would require extra work but on the oth=
er side
> that would also probably simplify (and less bug prone in the mid-long ter=
m?)
> other parts of the code.
>

After following Sawada-San's suggestion to not copy the 'failover'
option there doesn't seem to be much special handling, so there is
probably less to simplify.

--=20
With Regards,
Amit Kapila.