MIME-Version: 1.0
References: <CAJpy0uB19aKEgVgh8gwzj87NUyDgOf01boa-6xJZK+nhb=3W4g@mail.gmail.com>
 <CAA4eK1+h4mOvRqRaGfUtSgZuBhzWWmrBcY3jQ4DDV=cEJ4dwnQ@mail.gmail.com>
 <TY7PR01MB145543A74547443E49E4993E7F58EA@TY7PR01MB14554.jpnprd01.prod.outlook.com>
 <CAJpy0uD6D294d=Hq4oROmtKAew5DfKERNxs=DsAwUFBFF2kERg@mail.gmail.com>
 <TY7PR01MB14554FB7D02601425DE3752DEF58FA@TY7PR01MB14554.jpnprd01.prod.outlook.com>
 <CAA4eK1JvYROk5usAX0Uy=00VACB=w1rvUcyoKvRuke5EMfmi3Q@mail.gmail.com>
 <e0508305-bc6a-417c-b969-36564d632f9e@iki.fi> <CAA4eK1KV2orcjQmdNmBO4EQQ7GXxEJ2kRy_d+1mOH-CEqtTYbg@mail.gmail.com>
In-Reply-To: <CAA4eK1KV2orcjQmdNmBO4EQQ7GXxEJ2kRy_d+1mOH-CEqtTYbg@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Mon, 16 Feb 2026 14:22:57 +0530
Message-ID: <CAA4eK1JgkWgg3hfxSPsOgtamh4sgWLFQqYFL_oEhqHgtHhJriA@mail.gmail.com>
Subject: Re: [Patch] add new parameter to pg_replication_origin_session_setup
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, shveta malik <shveta.malik@gmail.com>, 
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, 
	"Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, Doruk Yilmaz <doruk@mixrank.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAA4eK1JgkWgg3hfxSPsOgtamh4sgWLFQqYFL_oEhqHgtHhJriA%40mail.gmail.com>
Precedence: bulk

On Wed, Feb 11, 2026 at 10:53=E2=80=AFAM Amit Kapila <amit.kapila16@gmail.c=
om> wrote:
>
> On Wed, Feb 4, 2026 at 12:38=E2=80=AFAM Heikki Linnakangas <hlinnaka@iki.=
fi> wrote:
> >
> > The new error message is not great:
> >
> > postgres=3D# select pg_replication_origin_session_setup('myorigin', 123=
45678);
> > ERROR:  could not find replication state slot for replication origin
> > with OID 1 which was acquired by 12345678
> >
> > Firstly, replication origin is not an OID. Secondly, it's a little
> > confusing because the "replication state slot" is in fact present.
> > However, it's currently inactive, i.e. not "acquired" by the given PID.
> >
> > I propose to change that to:
> >
> > postgres=3D# select pg_replication_origin_session_setup('myorigin', 123=
45678);
> > ERROR:  replication origin with ID 1 is not active for PID 12345678
> >
> > That's more in line with this neighboring message:
> >
> > ERROR:  replication origin with ID 1 is already active for PID 701228
> >
>
> +1 for the new message.
>

Heikki, would you like to take care of improvements proposed by you?
Otherwise, I am happy to take care of them.

--=20
With Regards,
Amit Kapila.