MIME-Version: 1.0
References: 
 <OSOPR01MB1215385EAC6A76650444E40B0F54FA@OSOPR01MB12153.jpnprd01.prod.outlook.com>
 <CAEqnbaU=EgqhxEx0ig4TdY8pdt0Vn+vmCJBuoORRHOzovW9dWA@mail.gmail.com>
 <TYRPR01MB12156F431E4B83ECFF14034BDF54CA@TYRPR01MB12156.jpnprd01.prod.outlook.com>
 <CAEqnbaXb-TKUm7P-=_zrgQ=shRXkkZscPOHEL9OS6Cb2V8YT8Q@mail.gmail.com>
In-Reply-To: 
 <CAEqnbaXb-TKUm7P-=_zrgQ=shRXkkZscPOHEL9OS6Cb2V8YT8Q@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Sat, 21 Mar 2026 15:27:40 +0530
Message-ID: 
 <CAA4eK1JiAzaY7UYnya7uDhX-kAL1PrsOAxBtys7c35t4q4H3_A@mail.gmail.com>
Subject: Re: [Proposal] Adding Log File Capability to pg_createsubscriber
To: Gyan Sreejith <gyan.sreejith@gmail.com>
Cc: =?UTF-8?B?S3Vyb2RhLCBIYXlhdG8v6buS55SwIOmavOS6ug==?=
 <kuroda.hayato@fujitsu.com>,
	Shlok Kyal <shlok.kyal.oss@gmail.com>, vignesh C <vignesh21@gmail.com>,
	Euler Taveira <euler@eulerto.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
 Peter Smith <smithpb2250@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAA4eK1JiAzaY7UYnya7uDhX-kAL1PrsOAxBtys7c35t4q4H3_A%40mail.gmail.com>
Precedence: bulk

On Fri, Mar 20, 2026 at 10:30=E2=80=AFPM Gyan Sreejith <gyan.sreejith@gmail=
.com> wrote:
>

0001:
=3D=3D=3D=3D=3D
*
+static void pg_createsub_log(enum pg_log_level, enum pg_log_part,
+ const char *pg_restrict fmt,...)
+ pg_attribute_printf(3, 4);
+pg_noreturn static void pg_fatal(const char *pg_restrict fmt,...)
+ pg_attribute_printf(1, 2);

I see similar functions in other modules are named a bit differently.
For example, see report_manifest_error(), report_backup_error(),
report_fatal_error(). Then I see many other error reporting functions
named similarly in code, some examples are: report_invalid_record(),
report_invalid_page(), report_namespace_conflict(), and
report_recovery_conflict().

Based on the above information, can we consider renaming the above
functions to report_createsub_log() and report_createsub_fatal()?

Other than the above point, 0001 LGTM.

--=20
With Regards,
Amit Kapila.