public inbox for [email protected]  

help / color / mirror / Atom feed

From: Amit Kapila <[email protected]>
To: Peter Smith <[email protected]>
Cc: Robert Treat <[email protected]>
Cc: Chao Li <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Add missing period to HINT messages
Date: Mon, 13 Apr 2026 16:58:28 +0530
Message-ID: <CAA4eK1JmqgZQ9HRvF6t7Eie6Z4sDGAEyH5fYbt1F69tvwLFUdQ@mail.gmail.com> (raw)
In-Reply-To: <CAHut+PsdwfnT3yMM8r9y7c5MZU2sv27JJd2riFipdQ8PvXs7Dw@mail.gmail.com>
References: <CAHut+PvikGr4AtoFSs=jq=hmTybVF2NCMEZ57-sjwbGudfuqsQ@mail.gmail.com>
	<[email protected]>
	<CAHut+PsUQfddBnjE9m1x4aoWAgRMEnsVFeg2cZJt9BCC_nbwfg@mail.gmail.com>
	<[email protected]>
	<CAHut+PuxV8wAULnNv+i1_YKyvDrD7jvWne48Yf82e3hRR=+qQw@mail.gmail.com>
	<CABV9wwPNeMM9wrtYtwmG_F6y=-f8hcnPbeVMmgXE4DEaZkFQew@mail.gmail.com>
	<CAHut+PsdwfnT3yMM8r9y7c5MZU2sv27JJd2riFipdQ8PvXs7Dw@mail.gmail.com>

On Mon, Apr 13, 2026 at 6:32 AM Peter Smith <[email protected]> wrote:
>
> On Fri, Apr 10, 2026 at 11:10 PM Robert Treat <[email protected]> wrote:
> >
> > On Thu, Apr 9, 2026 at 9:05 PM Peter Smith <[email protected]> wrote:
> > > On Thu, Apr 9, 2026 at 1:34 PM Chao Li <[email protected]> wrote:
> > > >
> > > ...
> > > >
> > > > I am not sure if your scope includes contrib/, if yes, I am sure you will find some occurrences there.
> > > >
> > >
> > > Updated one more message found in contrib.
> > >
> > > PSA v2.
> > >
> >
> > +1 to the general idea here, although at the risk of looking at
> > patches before the morning coffee has settled in, ISTM you might have
> > missed some entries? And/or this patch isn't against HEAD?  For
> > example, you seem to be catching the line here
> > https://github.com/postgres/postgres/blame/009ea1b08d7b8843435bd0f1137fa3df09aac79f/src/test/regress...,
> > but not the one on line 52, maybe because it looks like a comment (but
> > istm we should clean these all up. no?)
> >
>
> Thanks for your review!
>
> Yes, the patch applies to HEAD. It looks like I was a bit slack in
> updating some test comments. Hopefully, I have found them all now.
>

BTW, I find such a code cleanup exercise can be done even after
feature freeze. If so, shall we do it as a HEAD-only patch or do it in
bank branches as well?

-- 
With Regards,
Amit Kapila.

view thread (15+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Add missing period to HINT messages
  In-Reply-To: <CAA4eK1JmqgZQ9HRvF6t7Eie6Z4sDGAEyH5fYbt1F69tvwLFUdQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox