MIME-Version: 1.0
References: 
 <OSOPR01MB1215385EAC6A76650444E40B0F54FA@OSOPR01MB12153.jpnprd01.prod.outlook.com>
 <CAEqnbaU=EgqhxEx0ig4TdY8pdt0Vn+vmCJBuoORRHOzovW9dWA@mail.gmail.com>
 <TYRPR01MB12156F431E4B83ECFF14034BDF54CA@TYRPR01MB12156.jpnprd01.prod.outlook.com>
 <CAEqnbaXb-TKUm7P-=_zrgQ=shRXkkZscPOHEL9OS6Cb2V8YT8Q@mail.gmail.com>
 <CAA4eK1JiAzaY7UYnya7uDhX-kAL1PrsOAxBtys7c35t4q4H3_A@mail.gmail.com>
 <CAEqnbaVF0yXQk=VVzr-8V23E=iUpUqyah6hxx2fy0ZVJh+CaGA@mail.gmail.com>
 <CAJpy0uAwPNG3GN5+jTajnccLe+F1mW6dZh-9112u3QQQYugA=Q@mail.gmail.com>
In-Reply-To: 
 <CAJpy0uAwPNG3GN5+jTajnccLe+F1mW6dZh-9112u3QQQYugA=Q@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Mon, 23 Mar 2026 12:46:36 +0530
Message-ID: 
 <CAA4eK1JyYHPgaPTow5co8wBh8Ga+fx=vqHLhk2zHeqdOGYN4Vg@mail.gmail.com>
Subject: Re: [Proposal] Adding Log File Capability to pg_createsubscriber
To: shveta malik <shveta.malik@gmail.com>
Cc: Gyan Sreejith <gyan.sreejith@gmail.com>,
	=?UTF-8?B?S3Vyb2RhLCBIYXlhdG8v6buS55SwIOmavOS6ug==?=
 <kuroda.hayato@fujitsu.com>,
	Shlok Kyal <shlok.kyal.oss@gmail.com>, vignesh C <vignesh21@gmail.com>,
	Euler Taveira <euler@eulerto.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
 Peter Smith <smithpb2250@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAA4eK1JyYHPgaPTow5co8wBh8Ga%2Bfx%3DvqHLhk2zHeqdOGYN4Vg%40mail.gmail.com>
Precedence: bulk

On Mon, Mar 23, 2026 at 8:46=E2=80=AFAM shveta malik <shveta.malik@gmail.co=
m> wrote:
>
> On Sun, Mar 22, 2026 at 4:39=E2=80=AFAM Gyan Sreejith <gyan.sreejith@gmai=
l.com> wrote:
> >
> >
> > On Sat, Mar 21, 2026 at 5:57=E2=80=AFAM Amit Kapila <amit.kapila16@gmai=
l.com> wrote:
> >>
> >>
> >> Based on the above information, can we consider renaming the above
> >>
> >> functions to report_createsub_log() and report_createsub_fatal()?
> >>
> >> Other than the above point, 0001 LGTM.
> >
> >
> > I have renamed the functions.
> >
>
> 001 looks good.
>

Pushed 0001.

--=20
With Regards,
Amit Kapila.