Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wSNMU-0038tx-0F for pgsql-hackers@arkaria.postgresql.org; Wed, 27 May 2026 23:08:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wSNMR-009yBQ-2J for pgsql-hackers@arkaria.postgresql.org; Wed, 27 May 2026 23:08:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wSNMR-009yBI-1I for pgsql-hackers@lists.postgresql.org; Wed, 27 May 2026 23:08:28 +0000 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wSNMQ-00000001lWL-0BZz for pgsql-hackers@lists.postgresql.org; Wed, 27 May 2026 23:08:27 +0000 Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-39394e1e8f3so112397011fa.1 for ; Wed, 27 May 2026 16:08:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1779923304; cv=none; d=google.com; s=arc-20240605; b=d+t56hnGogX7aU8lWt697e8fV83CF2Fc54JnBpg0Pec+T+XS1s2TYiviBOWxokbpvl xsFpRs4dqJVA5EZ6TSx22poiNaZT8YdGpsce8vDTJB3o1vdaQgn1ep02v1i3aKg3MPX0 GYiMoeg2n3PO3p61sMx/0H5pph+WfPsedt4UY8VI0iroVgCeTcH1NI0SbNi0H5gh0ro5 aY3NBEJqcuANuIDPwHPSXnSKW+smYoF7mJ3nBJHZvvs9aafcXsZkyBp/ld5YdjPnCITh o8m0O2l3Cp1YFsFJ3z1Tp7QruuayW+i0q4BS62L8Cox45G89D6UsxW71nX/tGIWQqM+U nPnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=zHBiy7iUtqBFzjz6yYmstLiDWUA1zXGBT+WuA2C7moY=; fh=fngLMBSs0EcBjGAAHzjJyQS6SNN2Avyc7czH0xTpeLI=; b=dY1lRClA1htQqVOVQjCxH0HoVyzp0CXN2bS0jRz2CDcj9XwusbIPI7693oiRA8vmww W7wV+6xVtyKEsQqvtb82AB/ihXx80rFNiyZxOdEF55CDyrLrSDycLv8NKTvWUlhmNk0p 9SVPpbRkpf2iOJvnptfS+wAh+MbXS7rSRMcSFBTqATU6pp5dW4iEDv9DBLRlMnqnObAx nSnj6pqSI2X279WvzVa0ktAyHjig/ctGJpN5m52kN+INpG8XxlswAnCPgsRuZFgDEhmr j22fX2DcsALPzecOYmeOJKuzJe3bYL8jOyr9wHQtsi7XpFtJjabW1mygi4IkS7le899X tUDw==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779923304; x=1780528104; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zHBiy7iUtqBFzjz6yYmstLiDWUA1zXGBT+WuA2C7moY=; b=knDHTIAS28rrmmmk/FrQb4TlPvaN/Tfc+WpC59ocA01KZDyaAuLYSixtGFVTFDoZqw 4JU7R2OBFJY3Pl5yzhfJSm5OMTRrFTOaRDZnFswVEbWb2L2CyFLl9G2eNKxtWvMZspiY PhTTsqBLFd/O1MaAybinHBSDbqFjZbyfFpKCRT4MYw8VURIdcQ6MJpd85mTAlpE+zHk0 NqmEoe4ngonLrhq8m9oUsh20XVKeXo1ezEVuce9rSzzfnovfd4ai04CvgQ42rxlGl7DP VgRDUAypZ0mYy+mvtCuQpscpA1VloxuFvqm3G2b+mDN/chOmmm0doqX2B4s0+TGN3oIL E5fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779923304; x=1780528104; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zHBiy7iUtqBFzjz6yYmstLiDWUA1zXGBT+WuA2C7moY=; b=N1QbMTHMnY/E4wnTrpFfTIqsMHE941nivSyg0hV/iwaXlxIJ5Bwuctr17zxibZbV0o zODqOgWm6Zhbaf7zw+mT+OyhrpXadTuhT2QujvLfLCtsxps2q5whBcuATiXNRv9fgPgs XndUcfQlvsx2yfa9OdFtHUxsO6/kfHqqpz32guaNnkW/uVzoaCBBqztTgqhtDaFKbtOL 054S3nwsXwJwTy5NOYkwMpxQQtMdJj2vKs5RoSCXhQON9lO7MTHRP66dnv2pVrYsvpp0 /6m4RzTBgJaJREsKyGjsKqXCkuRg7S8ki4qNwY+eoDdXejpLNANIbKIsVSH3i2/voted ONKg== X-Forwarded-Encrypted: i=1; AFNElJ9fVGSy2GHCVWYcq7siDAWEq/FBbNMQyFiYmi/8WA6Rwr2ozMFfKFvWgyAyxdk0H2W2VBMFYhW6+ggZm7xC@lists.postgresql.org X-Gm-Message-State: AOJu0Yz2lLAYUCiJqntPuIUu89WWXs1eGRmlmSOpBMzgXyjhyN+PnUrM X0jzLhrg37kECZWQuRWnT0+pu0ar/iCN4mHy/ygFHK8EWIM1gLiTPQL6VkbxronmHx9Zz/d1MYm UvQHWWURVh/M8pzy3yH3iuIngfWROu5E= X-Gm-Gg: Acq92OHGmBWPBosXcKlr1XovMLVvR6O2+OTqY4PDIgrMvJTVTEVCapj3drkwsmTykpO VxUHHhC/xpNDtAl5s0djxqZbCfKvzXQ9z/S8rkZyK0DVh8mkghKVqpQyVSUCYoEKEorB5Izb+z3 lQDuJIgIm9nK9TaosRGgngelDMxwT4pjCrqvRLk2kVZ8xZwR1YrUGQmoHKQwH4r9ZRbZXLJCasB Q+VFbqVqDvHn1otpz+dRzgmW1K7aE/Q5Z8VKFidlKf4UnQWJIvg9ef/mnt2vA+7lfnWQ+g8NfpJ gDvLu6gQDfXlFwDwE22+2WyzpQXvl88a8gbBQumjzN2ksrUQjcNGDZ6sBVKOeNYK/OyOlw3IpZe 6hc+mcr/bx1qAmDRiAoWu7Dib1rHF X-Received: by 2002:a2e:b6d3:0:b0:38e:8902:7a7f with SMTP id 38308e7fff4ca-395d8c8b744mr56769311fa.13.1779923304129; Wed, 27 May 2026 16:08:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Amit Kapila Date: Wed, 27 May 2026 16:08:11 -0700 X-Gm-Features: AVHnY4IhwHQUncPnkVKu1U2kz3mH5KtSul4fUW9jBvlmgsqvQvg5lHG019Y5moI Message-ID: Subject: Re: Proposal: Conflict log history table for Logical Replication To: shveta malik Cc: vignesh C , Nisha Moond , Peter Smith , Dilip Kumar , Masahiko Sawada , Bharath Rupireddy , PostgreSQL Hackers , shveta malik Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, May 26, 2026 at 2:38=E2=80=AFAM shveta malik wrote: > > 2) > drop_subscription_dependencies(): > > + conflictrelname =3D get_rel_name(subconflictlogrelid); > > We can actually have a sanity check that we got the CLT using the relid. > Assert(conflictrelname !=3D NULL); > elog will suit this place better as this can't be a direct coding mistake. I see that at other places we used elog. See if (result =3D=3D NULL) elog(ERROR, "cache lookup failed for index %u", indexId); --=20 With Regards, Amit Kapila.