Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wT2Fa-000GtA-1r for pgsql-hackers@arkaria.postgresql.org; Fri, 29 May 2026 18:48:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wT2FZ-0042uD-0f for pgsql-hackers@arkaria.postgresql.org; Fri, 29 May 2026 18:48:05 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wT2FY-0042u5-2a for pgsql-hackers@lists.postgresql.org; Fri, 29 May 2026 18:48:05 +0000 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wT2FW-00000000A4n-39Qz for pgsql-hackers@lists.postgresql.org; Fri, 29 May 2026 18:48:04 +0000 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-5aa2c25c632so9818820e87.1 for ; Fri, 29 May 2026 11:48:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1780080482; cv=none; d=google.com; s=arc-20240605; b=PmbRQyEXS5IhfwwT4cx/1+NMETdSDY7/68fI/r46/OuXY/QYPhDLM3sQZQOTEk/uVW Wd7HKg140uv2MRcFjAYCqUXg5NS2yDSDEiERJq7bz/QTOVxwocPka0R61gtrTugqlgf5 CfuzZfjnKHVcnRJ4REXhtPuHvFWn2FgSPuOqo5y9SqDPtWuR/DtBQygrjFnB3qShiIPZ JP2fMlQG5iAG5E2v9G9WZz47k00MuraIfulYD4o21q3Of3wiTCdcmeHBrzHeYSNMNT9g l/I3hzSu0gRdDX7REREf4gelQ/mIq+cydPgONk4k5iBfxmxY+Tq46Wb0RXREGUrg4P9X dtow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=/oLhTwIxQfqJXvmE6bGcvhEMWst2rej/VzOFjTgYdAU=; fh=Qryr3lsuL5IevUvuDMh1fGRKygD78OrICp+12KapBPw=; b=YysYHwRRFKYriHE6ilUkNTsn9p7KRdAnp5PN3Mu3eXZDnsLgWc6GDt5VbR6Y4zcESA UqbNs8udeIllhmV+h9XHhA9rJLxHHDKDwPkdw1li8avX/7MEvruENmsLQvjYBs44PXaN GTM+6GRkAPZnuVMnfJHuVEo91zOL+LnNQkuqCtv7c4FQcLFh+mRll0sOuBQqHRILYmbY CyBzjyrJdsiiuH4Exo4E1KDegVe4JiE0PxTNp4rSPsuS0v0nyZXWhX8/JXsG9Ld77wlH mlYyUoLJPe9amPJDnNqdr9Q4QUpZvhICtvGNBAXiB3mtd+i70MVNu/+oeD/kO36XYTHE 6mtw==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780080482; x=1780685282; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/oLhTwIxQfqJXvmE6bGcvhEMWst2rej/VzOFjTgYdAU=; b=iI5falWuv4AgHTHxeyu7ByKUmd0L/VBEeEl6UCMh2o9dWV0Fq3aIwcZ94PkT+sCi9A /Uc4ygy66XSIDWqsUVrTbh/aos+Jea+VfXdlZv8300JB208O8HY7p50418LUZK71gfqh rK55v2vxo86GPJMgBWI6oQexw6SratTCNNkEd2IC5OXrya4luaMvTcVpR9J61xMC3HHd 2dEesNuUXbZU/aS+4je1eedQe3NoGkxqGmRUZblNzcjdMORwhAIYGXliCeh5WMS2QVzc KjjozP9biu8uT0LI2HozbZnzwrQC7Ad8Uyo5ZexPIVp5yM0Q0hr5cb/ZxqmRDMf26k19 V2sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780080482; x=1780685282; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/oLhTwIxQfqJXvmE6bGcvhEMWst2rej/VzOFjTgYdAU=; b=YlPgR0szFkSR8ra/VU3kGJMAEYJqpkZ9YcrhuaesPX/x0R8+O75cK+HJdfkUVTj7JK Tbz43S5AdoXE/x6NBuKNBQfu6B4KPZJHdj7oBrg+nXdwF0kv59vrdZGgV5DGGHAX2iGJ bYr6w53zUvAxaW3N6mX6GmcblPGPmXnq9xNnAL3m7DWOIw8dU87xloaC6oq5aT+SHTzr 6V256zVJo69Y1Z068L/XS7V1jS7Dcr9wrALd24SqwBUCbLetYLJoKPgng2KKmBo3e+VG OTbWqJy6dXHoisoS96uK5E9CBEuCxNYYBpRDnUqPg+NwQ6chMjMWq0Mpy7qXrvfBYKVf dhpQ== X-Forwarded-Encrypted: i=1; AFNElJ/PZ10LsOQ9ZiwN97KMlkYUXF/X++2fiJ+waXUkcIIKcxGzL+RAltkTPXl79qQHiU2FzlX7wDYXg1Fgn6Jl@lists.postgresql.org X-Gm-Message-State: AOJu0Yz6BjZVDnSZYQnhsrMLUhEbV30kMCV9of8D2k3ywMzi/f7XLTal QpO4ExE6YiNocRf214Bzsmf3ZolOIiB87Ntpf9j4LBlO3qfgrc6VH9L6V0rLsgYRJN23ng6NkgR g7DPMgnILC9T4mVAQFhgnH7hzI5B+HN0= X-Gm-Gg: Acq92OHmL47HJNJfG4rAw5nbbqBsKLYOel6uwRnSv3V3a3Gn8OdOwWAiq7bGulwllZf 7qmJ3rfjf18phSmBoWmotkepvKYKeUXyjWKktS9I4smu89SKQigYAzxF8aeRUw2wKmmhzlm7hQv I1sOhxg5SG5KeYUNdrvPk9WubRlVvImgtBA2pv82WZACPElqBrduASGT6C7KEDH+krGOW00aBXG bqdDieQ9JPQwpLVP7g4lZMnYK9iLjMdzR4b6p/jFssqnLjy7KcZlP19FSrWVBz8tSvPFpDdP5bq Xjm99HGkaQupFNBCnzREYz+Z9psBsjW7q78OD6wYGibYgAV7VT82X2escxn7t4PgNFYODRjnP/w tJAvCh8A1Au3PPvvvuQ== X-Received: by 2002:a05:6512:3ca4:b0:5a8:9511:b906 with SMTP id 2adb3069b0e04-5aa6092a6c8mr361332e87.33.1780080481251; Fri, 29 May 2026 11:48:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Amit Kapila Date: Fri, 29 May 2026 11:47:49 -0700 X-Gm-Features: AVHnY4I0C8VwrQtlBeDj5olqogXoMSyHjAvfv877AfLzrA4Mlq0StFwMF3jRh9Y Message-ID: Subject: Re: Proposal: Conflict log history table for Logical Replication To: Dilip Kumar Cc: vignesh C , shveta malik , Nisha Moond , Peter Smith , Masahiko Sawada , Bharath Rupireddy , PostgreSQL Hackers , shveta malik Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, May 29, 2026 at 2:23=E2=80=AFAM Dilip Kumar = wrote: > > On Thu, May 28, 2026 at 2:57=E2=80=AFAM Amit Kapila wrote: > > I think I am facing a > > related problem w.r.t newly created subscription. After applying first > > six patches, the create subscription fails as follows: > > postgres=3D# create subscription sub1 connection 'dbname=3Dpostgres' > > publication pub1 with (conflict_log_destination=3D'all'); > > ERROR: dependent subscription was concurrently dropped > > > > I debugged and found that we get the above ERROR when we are trying to > > find the subscription which is not yet created. In this case, it seems > > to be happening because we are using a subscription that is yet not > > created for dependency recording. This raises a question as to why are > > we creating the conflict_log_table before subscription, at least this > > needs some comments. > > This error occurs because in the commit below [1], we disallowed > recording a dependency on an object that does not exist. Therefore, we > now need to record the dependency after the subscription is created. > But don't we normally create dependency immediately after creating the object? Do you see such examples at other places in the code? > And we create CLT before so that we can add the conflict log relid in > pg_subscription without an additional update, > But will this additional update matter to an extent in DDL execution that we don't follow our usual way to record dependency? I feel unless we follow similar coding pattern at other places, it is better to create the CLT after subscription. --=20 With Regards, Amit Kapila.