public inbox for [email protected]  

help / color / mirror / Atom feed

From: Amit Kapila <[email protected]>
To: Alvaro Herrera <[email protected]>
Cc: Zhijie Hou (Fujitsu) <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: subscription/015_stream sometimes breaks
Date: Thu, 24 Aug 2023 09:15:36 +0530
Message-ID: <CAA4eK1KEYtgC3mB683iEq-CQUUSA8=3ZRYB9ZMbWHaU8hey2uA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <OS0PR01MB5716A340DFCA5042CCAA5F7B941CA@OS0PR01MB5716.jpnprd01.prod.outlook.com>
	<[email protected]>

On Wed, Aug 23, 2023 at 1:31 PM Alvaro Herrera <[email protected]> wrote:
>
> On 2023-Aug-23, Zhijie Hou (Fujitsu) wrote:
>
> > [1]--
> >               LWLockAcquire(LogicalRepWorkerLock, LW_SHARED);
> >
> >               workers = logicalrep_workers_find(MyLogicalRepWorker->subid, true);
> >               foreach(lc, workers)
> >               {
> >                       LogicalRepWorker *w = (LogicalRepWorker *) lfirst(lc);
> >
> > **                    if (isParallelApplyWorker(w))
> >                               logicalrep_worker_stop_internal(w, SIGTERM);
> >               }
>
> Hmm, I think if worker->in_use is false, we shouldn't consult the rest
> of the struct at all, so I propose to add the attached 0001 as a minimal
> fix.
>

I think that way we may need to add the check for in_use before
accessing each of the LogicalRepWorker struct fields or form some rule
about which fields (or places) are okay to access without checking
in_use field.

> In fact, I'd go further and propose that if we do take that stance, then
> we don't need clear out the contents of this struct at all, so let's
> not.  That's 0002.
>
> And the reason 0002 does not remove the zeroing of ->proc is that the
> tests gets stuck when I do that, and the reason for that looks to be
> some shoddy coding in WaitForReplicationWorkerAttach, so I propose we
> change that too, as in 0003.
>

Personally, I think we should consider this change (0002 and 0002) separately.

-- 
With Regards,
Amit Kapila.

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: subscription/015_stream sometimes breaks
  In-Reply-To: <CAA4eK1KEYtgC3mB683iEq-CQUUSA8=3ZRYB9ZMbWHaU8hey2uA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox