MIME-Version: 1.0
References: <D908370F-2695-4231-851D-17179A6A6F2A@gmail.com>
 <CAFPTHDZk-eY1K6OGWhLSWJ0C7qncVQvaxUmBL2r69_1CiznfTA@mail.gmail.com>
 <960DD2C4-A22C-463A-90ED-86E0FABD8D20@gmail.com>
 <CAN4CZFMemmQaxs9qT8MW3u_xRXrOa9mtmyup3Nizwb0V_C1axw@mail.gmail.com>
 <8B38AFCA-7FFA-44CF-B9A8-81BDCEAFB224@gmail.com>
 <b03eb0fecb7df88cd3eb2acf48bd1230e28a2923.camel@j-davis.com>
 <705148C3-519C-45E7-9EA8-48D9F3B79B06@gmail.com>
 <f13a8e29410bbbf9999290f2c04513a8884fa51c.camel@j-davis.com>
 <1B3A7FF0-3292-484F-992C-27D172772EB8@gmail.com>
 <65166eb6feb87356f8d60bfe646289ce15a6c729.camel@j-davis.com>
 <24C6472D-DCAB-4F69-AE8A-FFB4AAB3F6F0@gmail.com>
 <CAA4eK1+TQXHR50rtp6eKt1Ejj3ttCKoJj9R+tO_0M+mUi0U66A@mail.gmail.com>
 <5c629d2455946ad2fde3c184f64ea2c323ef2133.camel@j-davis.com>
 <ff36d1ab77de76fb844b7005b8dc6a9e2b43c293.camel@j-davis.com>
 <d87ac2f15c496f78bc6288494d18e39728566c76.camel@j-davis.com>
 <OS9PR01MB12149873B1F63BDBB3E5012CAF5ED2@OS9PR01MB12149.jpnprd01.prod.outlook.com>
In-Reply-To: 
 <OS9PR01MB12149873B1F63BDBB3E5012CAF5ED2@OS9PR01MB12149.jpnprd01.prod.outlook.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Mon, 29 Jun 2026 10:07:00 +0530
Message-ID: 
 <CAA4eK1KW5vVQ29RXYagpUb5K8xP-PCKsOXD2spK4j7byrjed-g@mail.gmail.com>
Subject: Re: Bug in ALTER SUBSCRIPTION ... SERVER / ... CONNECTION with broken
 old server
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: Jeff Davis <pgsql@j-davis.com>, Chao Li <li.evan.chao@gmail.com>,
	Zsolt Parragi <zsolt.parragi@percona.com>, Ajin Cherian <itsajin@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAA4eK1KW5vVQ29RXYagpUb5K8xP-PCKsOXD2spK4j7byrjed-g%40mail.gmail.com>
Precedence: bulk

On Wed, Jun 24, 2026 at 7:48=E2=80=AFAM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
>
> I went through the 0003 patch. Apart from HINT message, I found that erro=
r code
> ERRCODE_CONNECTION_FAILURE is always used. Should we report the original =
errcode
> of the root cause?
>

That could be marginally better but not sure if it is worth the
complexity. I have a few more points regarding 0003:
* Regarding the point: "we can't absorb every kind of error." In the
PG_CATCH, re-throw query-cancel / interrupt-class conditions (if those
are possible) instead of swallowing them, otherwise a SIGINT during
ForeignServerConnectionString() becomes a silent successful DROP (for
slot_name=3DNONE) or a mislabeled connection error.

*
+ if (aclresult !=3D ACLCHECK_OK)
+ ereport(ERROR,
+ errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
+ errmsg("subscription owner \"%s\" does not have permission on
foreign server \"%s\"",
+    GetUserNameFromId(subowner, false),
+    server->servername));

I am not sure if this is a good idea as the outer catch will anyway
silence this.

--=20
With Regards,
Amit Kapila.