public inbox for [email protected]
help / color / mirror / Atom feedFrom: Amit Kapila <[email protected]>
To: Bharath Rupireddy <[email protected]>
Cc: Bertrand Drouvot <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Introduce XID age and inactive timeout based replication slot invalidation
Date: Wed, 20 Mar 2024 08:58:05 +0530
Message-ID: <CAA4eK1KZyjdn7oXS3d7qJU5ag9ss4xSk0Jkjsh5NOrRdkPkV1g@mail.gmail.com> (raw)
In-Reply-To: <CALj2ACXib_+Kuy3_WbTBJkURYGwO7ngS8+HYATReJtXShNCtNw@mail.gmail.com>
References: <CALj2ACWgm++=TkXWo9spm+7ibGxcYL3SsYtT4tbW3=HT1VYs0Q@mail.gmail.com>
<CAA4eK1K28TybqsG9hEP4OaV4OrK__-3E35y5QYW-867p-Ur5gw@mail.gmail.com>
<CALj2ACV+gMb_AWzVCinwyQHi6uyOFMF4x60=B3Y5Zp9uq+H6Gw@mail.gmail.com>
<CAA4eK1+C3QxAZ6UtpSn9umGB33YjtYJgxA_xVXCacATEfZG4YQ@mail.gmail.com>
<CALj2ACUNDR==n6ebq86ShBqdf64EasANuxmXQBDYHDHeN3G5Fg@mail.gmail.com>
<CAA4eK1LF28ZTwmf3D-OQWeMdQqjB56P+iAmfWM7Bcwow3icBJQ@mail.gmail.com>
<CALj2ACVtLt0rPnr4NS6c72DdtQmpyQA=qcMaVfn6vu7j5yQvzw@mail.gmail.com>
<CAA4eK1+7Y6bknNNentcNfkmCBfm3j2fLjA4JjVydz3TB2MTjVA@mail.gmail.com>
<CALj2ACUR0=ByDv2VcqqbT0x+0T0gde7Zosb0A_8syPM63WSoFw@mail.gmail.com>
<CAA4eK1K7awEe1PXmmAUOoc+VnUJ76cPbYAV7mwwcW+2OxNyo7A@mail.gmail.com>
<[email protected]>
<CALj2ACXib_+Kuy3_WbTBJkURYGwO7ngS8+HYATReJtXShNCtNw@mail.gmail.com>
On Wed, Mar 20, 2024 at 12:49 AM Bharath Rupireddy
<[email protected]> wrote:
>
>
> Following are some open points:
>
> 1. Where to do inactive_timeout invalidation exactly if not the checkpointer.
>
I have suggested to do it at the time of CheckpointReplicationSlots()
and Bertrand suggested to do it whenever we resume using the slot. I
think we should follow both the suggestions.
> 2. Where to do XID age invalidation exactly if not the checkpointer.
> 3. How to go about recomputing XID horizons based on max_slot_xid_age.
> Does the slot's horizon's need to be adjusted in ComputeXidHorizons()?
>
I suggest postponing the patch for xid based invalidation for a later
discussion.
> 4. New invalidation mechanisms interaction with slot sync feature.
>
Yeah, this is important. My initial thoughts are that synced slots
shouldn't be invalidated on the standby due to timeout.
> 5. Review comments on 0001 from Bertrand.
>
> Please see the attached v12 patches.
>
Thanks for quickly updating the patches.
--
With Regards,
Amit Kapila.
view thread (18+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Introduce XID age and inactive timeout based replication slot invalidation
In-Reply-To: <CAA4eK1KZyjdn7oXS3d7qJU5ag9ss4xSk0Jkjsh5NOrRdkPkV1g@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox