MIME-Version: 1.0
References: <ZaegJe9JpUiQeV+D@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAJpy0uBc6H22RbNVU213AZ_BPw+uDptcTVHakKegpTCv74yN=w@mail.gmail.com>
 <CAA4eK1JZDtRFPJaeaLvj74760pcvaEAVxNPN0+oW5A4jL1WCBg@mail.gmail.com>
 <Za4cH83vTyZYNcYK@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAA4eK1JPB-zpGYTbVOP5Qp26tNQPMjDuYzNZ+a9RFiN5nE1tEA@mail.gmail.com>
 <CAJpy0uAmbh_1pH-eG5bTbHXXq9w-uNV45DT-12TTh9kGj2HeCw@mail.gmail.com>
 <CAFPTHDbsZ+pxAubb9d9BwVNt5OB3_2s77bG6nHcAgUPPhEVmMQ@mail.gmail.com>
 <CAJpy0uBqS_HD30mBR0yD1SVCvUZDrw1=dwn1xH8ANEQw7gnPdw@mail.gmail.com>
 <CAA4eK1Lxvfq9RwOEsguiMCrKPUc1He9UGz1_wi0N0cJaXFa4Eg@mail.gmail.com>
 <OS0PR01MB5716E304C26E6ACE0BE84925947A2@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <ZbIT9Kj3d8TFD8h6@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAA4eK1K0jRXa2AhKXRVDY+Y42MG4RTbfAEcTBEGN2ov=Yjco+A@mail.gmail.com>
 <OS0PR01MB571623B1D01003F99A7BB983947A2@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAA4eK1+3jV839U3+DGgHrgrhtDguaVwAyb0Hucz9UbpjjVL=Sg@mail.gmail.com>
 <OS0PR01MB5716DE2A364CB23F9144AED194782@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAHut+PsaPJzbTAFjXkRE0uJYk+xNAdOHEnoBFTvazsRZfYSU3Q@mail.gmail.com>
 <CAA4eK1+LnPajBsCXwCKbmOtDSJ=WWnXR+sHnTWav5OL3rebyyw@mail.gmail.com>
 <CAJpy0uAv2dS+NTw1X1uZep11WM24Wog2kN1oqJu4Zx4xjpgwig@mail.gmail.com>
 <CAA4eK1L6yoEs0OveL9xB+jopyp=Eps4ViU3JXhfpz0-2H3XCrg@mail.gmail.com>
 <OS0PR01MB5716303C750A3D2FB71B77CD947E2@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAA4eK1KkfVi-LCwHYd9B2xq-Q_2i0K-xwx1vnRoxFvG1n5SbNw@mail.gmail.com>
 <CAJpy0uBwhbq=c+qYfnOifu0vTo1DvOxDnJCd1ragZxe2K8=nDw@mail.gmail.com>
 <CAHut+PtOF31g0=mVkU=xO7cWVc3g21BeyS1m5yRxgFMuD3znXg@mail.gmail.com>
In-Reply-To: 
 <CAHut+PtOF31g0=mVkU=xO7cWVc3g21BeyS1m5yRxgFMuD3znXg@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Wed, 31 Jan 2024 08:48:40 +0530
Message-ID: 
 <CAA4eK1K_5v+c8wyWDAdneTX3rEwVuzPX3bKhU_RtROitEcTgRg@mail.gmail.com>
Subject: Re: Synchronizing slots from primary to standby
To: Peter Smith <smithpb2250@gmail.com>
Cc: shveta malik <shveta.malik@gmail.com>,
 "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>,
	Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
 Ajin Cherian <itsajin@gmail.com>,
	Masahiko Sawada <sawada.mshk@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>,
	Nisha Moond <nisha.moond412@gmail.com>,
	"Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
 Bruce Momjian <bruce@momjian.us>,
	Ashutosh Sharma <ashu.coek88@gmail.com>, Andres Freund <andres@anarazel.de>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAA4eK1K_5v%2Bc8wyWDAdneTX3rEwVuzPX3bKhU_RtROitEcTgRg%40mail.gmail.com>
Precedence: bulk

On Wed, Jan 31, 2024 at 7:27=E2=80=AFAM Peter Smith <smithpb2250@gmail.com>=
 wrote:
>
> I saw that v73-0001 was pushed, but it included some last-minute
> changes that I did not get a chance to check yesterday.
>
> Here are some review comments for the new parts of that patch.
>
> =3D=3D=3D=3D=3D=3D
> doc/src/sgml/ref/create_subscription.sgml
>
> 1.
> connect (boolean)
>
>     Specifies whether the CREATE SUBSCRIPTION command should connect
> to the publisher at all. The default is true. Setting this to false
> will force the values of create_slot, enabled, copy_data, and failover
> to false. (You cannot combine setting connect to false with setting
> create_slot, enabled, copy_data, or failover to true.)
>
> ~
>
> I don't think the first part "Setting this to false will force the
> values ... failover to false." is strictly correct.
>
> I think is correct to say all those *other* properties (create_slot,
> enabled, copy_data) are forced to false because those otherwise have
> default true values.
>

So, won't when connect=3Dfalse, the user has to explicitly provide such
values (create_slot, enabled, etc.) as false? If so, is using 'force'
strictly correct?

> ~~~
>
> 2.
>           <para>
>            Since no connection is made when this option is
>            <literal>false</literal>, no tables are subscribed. To initiat=
e
>            replication, you must manually create the replication slot, en=
able
> -          the subscription, and refresh the subscription. See
> +          the failover if required, enable the subscription, and refresh=
 the
> +          subscription. See
>            <xref
> linkend=3D"logical-replication-subscription-examples-deferred-slot"/>
>            for examples.
>           </para>
>
> IMO "see the failover if required" is very vague. See what failover?
>

AFAICS, the committed docs says: "To initiate replication, you must
manually create the replication slot, enable the failover if required,
...". I am not sure what you are referring to.

>
> =3D=3D=3D=3D=3D=3D
> src/bin/pg_upgrade/t/004_subscription.pl
>
> 5.
> -# The subscription's running status should be preserved. Old subscriptio=
n
> -# regress_sub1 should be enabled and old subscription regress_sub2 shoul=
d be
> -# disabled.
> +# The subscription's running status and failover option should be preser=
ved.
> +# Old subscription regress_sub1 should have enabled and failover as true=
 while
> +# old subscription regress_sub2 should have enabled and failover as fals=
e.
>  $result =3D
>    $new_sub->safe_psql('postgres',
> - "SELECT subname, subenabled FROM pg_subscription ORDER BY subname");
> -is( $result, qq(regress_sub1|t
> -regress_sub2|f),
> + "SELECT subname, subenabled, subfailover FROM pg_subscription ORDER
> BY subname");
> +is( $result, qq(regress_sub1|t|t
> +regress_sub2|f|f),
>   "check that the subscription's running status are preserved");
>
> ~
>
> Calling those "old subscriptions" seems misleading. Aren't these the
> new/upgraded subscriptions being checked here?
>

Again the quoted wording is not introduced by this patch. But, I see
your point and it is better if you can start a separate thread for it.

--=20
With Regards,
Amit Kapila.