MIME-Version: 1.0
References: 
 <CANhcyEVQ866NA5NbTi-aQhPj2zN_vbNb_ZW=E_P2foZYrW9VbA@mail.gmail.com>
 <202505101759.6qlloepaeddl@alvherre.pgsql>
In-Reply-To: <202505101759.6qlloepaeddl@alvherre.pgsql>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Thu, 15 May 2025 18:18:58 +0530
Message-ID: 
 <CAA4eK1KavSbVdk9OeQDV5yc0FVy_rFTam5HPozqYSoM=a=8hXg@mail.gmail.com>
Subject: Re: Restrict publishing of partitioned table with a foreign table as
 partition
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@alvh.no-ip.org>
Cc: Shlok Kyal <shlok.kyal.oss@gmail.com>, vignesh C <vignesh21@gmail.com>,
	Sergey Tatarintsev <s.tatarintsev@postgrespro.ru>,
 pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAA4eK1KavSbVdk9OeQDV5yc0FVy_rFTam5HPozqYSoM%3Da%3D8hXg%40mail.gmail.com>
Precedence: bulk

On Sun, May 11, 2025 at 6:53=E2=80=AFAM =C3=81lvaro Herrera <alvherre@alvh.=
no-ip.org> wrote:
>
> But the non-idiomatic locking of pg_partitioned_table appears to
> continue to be the pain point of this patch.  My impression is that
> using a lock is the wrong approach to solve the concurrency problem.
> Maybe we can use a ConditionVariable instead somehow.  (The real trick
> here is to figure out exactly _how_ to use the CV, I mean what exactly
> is the condition that the CV sleeps on?)
>

Can we fix this problem by having a check at the time of
CREATESUBSCRIPTION such that, if copy-data is true, then we ensure
that the specified publishers don't have a foreign table? We have a
somewhat similar check for publications in the function
check_publications_origin(), though for a different purpose. Along
with it, we can still have a check during foreign table
creation/attach that it doesn't become part of some publication, as
the patch may have it now.

--=20
With Regards,
Amit Kapila.