MIME-Version: 1.0
References: 
 <CABdArM4uA=6nA0BunJwudiEoY1BcWUS_oj_2pkEq_d-YdiBJhw@mail.gmail.com>
 <CAHGQGwEOvk0ioxT+eGX-6vHO=2kQRXwKcbOku0qW2cEZ0DnJiQ@mail.gmail.com>
In-Reply-To: 
 <CAHGQGwEOvk0ioxT+eGX-6vHO=2kQRXwKcbOku0qW2cEZ0DnJiQ@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Tue, 2 Jun 2026 08:26:29 +0530
Message-ID: 
 <CAA4eK1KbUpkEq5Pv0_ORLqxea-Gzi=PJjvVS4T-r+WTuKDGQMA@mail.gmail.com>
Subject: Re: Fix column privileges for pg_subscription.subwalrcvtimeout
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Nisha Moond <nisha.moond412@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAA4eK1KbUpkEq5Pv0_ORLqxea-Gzi%3DPJjvVS4T-r%2BWTuKDGQMA%40mail.gmail.com>
Precedence: bulk

On Tue, Jun 2, 2026 at 8:16=E2=80=AFAM Fujii Masao <masao.fujii@gmail.com> =
wrote:
>
> On Mon, Jun 1, 2026 at 10:44=E2=80=AFPM Nisha Moond <nisha.moond412@gmail=
.com> wrote:
> >
> > Hi Hackers,
> >
> > IIUC, all columns of pg_subscription, except subconninfo, are intended
> > to be readable by non-superusers as well. A comment in
> > system_views.sql also states:
> > "-- All columns of pg_subscription except subconninfo are publicly read=
able."
> >
> > However, 'subwalrcvtimeout' is currently not accessible:
> > Test:
> > postgres=3D# CREATE ROLE nisha LOGIN PASSWORD 'testpass';
> > CREATE ROLE
> > postgres=3D# SET SESSION AUTHORIZATION nisha;
> > SET
> > postgres=3D> select subwalrcvtimeout from pg_subscription;
> > ERROR:  permission denied for table pg_subscription
> >
> > It appears the column-level privileges for pg_subscription were not
> > updated when subwalrcvtimeout was added.
> >
> > Attached is a small fix patch to grant public access to this column,
> > consistent with the existing behavior of the other pg_subscription
> > columns.
>
> Thanks for the report and the patch! It looks good to me.
>
> Barring any objections, I'll commit it. For my own reference, since this
> changes the catalog, I'll need to update the catalog version when committ=
ing.
>
> BTW, should we add a regression test for column privileges on pg_subscrip=
tion
> to help catch similar issues in the future?
>

+1. It makes sense because I noticed that patch authors previously
also omitted this part though in most cases those are caught in
review.

--=20
With Regards,
Amit Kapila.