Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wcjnh-003aHO-33 for pgsql-hackers@arkaria.postgresql.org; Thu, 25 Jun 2026 13:07:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wcjng-005mQR-2l for pgsql-hackers@arkaria.postgresql.org; Thu, 25 Jun 2026 13:07:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wcjng-005mQJ-1m for pgsql-hackers@lists.postgresql.org; Thu, 25 Jun 2026 13:07:24 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wcjne-00000000CUu-1PNE for pgsql-hackers@lists.postgresql.org; Thu, 25 Jun 2026 13:07:24 +0000 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-2c6b3f71648so20463635ad.2 for ; Thu, 25 Jun 2026 06:07:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1782392839; cv=none; d=google.com; s=arc-20260327; b=tC6h0LT9cnN5fs7VIun78sBDreQDPs3BI5SWSp5hCIdAsYiVoGwkqJhQWL3fh5rbk/ 5/s6LvSUpIz1IAdAn5dmBuAegnKdQzmJYFjYIWKpI64ImY0uYr+JP5POeYdisHBPaICN anIeFbzmswPjpbfTGl2OCF1d85MPsaDe6IAhv2bC7cOklgCNyfDs+P5GPaYIj0Qp1h9g 85iMVUZychXXGbJTMR8iltk6cE3hpxjki3VsKg9DrBX6sx+vO0P/LTEYp+buOrl98TsO RPvFhWadfskrtA8QNiCMZIjHQ7riAsUq+Noy7w6JIyUfimAf6/rvgFTj44IlDQEXyDDY BSCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=DRLO9THlVexoa6Nz7jeP3kjHsmjIXkl0XMuffExsnpA=; fh=nmGRn3URdD8B37x214kE7m01C/WJeSOWM3/Rx/zCGBs=; b=SsV7x0tA10pNdLWeqbUA90SNtMpilyVGIrz2+HG8T5jxrHxt+uq5Ga3jgLFJYJ3SF5 DC/KR1bm3IUtOAH8ijc5DhUXsE0CvUV39aZm5A680G1/L9DhM76GYJUK53oIjs52OvLc fIQ0J4FZ+j6szQvgCd0hkRjvl8U4nrIOuXXy6wIAimVc8SDYf7XvKfszv1XY6QJ7WQ5+ Ul2Hu2YqYQBb+P/MOZtyx4fTtAvrHe6d8m5pGDsMWerQj8SjHhIFwEl2h5iUdSYcfJ9L BdJ74S6alxP57hMFnK2p0VA047viZDodPM3YAKljAaMlp+CLDVEy6eX/8GkmwihnYBz3 q9Ww==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782392839; x=1782997639; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DRLO9THlVexoa6Nz7jeP3kjHsmjIXkl0XMuffExsnpA=; b=D1MCdD1GKe0JH/036PvFO4uRu9TdmEF257M3WINY17OJ0jM7LSIpeEDEml62W0FtYY lEBem1ERk69hZ5RAnHtLR+NIpZoUDfmyZ8OhAE/o/SWBIok/2YoPZK+FZ9FSkbsBhytL YPnka05L6PNyyXyp+SfbgSr2VPSn7+vhoOuzbaAJaCdIH0YKweZH1zBPXrKThUsaDuuZ BcetczMYKo71HZo97jYbMGiQ57u59j8qt7snQFR4smO/l1N5UnVEI3Eom+1Dx5GZQMXZ +A4Q9kiZLisj9JLT+i1xh7UgKE4Lf2aoVDocqPuBm7C0LHWtH+w+oxIGd8WKsdi+sUdH Y8xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782392839; x=1782997639; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DRLO9THlVexoa6Nz7jeP3kjHsmjIXkl0XMuffExsnpA=; b=Lf56BGgim8k0/QhzAmiygStNOFKX1syxUqpttOzwBASWw2M+d6QnbXO7J/4AUf4Z2p nUqoi90fH2j8G9IDfljLtaFzBkfRajFNqRBt7kEkkHwrdkaA3K1TKNTypybcvbEq6GrR WHiH3wEFF0Mw2+H0X7SkSIBddt/0Bken7SmewYoQKxkp4rf9ON3wBlQxlvrioBRSRLLl 1uxnmdbWzYGO4+S2lr5bz5PdP9w/UjvAo7v5isVC8TIf8ybkntb2ho0Vbt9u0at7vSfX 1hkXjd+kH3oQI64H03PObpGklO7kVqnmXN0oOshQvAuo3gG11ti9/npHrQsdr2l+Jg6/ tr0Q== X-Forwarded-Encrypted: i=1; AHgh+RoeDRr/m4parwSbZAS1NA2JBPPnSjcLC8ow/Ol/Y3Or6/d0eO1fkq3rixq48qsowBHODtwxXcmLFd4mCZK2@lists.postgresql.org X-Gm-Message-State: AOJu0Yw4m6wkpzTxgE7QH0q3H8kzsK63afW9pg9+WBqaZsrl/N1aNhKr S1VJg/z0Vc1V36m+/+rNlq7AMBzwdEAmtE/ItxIJCtmmh+Gx8ArGKpbSC5kUh9eWLjEUwWkEOMS 8Q4D/pr/4hi0Xf3xW1Kje+6SnRN4zSuM= X-Gm-Gg: AfdE7clUatNllx68eezdfQo1Mg3RG+6VSuoPG+6strQvacQirNbShFgB51Ne5bXoTBQ WJPzwJHo+YS3IicrVrb3IeLGlAXTwTphFMpRqPilrcVN1F5yi6GEqzi5I+iFMkk8V4rjhSZYq7Q OhnUDdJ1nslop5vdiup8kDuclLrQh96rrJYnEMfLYTYuyY1uFnQSWmm1E8C+ga+Q01A2Xmg8aac kvJTRKf3s/PuM5rPBI+aZfp9ilj9Wln6FU7pTy/zH0ppB6j8RdXgu+T+a5dKP3GWJJjyj4GAG/D aNpKmf/+k+FroZT/k6wK0dWZVXQs/miujTO10iF8d/VWjeOgWc8jtg67mC+hZyEwQI6pON6p0NQ = X-Received: by 2002:a17:903:1cb:b0:2c7:f227:58ee with SMTP id d9443c01a7336-2c7fca717bdmr20086995ad.22.1782392839012; Thu, 25 Jun 2026 06:07:19 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Amit Kapila Date: Thu, 25 Jun 2026 18:37:06 +0530 X-Gm-Features: AVVi8Ccd1Fe2lQfQxPrazwkekfEbsdxuNsNVk_Ozz9AcpF-vjzyck2n2pi1d_ls Message-ID: Subject: Re: Proposal: Conflict log history table for Logical Replication To: Dilip Kumar Cc: vignesh C , Nisha Moond , shveta malik , Peter Smith , Masahiko Sawada , Bharath Rupireddy , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Jun 25, 2026 at 6:30=E2=80=AFPM Dilip Kumar = wrote: > > On Thu, Jun 25, 2026 at 4:57=E2=80=AFPM Amit Kapila wrote: > > > > > 2. > > @@ -2482,6 +2681,8 @@ DropSubscription(DropSubscriptionStmt *stmt, > > bool isTopLevel) > > deleteDependencyRecordsFor(SubscriptionRelationId, subid, false); > > deleteSharedDependencyRecordsFor(SubscriptionRelationId, subid, 0); > > > > + drop_sub_conflict_log_table(subid, subname, subconflictlogrelid); > > > > It would be better to drop the table before cleaning up the dependency > > record. Right now, it is okay even in current order because dependency > > removal is trying to remove where subid is depender. > > So whats your suggestion change it now or not? I feel either way is fine= . > Let's change now itself. --=20 With Regards, Amit Kapila.