public inbox for [email protected]
help / color / mirror / Atom feedFrom: Amit Kapila <[email protected]>
To: shveta malik <[email protected]>
Cc: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: Zhijie Hou (Fujitsu) <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [bug fix] prepared transaction might be lost when max_prepared_transactions is zero on the subscriber
Date: Wed, 21 Aug 2024 15:27:46 +0530
Message-ID: <CAA4eK1KjgViaqQGR6897+20Z_zOARr4CrZr06jmc3Euq22453Q@mail.gmail.com> (raw)
In-Reply-To: <CAJpy0uA+yBtU0kUKpioy9hvUXriEnnz871zP1dirK5ba2x7V4w@mail.gmail.com>
References: <TYAPR01MB5692FAC23BE40C69DA8ED4AFF5B92@TYAPR01MB5692.jpnprd01.prod.outlook.com>
<CAA4eK1J8j33OrTVGRgpw9eGYsFyyT=XyLJ2eC4DpzsoggYKTDg@mail.gmail.com>
<TYAPR01MB5692AE79A51187517DF84A43F5BA2@TYAPR01MB5692.jpnprd01.prod.outlook.com>
<CAJpy0uA_BMM_Rb-1a7SNubDJ0rhTya5fACAHa2SmzgdnWRf63Q@mail.gmail.com>
<CAA4eK1JwxN8r4K+E1USuQkqoKUkTVnCZbh+fvQP7DP7buWheKQ@mail.gmail.com>
<CAJpy0uAa3M9sC3GWTUA+YPTnYxEcorFt_7g6rXz05jNcAGdjgQ@mail.gmail.com>
<CAA4eK1K=hFfrB1rW5Mbd5aTGBP_yo1nKb-0jdib842Z9bTz_Dw@mail.gmail.com>
<CAJpy0uA+yBtU0kUKpioy9hvUXriEnnz871zP1dirK5ba2x7V4w@mail.gmail.com>
On Tue, Aug 20, 2024 at 2:01 PM shveta malik <[email protected]> wrote:
>
> On Tue, Aug 20, 2024 at 11:36 AM Amit Kapila <[email protected]> wrote:
> >
> > On Wed, Aug 14, 2024 at 10:26 AM shveta malik <[email protected]> wrote:
> > >
> > > >
> > > > Thanks for the detailed analysis. I agree with your analysis that we
> > > > need to reset the origin information for the shutdown path to avoid it
> > > > being advanced incorrectly. However, the patch doesn't have sufficient
> > > > comments to explain why we need to reset it for both the ERROR and
> > > > Shutdown paths. Can we improve the comments in the patch?
> > > >
> > > > Also, for the ERROR path, can we reset the origin information in
> > > > apply_error_callback()?
> > >
> > > Please find v4 attached. Addressed comments in that.
> > >
> >
> > The patch looks mostly good to me. I have slightly changed a few of
> > the comments in the attached. What do you think of the attached?
> >
>
> Looks good to me. Please find backported patches attached.
>
Pushed.
--
With Regards,
Amit Kapila.
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [bug fix] prepared transaction might be lost when max_prepared_transactions is zero on the subscriber
In-Reply-To: <CAA4eK1KjgViaqQGR6897+20Z_zOARr4CrZr06jmc3Euq22453Q@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox