MIME-Version: 1.0
References: <ZaegJe9JpUiQeV+D@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAJpy0uBc6H22RbNVU213AZ_BPw+uDptcTVHakKegpTCv74yN=w@mail.gmail.com>
 <CAA4eK1JZDtRFPJaeaLvj74760pcvaEAVxNPN0+oW5A4jL1WCBg@mail.gmail.com>
 <Za4cH83vTyZYNcYK@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAA4eK1JPB-zpGYTbVOP5Qp26tNQPMjDuYzNZ+a9RFiN5nE1tEA@mail.gmail.com>
 <CAJpy0uAmbh_1pH-eG5bTbHXXq9w-uNV45DT-12TTh9kGj2HeCw@mail.gmail.com>
 <CAFPTHDbsZ+pxAubb9d9BwVNt5OB3_2s77bG6nHcAgUPPhEVmMQ@mail.gmail.com>
 <CAJpy0uBqS_HD30mBR0yD1SVCvUZDrw1=dwn1xH8ANEQw7gnPdw@mail.gmail.com>
 <CAA4eK1Lxvfq9RwOEsguiMCrKPUc1He9UGz1_wi0N0cJaXFa4Eg@mail.gmail.com>
 <OS0PR01MB5716E304C26E6ACE0BE84925947A2@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <ZbIT9Kj3d8TFD8h6@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAA4eK1K0jRXa2AhKXRVDY+Y42MG4RTbfAEcTBEGN2ov=Yjco+A@mail.gmail.com>
 <OS0PR01MB571623B1D01003F99A7BB983947A2@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAA4eK1+3jV839U3+DGgHrgrhtDguaVwAyb0Hucz9UbpjjVL=Sg@mail.gmail.com>
 <OS0PR01MB5716DE2A364CB23F9144AED194782@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAHut+PsaPJzbTAFjXkRE0uJYk+xNAdOHEnoBFTvazsRZfYSU3Q@mail.gmail.com>
 <CAA4eK1+LnPajBsCXwCKbmOtDSJ=WWnXR+sHnTWav5OL3rebyyw@mail.gmail.com>
 <CAJpy0uAv2dS+NTw1X1uZep11WM24Wog2kN1oqJu4Zx4xjpgwig@mail.gmail.com>
 <CAA4eK1L6yoEs0OveL9xB+jopyp=Eps4ViU3JXhfpz0-2H3XCrg@mail.gmail.com>
 <OS0PR01MB5716303C750A3D2FB71B77CD947E2@OS0PR01MB5716.jpnprd01.prod.outlook.com>
In-Reply-To: 
 <OS0PR01MB5716303C750A3D2FB71B77CD947E2@OS0PR01MB5716.jpnprd01.prod.outlook.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Tue, 30 Jan 2024 11:31:18 +0530
Message-ID: 
 <CAA4eK1KkfVi-LCwHYd9B2xq-Q_2i0K-xwx1vnRoxFvG1n5SbNw@mail.gmail.com>
Subject: Re: Synchronizing slots from primary to standby
To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Cc: shveta malik <shveta.malik@gmail.com>,
 Peter Smith <smithpb2250@gmail.com>,
	Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
 Ajin Cherian <itsajin@gmail.com>,
	Masahiko Sawada <sawada.mshk@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>,
	Nisha Moond <nisha.moond412@gmail.com>,
	"Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
 Bruce Momjian <bruce@momjian.us>,
	Ashutosh Sharma <ashu.coek88@gmail.com>, Andres Freund <andres@anarazel.de>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAA4eK1KkfVi-LCwHYd9B2xq-Q_2i0K-xwx1vnRoxFvG1n5SbNw%40mail.gmail.com>
Precedence: bulk

On Mon, Jan 29, 2024 at 6:47=E2=80=AFPM Zhijie Hou (Fujitsu)
<houzj.fnst@fujitsu.com> wrote:
>
> On Monday, January 29, 2024 7:30 PM Amit Kapila <amit.kapila16@gmail.com>=
 wrote:
> >
>
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > 1.
> > parse_subscription_options()
> > {
> > ...
> > /*
> > * We've been explicitly asked to not connect, that requires some
> > * additional processing.
> > */
> > if (!opts->connect && IsSet(supported_opts, SUBOPT_CONNECT)) {
> >
> > Here, along with other options, we need an explicit check for failover,=
 so that if
> > connect=3Dfalse and failover=3Dtrue, the statement should give error. I=
 was
> > expecting the below statement to fail but it passed with WARNING.
> > postgres=3D# create subscription sub2 connection 'dbname=3Dpostgres'
> > publication pub2 with(connect=3Dfalse, failover=3Dtrue);
> > WARNING:  subscription was created, but is not connected
> > HINT:  To initiate replication, you must manually create the replicatio=
n slot,
> > enable the subscription, and refresh the subscription.
> > CREATE SUBSCRIPTION
>
> Added.
>

In this regard, I feel we don't need to dump/restore the 'FAILOVER'
option non-binary upgrade paths similar to the 'ENABLE' option. For
binary upgrade, if the failover option is enabled, then we can enable
it using Alter Subscription SET (failover=3Dtrue). Let's add one test
corresponding to this behavior in
postgresql\src\bin\pg_upgrade\t\004_subscription.

Additionally, we need to update the pg_dump docs for the 'failover'
option. See "When dumping logical replication subscriptions, .." [1].
I think we also need to update the connect option docs in CREATE
SUBSCRIPTION [2].

[1] - https://www.postgresql.org/docs/devel/app-pgdump.html
[2] - https://www.postgresql.org/docs/devel/sql-createsubscription.html

--=20
With Regards,
Amit Kapila.