public inbox for [email protected]  

help / color / mirror / Atom feed

From: Amit Kapila <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: [email protected]
Subject: Re: wake up logical workers after ALTER SUBSCRIPTION
Date: Tue, 22 Nov 2022 16:59:28 +0530
Message-ID: <CAA4eK1KzPvvGfK1mY3gvfsLEEWS+moRjWbmbGExLRQHM41P6YA@mail.gmail.com> (raw)
In-Reply-To: <20221122004119.GA132961@nathanxps13>
References: <20221122004119.GA132961@nathanxps13>

On Tue, Nov 22, 2022 at 6:11 AM Nathan Bossart <[email protected]> wrote:
>
> While working on avoiding unnecessary wakeups in logical/worker.c (as was
> done for walreceiver.c in 05a7be9), I noticed that the tests began taking
> much longer.  This seems to be caused by the reduced frequency of calls to
> maybe_reread_subscription() in LogicalRepApplyLoop().
>

I think it would be interesting to know why tests started taking more
time after a reduced frequency of calls to
maybe_reread_subscription(). IIRC, we anyway call
maybe_reread_subscription for each xact.

-- 
With Regards,
Amit Kapila.

view thread (46+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: wake up logical workers after ALTER SUBSCRIPTION
  In-Reply-To: <CAA4eK1KzPvvGfK1mY3gvfsLEEWS+moRjWbmbGExLRQHM41P6YA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox