MIME-Version: 1.0
References: 
 <CAEoWx2mMorbMwjKbT4YCsjDyL3r9Mp+z0bbK57VZ+OkJTgJQVQ@mail.gmail.com>
 <CAA4eK1+UL6wVDNzkpHjA7RVLD_8AkrP2tu+RvQ2h5AUjyEe+-Q@mail.gmail.com>
 <5ABD7727-CD22-4112-A186-0E788EE78109@gmail.com>
 <CAFiTN-ucvk8JOiLvjii6VXar6nYJvCQDgzp8_4v55yweUmzdzw@mail.gmail.com>
 <23A24BFF-18A7-4FE9-AAFA-13E1AA207DD0@gmail.com>
In-Reply-To: <23A24BFF-18A7-4FE9-AAFA-13E1AA207DD0@gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Mon, 15 Dec 2025 11:18:14 +0530
Message-ID: 
 <CAA4eK1KzjxO-qWjWSox6e6AWH4FVU5ZPEgeZ+na=eyov7umutg@mail.gmail.com>
Subject: Re: Improve logical replication usability when tables lack primary
 keys
To: Chao Li <li.evan.chao@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAA4eK1KzjxO-qWjWSox6e6AWH4FVU5ZPEgeZ%2Bna%3Deyov7umutg%40mail.gmail.com>
Precedence: bulk

On Mon, Dec 15, 2025 at 9:06=E2=80=AFAM Chao Li <li.evan.chao@gmail.com> wr=
ote:
>
> > On Dec 15, 2025, at 11:28, Dilip Kumar <dilipbalaut@gmail.com> wrote:
> >
> > On Tue, Nov 11, 2025 at 6:11=E2=80=AFPM Chao Li <li.evan.chao@gmail.com=
> wrote:
> >>
> >> Hi Amit,
> >>
> >> Thanks for asking.
> >>
> >>> On Nov 11, 2025, at 19:18, Amit Kapila <amit.kapila16@gmail.com> wrot=
e:
> >>>
> >>> On Mon, Nov 10, 2025 at 1:36=E2=80=AFPM Chao Li <li.evan.chao@gmail.c=
om> wrote:
> >>>>
> >>>> * BACKGROUND
> >>>>
> >>>> This requirement comes from several users operating large deployment=
s, particularly in HIS (Hospital Information Systems). The situation can be=
 summarized as follows:
> >>>>
> >>>> - A central DB operations team maintains the main database and confi=
gures logical replication for all tables.
> >>>> - Multiple third-party application vendors are allowed to create new=
 tables in that database.
> >>>> - Some of these newly created tables lack a primary key. Since logic=
al replication with `REPLICATION IDENTITY DEFAULT` requires a primary key, =
such tables silently fail to replicate.
> >>>> - The DB operations team must then spend significant effort identify=
ing the affected tables and correcting them manually.
> >>>>
> >>>
> >>> Can you share an example of how we silently fail to replicate? Won't
> >>> in such cases UPDATE/DELETE will anyway raise an ERROR?
> >>>
> >>
> >> Yes, UPDATE/DELETE will fail. That=E2=80=99s the easy case to expose t=
he error. Actually my patch will allow the update/delete.
> >>
> >> However, some tables, like dictionary tables, they are important, but =
don=E2=80=99t have much update/delete, they may silently fail to replicate.
> >
> > But other than UPDATE/DELETE for what operation we need RI, I mean
> > INSERT would work without any RI and UPDATE/DELETE will fail on the
> > publisher itself without setting RI, so can you explain the exact case
> > where it will silently fail to replicate?
> >
>
> Thanks for asking. When fallback to FULL, UPDATE/DELETE will be allowed i=
n the publisher side. In my first email, attached v1 patch is a PoC that ha=
s implemented the logic.
>

So, without patch, there is no way we can silently replicate the
UPDATE/DELETE. Ideally, users should alter the tables and make RI as
FULL in such cases if they don't have PK for such tables. Falling back
to FULL for DEFAULT when the table doesn't have PK based on GUC has a
downside that it will increase WAL volume by a large amount. I think
it should be done specific to tables that users want to replicate. I
don't know what is a good way to give to users who don't want to do
the required setup but if we really want to provide something, it is
better to allow such a thing via the publication option instead. I
think it would be good to do such an enhancement if we have more
community support and some other users also appreciate such a feature.
Otherwise, adding something which is specific to a particular user
sounds like a recipe of maintenance burden especially when we already
provide a way to achieve the same thing as is required by the user.

--=20
With Regards,
Amit Kapila.