public inbox for [email protected]
help / color / mirror / Atom feedFrom: Amit Kapila <[email protected]>
To: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Subject: Re: Have pg_basebackup write "dbname" in "primary_conninfo"?
Date: Mon, 11 Mar 2024 17:15:57 +0530
Message-ID: <CAA4eK1L+39988Rzq4hD0h1y+s0234PH3G-u7NbUmfwE438mbGQ@mail.gmail.com> (raw)
In-Reply-To: <TYCPR01MB12077B81FCAFDFE104DEEE7BAF5592@TYCPR01MB12077.jpnprd01.prod.outlook.com>
References: <CA+TgmoYfagyp5AvKMfGpRUgXNJZ0ymuqiWTzOc2tV_ZMM0UkCA@mail.gmail.com>
<TYCPR01MB1207777150173002564A753B8F5502@TYCPR01MB12077.jpnprd01.prod.outlook.com>
<CA+TgmoaLRCcCeY3_n7h0rw-r-UfJt_GiFZiJQ1pFZ-iQNUozug@mail.gmail.com>
<[email protected]>
<CAA4eK1Jh=V38dRV059wdbacT9TkQ0oWGcqDfo5V4X2shvKykfA@mail.gmail.com>
<TYCPR01MB1207779B65625AAEC975B5EC0F5592@TYCPR01MB12077.jpnprd01.prod.outlook.com>
<TYCPR01MB12077B81FCAFDFE104DEEE7BAF5592@TYCPR01MB12077.jpnprd01.prod.outlook.com>
On Tue, Feb 27, 2024 at 2:07 PM Hayato Kuroda (Fujitsu)
<[email protected]> wrote:
>
> > PSA the patch for implementing it. It is basically same as Ian's one.
> > However, this patch still cannot satisfy the condition 3).
> >
> > `pg_basebackup -D data_N2 -d "user=postgres" -R`
> > -> dbname would not be appeared in primary_conninfo.
> >
> > This is because `if (connection_string)` case in GetConnection() explicy override
> > a dbname to "replication". I've tried to add a dummy entry {"dbname", NULL} pair
> > before the overriding, but it is no-op. Because The replacement of the dbname in
> > pqConnectOptions2() would be done only for the valid (=lastly specified)
> > connection options.
>
> Oh, this patch missed the straightforward case:
>
> pg_basebackup -D data_N2 -d "user=postgres dbname=replication" -R
> -> dbname would not be appeared in primary_conninfo.
>
> So I think it cannot be applied as-is. Sorry for sharing the bad item.
>
Can you please share the patch that can be considered for review?
--
With Regards,
Amit Kapila.
view thread (13+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Have pg_basebackup write "dbname" in "primary_conninfo"?
In-Reply-To: <CAA4eK1L+39988Rzq4hD0h1y+s0234PH3G-u7NbUmfwE438mbGQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox