public inbox for [email protected]
help / color / mirror / Atom feedFrom: Amit Kapila <[email protected]>
To: Bertrand Drouvot <[email protected]>
Cc: Masahiko Sawada <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: shveta malik <[email protected]>
Cc: Bharath Rupireddy <[email protected]>
Cc: [email protected]
Subject: Re: Add contrib/pg_logicalsnapinspect
Date: Wed, 5 Mar 2025 14:42:15 +0530
Message-ID: <CAA4eK1L0bZbZOr8-VNFXDfqaTwggdf_-HTAsneui+_ozMTvZQg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <ZwfSXS/[email protected]>
<CAD21AoCoyNBCahi6efsjG9Lr_dGsVin1m6Y6tj4dTE6UnTAcbw@mail.gmail.com>
<[email protected]>
<CAD21AoB31apHCzZ-45rDtB56qQm+TBwJnB48JjBvuqR5xviAEQ@mail.gmail.com>
<CAD21AoD+opO0SaDSFvz+n+wAxc-kUrpF5Wtxbw80Bqpay+rkgw@mail.gmail.com>
<CAHut+PsYdTW4+U+fioh9_yO8iT6RnY=PquzfCZu7zRU6Qg6W7g@mail.gmail.com>
<Zwy4ys76aPcoVE/[email protected]>
<CAD21AoDuO87MFrPJFwtmRi=cFhDGac0zq7sq5pdEhVi7zUvbEg@mail.gmail.com>
<5qbxud4pvnvmtuoi7weiizm5hmumxaeohx4vztfhrwlfhyz6rj@buh4435mllwo>
<CAD21AoBM6vAcPGR-ng0nqGG0yemR_ufdg3+v3gkPa6Nc2ntnrA@mail.gmail.com>
<[email protected]>
On Wed, Mar 5, 2025 at 12:47 PM Bertrand Drouvot
<[email protected]> wrote:
>
> Hi,
>
> On Tue, Mar 04, 2025 at 10:25:57PM -0800, Masahiko Sawada wrote:
> > On Tue, Mar 4, 2025 at 1:56 PM Andres Freund <[email protected]> wrote:
> > >
> > Thank you for the report.
>
> +1
>
> > It seems that bgwriter wrote another RUNNING_XACTS record during the
> > test, making the logical decoding write an extra snapshot on the disk.
>
> Yup.
>
> > One way to stabilize the regression test would be that we check if
> > there is a serialized snapshot that has expected number of catchange
> > transactions and number of committed transactions, instead of dumping
> > all serialized snapshots.
>
> Agree, PFA a patch doing so.
>
It would be better if you could add a few comments atop the
permutation line to explain the working of the test. We have it for
other decoding-related tests. See
test_decoding/specs/subxact_without_top.spec for reference.
--
With Regards,
Amit Kapila.
view thread (36+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Add contrib/pg_logicalsnapinspect
In-Reply-To: <CAA4eK1L0bZbZOr8-VNFXDfqaTwggdf_-HTAsneui+_ozMTvZQg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox