MIME-Version: 1.0
References: <CALj2ACUvU2fGLw7keEpxZhGAoMQ9vrCPX-13hexQPoR+QRbuOw@mail.gmail.com>
 <20220322180006.hgbsoldgbljyrcm7@alap3.anarazel.de> <CALj2ACUEbx7B_FJbyJxF_NxqmgPYXkNo3czZAv1iVBRKzAP3XA@mail.gmail.com>
 <20220324.135246.1277919245181951980.horikyota.ntt@gmail.com>
 <CALj2ACWHxU2brc1vRJKxmtgr6hAB6YnL9fjVdN_qEvv1HiWLFQ@mail.gmail.com>
 <20220324184758.tylwfuixi5l5ukb6@alap3.anarazel.de> <CALj2ACW2J77HMHBxHi7Abz3j2mx_sK2RJNgpRnVyoZBjoAXvWQ@mail.gmail.com>
 <CAMVpbFOzzgQMnz2XedRQSx86QrCkD6KW0Rk_fNsKmSG9SbFpxg@mail.gmail.com>
 <CALj2ACXBH6n40sgYZvtkYzkatYteL+bHftc-rEcOmWcmrfnF=A@mail.gmail.com>
 <21ff746189d3a933e687850c88f58805a4d23797.camel@j-davis.com>
 <CALj2ACUkZQJ=Q_aXDMe1f14j0YefYQQe9O7w_P0YymkSELMTCw@mail.gmail.com>
 <d3d60da5fd9d06282a833253fbcb4fc92531dae4.camel@j-davis.com>
 <CALj2ACXC8jmF1d74Mb9Ca9sVsN4biVDTka3=x6XO22XDM-t1jw@mail.gmail.com>
 <CALj2ACV7cXcCO-Ecyc9+_f71WeN-_HNqk=HJ7Ymvp3dXqN_s1A@mail.gmail.com>
 <CAA4eK1K6z=gu-jppU1dtsyr2BC-pzrq3TYe=RfY+w386dfdiFA@mail.gmail.com> <CALj2ACWmKd0KxXU4CW9ypVHbS=mF+NzdvGTr2YjFNvkSmB8tmg@mail.gmail.com>
In-Reply-To: <CALj2ACWmKd0KxXU4CW9ypVHbS=mF+NzdvGTr2YjFNvkSmB8tmg@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Tue, 12 Apr 2022 09:26:12 +0530
Message-ID: <CAA4eK1L5UCNOCzXJ0ET5Kjhq21CsNj43AnQcrZuvFGTs8sLnPA@mail.gmail.com>
Subject: Re: pg_walinspect - a new extension to get raw WAL data and WAL stats
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Jeff Davis <pgsql@j-davis.com>, RKN Sai Krishna <rknsaiforpostgres@gmail.com>, 
	Andres Freund <andres@anarazel.de>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, 
	Ashutosh Sharma <ashu.coek88@gmail.com>, Stephen Frost <sfrost@snowman.net>, 
	Robert Haas <robertmhaas@gmail.com>, Andrew Dunstan <andrew@dunslane.net>, Greg Stark <stark@mit.edu>, 
	Jeremy Schneider <schneider@ardentperf.com>, Bruce Momjian <bruce@momjian.us>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, 
	SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>, marvin_liang@qq.com, actyzhang@outlook.com
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAA4eK1L5UCNOCzXJ0ET5Kjhq21CsNj43AnQcrZuvFGTs8sLnPA%40mail.gmail.com>
Precedence: bulk

On Mon, Apr 11, 2022 at 6:33 PM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> On Mon, Apr 11, 2022 at 4:21 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Thu, Apr 7, 2022 at 3:35 PM Bharath Rupireddy
> > <bharath.rupireddyforpostgres@gmail.com> wrote:
> > >
> >
> > I am facing the below doc build failure on my machine due to this work:
> >
> > ./filelist.sgml:<!ENTITY pgwalinspect SYSTEM "pgwalinspect.sgml">
> > Tabs appear in SGML/XML files
> > make: *** [check-tabs] Error 1
> >
> > The attached patch fixes this for me.
>
> Thanks. It looks like there's a TAB in between. Your patch LGTM.
>
> I'm wondering why this hasn't been caught in the build farm members
> (or it may have been found but I'm missing to locate it.).
>
> Can you please provide me with the doc build command to catch these
> kinds of errors?
>

Nothing special. In the doc/src/sgml, I did make clean followed by make check.


-- 
With Regards,
Amit Kapila.