Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w7l8k-005fI6-29 for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Apr 2026 02:17:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w7l8j-00EFYb-0o for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Apr 2026 02:17:05 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w7l7Z-00EC1D-13 for pgsql-hackers@lists.postgresql.org; Wed, 01 Apr 2026 02:15:53 +0000 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w7l7X-00000002HH5-0If8 for pgsql-hackers@lists.postgresql.org; Wed, 01 Apr 2026 02:15:53 +0000 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-38a723b2b29so54179951fa.2 for ; Tue, 31 Mar 2026 19:15:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775009751; cv=none; d=google.com; s=arc-20240605; b=RzsocD7puM3fKrkd3PoK+oLAbHMQ4CWCtzpH8X1Tfk/rLtQtD1cjihum5/IB4n1Ze6 jmc4oaVMjoXnqJ4orW+7Zoh0uQZFXXufdnaUKhb0TG3hBvTrfC4oYTf/sGHIjVvCX+uG b601xoe28/5kXobzXrOL+lUzFTMVmFD0dodtcWa0RhhCo4wI/FMcw6bs3jH/CzQvLBcB qpD6WrGtP8kBg+LmIXTmRa1ISc+aapIlxk6LlYgYvshdF5UkMLsnmqJjNLMwId+wmy69 mA6Kkbn1rHA4qZaL0oILO8re4T5TsE81oxy+xr8xb63WlQmWhiTlVBnULPF+7KGFixp6 tQoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=3Uw2pDdKT9JmHwVD0L4gy84rrNNbsjzW+xaZmRss5aQ=; fh=5InifMfw3CkY4TWXexIsgVgYXiALGJ8Jh14z716IZp4=; b=UWzYom0scMj3aGv1zWBphjqIX6h5OncLjSrhRIdtQWt03MyvuWlnwlQaxKMLfKL1ZT 1d0625W6rnOkFUtt9Y316vTiwDfaVKBlAbCqHzyCZpvFiGasnmpopp5N7QNxsPPDSRzT d80X72GI/TW2JVsf0k3eqKxqgBGRj9d+DPAXXxh8W5B4Tab3G6Vh5VRGTTRMi6Aauxs9 GOcDsPakn6jWMc+kNUm0pZuIcOwXj8oyr27bTHlR93+mx6wq1Cud+wWy0aDIE0ce/WUy A1YKsxq9Ofc1qudOhL8k2Tl7Zva2UdviMDz4c/FzIPB7hTdnt3Q1uiTxJXv6GJ7c3kqn FAhA==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775009751; x=1775614551; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3Uw2pDdKT9JmHwVD0L4gy84rrNNbsjzW+xaZmRss5aQ=; b=BJ1FcqjtqjfFwaEohBLOP8/SOpCpxaFxamdiRyZ7bTykMnqEdScd36Cvstph8PTR4B m3PmOuUWEBwuJ6YTLKjqN46VTPrazl4ipGqV7644THez1mBKIF1BGBAMQXlWNNJ4XHus bGdVucgV5+ULk9Gr+PRFXYXJmgZ9AVgYfHEBkMl6+kI0Ez4xSeTQseT19rpin72NEDzH ReWp6lOXi3Bc/502bidxaTZZEsxb7Z1lB5N2SgQ76YK8W7LKwIjQgQyK7XkI1FX/gcu4 P0eAgRu2Qand58xHm9cuNxarH+NkXqKBQTjmC/tmBOih6s1kpdeGJVQYgIHYdQ9YwbdZ hrXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775009751; x=1775614551; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3Uw2pDdKT9JmHwVD0L4gy84rrNNbsjzW+xaZmRss5aQ=; b=dlUaXfcekhkYIa3+H9UJjCLf6JoD4P9LMtLP39AwuewCGJfUnuQswLQxm2U4wmkc5P WJNNOV8AMZN8ezWmuO9Ou3DwW/25LjpvgW2zJN3Z5PdvpAOnrA/BxKeU0Hh7OhF8cnfV u31Ik2KnXfbDAPMPcLkH05ePFn4hHIMkjKUWd/05Qtr2ZD8BLMfnd84069DE5edAph/O yI6qeXLNJbEzWDp8NcWKcNjoX0/nVObknjtEbeiTvWI4jPo0BE7JE5Vl3HXf0Pmnz6PQ Vmx/IFU5YYW6gAkqYAG1l5xc3o7gC4sSCKR8Y3jiiQFrtd3/V94sEOG46SaUtTZNUVjd kgbA== X-Forwarded-Encrypted: i=1; AJvYcCU/BUHJDHbe8tSvF0sqj8+qS699QFQyF/sAJm6omJ/pVvFc/H0sZhoa9au1stRVoR33xiFuli04ToJ0tr9l@lists.postgresql.org X-Gm-Message-State: AOJu0YwcO62CQFy+Sgv/Qbb66G0p8ah7PPRfESp8xtylGvtsu/1sUjlD b72b3LyJagFovkBNM/ZuGcSlfKAkjENJqp1iquAAbPz1bdPbX//ECj1WEV15edhFMSqd4T2BMc1 ErlMCGiuVUpkyURVemaQAY2aMZhE1IIc= X-Gm-Gg: ATEYQzyxjjtX/9arFji/Us+tMekDd72xHbZMPhLViCj4bBjSyE9GrpO9KlVh6U6QSs1 cowldraQiil2Wl3Mz6wJaqREPyWdtlzeNFGdeliJKdWCY+AyztXzUNvz+68gKaxydA9PhlLYW6F 7XakNTOgtsKWQhcAjognBbp6LWxkZumx8bLW62me7NIL4bQlgOkf2LliOlgF2qWDbF9ZkqjLUlR yDDWL7pO0DTgj4zr5TkIGj3rw+jPzjgofiu83Lugjvo7Ymd+kTTJqAVO9qsyIysHDzplnqxmXuw xoTvth7jEctSUo7Yv2OtWEPF7tXQFey+hhVkSWrVrw== X-Received: by 2002:a2e:b892:0:b0:38b:f0f0:e3c0 with SMTP id 38308e7fff4ca-38cc2f4631dmr4348211fa.9.1775009750475; Tue, 31 Mar 2026 19:15:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Amit Kapila Date: Wed, 1 Apr 2026 07:45:38 +0530 X-Gm-Features: AQROBzAminU6PCad41S41JKn_UdqLBBiXPIrajPxLHhsxiJBh0N7LscV8yqjIc8 Message-ID: Subject: Re: Skipping schema changes in publication To: Peter Smith Cc: vignesh C , Shlok Kyal , Dilip Kumar , shveta malik , Masahiko Sawada , "Hayato Kuroda (Fujitsu)" , Nisha Moond , Ashutosh Sharma , "David G. Johnston" , "Zhijie Hou (Fujitsu)" , YeXiu <1518981153@qq.com>, Ian Lawrence Barwick , Bharath Rupireddy , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Apr 1, 2026 at 6:13=E2=80=AFAM Peter Smith = wrote: > > On Tue, Mar 31, 2026 at 8:30=E2=80=AFPM vignesh C w= rote: > > > ... > > > > Thanks for the comments. This is addressed in the 002 patch attached. > > The 001 patch has the rebased version of the patch at [1] to fix > > Peter's earlier comments at [2]. > > > > [1] - https://www.postgresql.org/message-id/CALDaNm0mYT55pjdyN-yY%3D5dS= OfMVx307CtP3xYqzWVa0MPRtLQ%40mail.gmail.com > > [2] - https://www.postgresql.org/message-id/CAHut%2BPvw-XNBnW-ymGdWpLxa= Eime7_EdOihcUheGyZvw73kcgg%40mail.gmail.com > > > > Hi Vignesh. > > Thanks for following up on my outstanding review comments. > > ////// > Patch 0001 - Fix few issues in commit fd366065e0 > > This did not address the review comment 3a about the redundant macro > '_("\"%s\"")', but that one might be better handled in a separate > thread anyway. I can post a separate thread for that one later. > Yes, as it uses an existing code as an example, it is better to start a separate thread. I was planning to do some research by myself after finishing the pending tasks here but feel free to start if you have formed your thoughts on it. --=20 With Regards, Amit Kapila.