MIME-Version: 1.0
References: <CACawEhVQC9WoofunvXg12aXtbqKnEgWxoRx3+v8q32AWYsdpGg@mail.gmail.com>
 <OSZPR01MB6310CE109F65A9B62A25CE1EFDB99@OSZPR01MB6310.jpnprd01.prod.outlook.com>
 <CACawEhUCg-tRGzRqRq+qHaR+kPdZ=N1fP=A4_cCYd0LuNLUgnA@mail.gmail.com>
 <CAA4eK1+ZXLQLCKOwEzvpCJ2XXapANY66S773zMbqbUL_7LBUiQ@mail.gmail.com>
 <OSZPR01MB6310A7627F4587CB5547086AFDBC9@OSZPR01MB6310.jpnprd01.prod.outlook.com>
 <CACawEhVCoCj5n1LUWBd12gd1S9ONkB3jf7fw5kK5njA==1X3rg@mail.gmail.com>
In-Reply-To: <CACawEhVCoCj5n1LUWBd12gd1S9ONkB3jf7fw5kK5njA==1X3rg@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Fri, 17 Mar 2023 05:38:50 +0530
Message-ID: <CAA4eK1LLsHLnq9F62brVV3EfA7oqStJoQ6ki89Jy1UHBMRrYVA@mail.gmail.com>
Subject: Re: Dropped and generated columns might cause wrong data on subs when
 REPLICA IDENTITY FULL
To: =?UTF-8?B?w5ZuZGVyIEthbGFjxLE=?= <onderkalaci@gmail.com>
Cc: "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAA4eK1LLsHLnq9F62brVV3EfA7oqStJoQ6ki89Jy1UHBMRrYVA%40mail.gmail.com>
Precedence: bulk

On Thu, Mar 16, 2023 at 9:33=E2=80=AFPM =C3=96nder Kalac=C4=B1 <onderkalaci=
@gmail.com> wrote:
>
> Hi Amit, Shi Yu,
>
> > Generated column is introduced in PG12, and I reproduced generated colu=
mn problem
> in PG12~PG15.
> > For dropped column problem, I reproduced it in PG10~PG15. (Logical repl=
ication
> was introduced in PG10)
>
> So, I'm planning to split the changes into two commits. The first one fix=
es
> for dropped columns, and the second one adds generated columns check/test=
.
>
> Is that the right approach for such a case?
>

Works for me.

> >  and backpatch the fix for dropped column to PG10.
>
> Still, even the first commit fails to apply cleanly to PG12 (and below).
>
> What is the procedure here? Should I be creating multiple patches per ver=
sion?
>

You can first submit the fix for dropped columns with patches till
v10. Once that is committed, then you can send the patches for
generated columns.

> Or does the committer prefer to handle the conflicts? Depending on your r=
eply,
> I can work on the followup.
>

Thanks for working on it.

--=20
With Regards,
Amit Kapila.