Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pWYW3-0000rR-4u for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Feb 2023 08:05:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pWYW2-00011Q-1R for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Feb 2023 08:05:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pWYW1-00011H-MK for pgsql-hackers@lists.postgresql.org; Mon, 27 Feb 2023 08:05:45 +0000 Received: from mail-oa1-x2a.google.com ([2001:4860:4864:20::2a]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pWYVz-0005vz-D8 for pgsql-hackers@lists.postgresql.org; Mon, 27 Feb 2023 08:05:45 +0000 Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-172afa7bee2so6615738fac.6 for ; Mon, 27 Feb 2023 00:05:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qEF5UHijvIvX3nb0BKrQPE4/HObKpUJxGjMZbzYnRhQ=; b=eMyqOD9YgDmMGBHjtfzELHBn5OXM1EIk66Zdeasp3JYs9LCuemtQ8VdpettpEu7whs l7hCId7XSLBaWDpu+zT/mmzqIg1F7T7cKmDjedYszSLmACYCgeD0eXT9fcMXiaVcCDrr KAvSVHGSiRAM3G/SvlSFtossbpkBpNN3bkeGEErZDPEg3L8qq6/VWYQRky6BZyuhWRGh d1zZbrdQYkNmPgfx0wwfF0hSa6MmHXuMrQZr+KKPT9OJSkjaaIVx1EbCZA4rjU/6tPU4 jD0aRTOKfAPhziz/mvZyQKArc/8nSUWgfeWgifjt2kHvAtdTUqBPk5ux+A3tcReC+AlW Qd/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qEF5UHijvIvX3nb0BKrQPE4/HObKpUJxGjMZbzYnRhQ=; b=C8ckDelyibMpX3nRbHhblAwm1sRd+BaDKBxXy2f2Uh5/2Bl0WI5Y2vd69nRZGUl1Yt hs5ZR8J95f1PMZ8wghix/emwEFBAEspaqnF1BFqvMsbTDUb7FQwTFRP/ihW8NH10pqon 6p3HtMi+GBz1/rpQBKyjkMkcsDD1Iy5sctfO6+0UOU6J0QnB/97GE3ei8pHWfzwuIhVd a9CnXoMNKGzCWj51Fs+dOUu48knedp5zDJRf5OVMgIL3jEcU+bkuOLxZOyQ6x2RuKEBG ZTZ1YnEcG65/T+LHAkKV5oIynNQK3MQc61CKwu7jOtiY8bXyfW1tWIM1wcSoOTsWppt0 CdLg== X-Gm-Message-State: AO0yUKX0JhjuwHtu4IJFu6H+Lq4GTdrd7RSoMXT2SR2vAlq4mgvPYlZZ jCr+EzuK3hKfVy81FC8A4ddhGlJqmQU3txxPP452fpXK4DSkEQ== X-Google-Smtp-Source: AK7set9R2HLxrYqWH424+Y0A//GLvwRhZMuXCtFWwQYjvABP5XsYbGot1x6uv9R5OKlOUJammIgt94XKB0ZvDE7R9Eg= X-Received: by 2002:a05:6870:3494:b0:172:899b:9c93 with SMTP id n20-20020a056870349400b00172899b9c93mr3210060oah.10.1677485141259; Mon, 27 Feb 2023 00:05:41 -0800 (PST) MIME-Version: 1.0 References: <20221206184756.2fdpd4epvyftutoe@awork3.anarazel.de> <3466340.1673117404@sss.pgh.pa.us> <20230109200347.ps43ri7llrxusgu5@awork3.anarazel.de> <4184492.1673296630@sss.pgh.pa.us> In-Reply-To: From: Amit Kapila Date: Mon, 27 Feb 2023 13:35:29 +0530 Message-ID: Subject: Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher To: =?UTF-8?B?w5ZuZGVyIEthbGFjxLE=?= Cc: "shiy.fnst@fujitsu.com" , Marco Slot , Tom Lane , Andres Freund , "wangw.fnst@fujitsu.com" , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Feb 27, 2023 at 12:35=E2=80=AFPM =C3=96nder Kalac=C4=B1 wrote: > > >> Wouldn't a table-level option like 'apply_index_scan' be better than a >> subscription-level option with a default value as false? Anyway, the >> bigger point is that we don't see a better way to proceed here than to >> introduce some option to control this behavior. > > > What would be a good API for adding such an option for table-level? > To be more specific, I cannot see any table level sub/pub options in the = docs. > I was thinking something along the lines of "Storage Parameters" [1] for a table. See parameters like autovacuum_enabled that decide the autovacuum behavior for a table. These can be set via CREATE/ALTER TABLE commands. [1] - https://www.postgresql.org/docs/devel/sql-createtable.html#SQL-CREATE= TABLE-STORAGE-PARAMETERS --=20 With Regards, Amit Kapila.