MIME-Version: 1.0
References: <CAHut+Pu=pnJf=SS1583pknSQ3CbOqLCkWcJCQYt6zxTagHEdmw@mail.gmail.com>
 <CAA4eK1Kq3TX1bkDSHxJ9tYQA1ooVfHgG1+5G1EoAQKWAdPNyPQ@mail.gmail.com> <CAD21AoA6o_TpyUwX4xh8C9orG+b+-cCHQ41EDP-EUeWeN-MikA@mail.gmail.com>
In-Reply-To: <CAD21AoA6o_TpyUwX4xh8C9orG+b+-cCHQ41EDP-EUeWeN-MikA@mail.gmail.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Fri, 7 Apr 2023 14:40:36 +0530
Message-ID: <CAA4eK1LPmOnLuBeKnmYGtOHHTBqCTD1ZLvBvgN6CL7sTu5KHdA@mail.gmail.com>
Subject: Re: CREATE SUBSCRIPTION -- add missing tab-completes
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAA4eK1LPmOnLuBeKnmYGtOHHTBqCTD1ZLvBvgN6CL7sTu5KHdA%40mail.gmail.com>
Precedence: bulk

On Fri, Apr 7, 2023 at 1:12=E2=80=AFPM Masahiko Sawada <sawada.mshk@gmail.c=
om> wrote:
>
> On Fri, Apr 7, 2023 at 2:28=E2=80=AFPM Amit Kapila <amit.kapila16@gmail.c=
om> wrote:
> >
> > On Wed, Apr 5, 2023 at 5:58=E2=80=AFAM Peter Smith <smithpb2250@gmail.c=
om> wrote:
> > >
> >
> > LGTM, so pushed. BTW, while looking at this, I noticed that newly
> > added options "password_required" and "run_as_owner" has incorrectly
> > mentioned their datatype as a string in the docs. It should be
> > boolean.
>
> +1
>
> > I think "password_required" belongs to first section of docs
> > which says: "The following parameters control what happens during
> > subscription creation".
>
> But the documentation of ALTER SUBSCRIPTION says:
>
> The parameters that can be altered are slot_name, synchronous_commit,
> binary, streaming, disable_on_error, password_required, run_as_owner,
> and origin. Only a superuser can set password_required =3D false.
>

By the above, do you intend to say that all the parameters that can be
altered are in the second list? If so, slot_name belongs to the first
category.

> ISTM that both password_required and run_as_owner are parameters to
> control the subscription's behavior, like disable_on_error and
> streaming. So it looks good to me that password_required belongs to
> the second section.
>

Do you mean that because 'password_required' is used each time we make
a connection to a publisher during replication, it should be in the
second category? If so, slot_name is also used during the start
replication each time.

BTW, do we need to check one or both of these parameters in
maybe_reread_subscription() where we "Exit if any parameter that
affects the remote connection was changed."

--=20
With Regards,
Amit Kapila.