MIME-Version: 1.0
References: 
 <CAHut+PsYdTW4+U+fioh9_yO8iT6RnY=PquzfCZu7zRU6Qg6W7g@mail.gmail.com>
 <Zwy4ys76aPcoVE/I@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAD21AoDuO87MFrPJFwtmRi=cFhDGac0zq7sq5pdEhVi7zUvbEg@mail.gmail.com>
 <5qbxud4pvnvmtuoi7weiizm5hmumxaeohx4vztfhrwlfhyz6rj@buh4435mllwo>
 <CAD21AoBM6vAcPGR-ng0nqGG0yemR_ufdg3+v3gkPa6Nc2ntnrA@mail.gmail.com>
 <Z8f6dQPR67ahM2DN@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAA4eK1L0bZbZOr8-VNFXDfqaTwggdf_-HTAsneui+_ozMTvZQg@mail.gmail.com>
 <Z8g9/GeoXv/gIL60@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAD21AoBkdiq6Te7D_LtKDDB2WsZWBKWqWNVguhy9R_xAMf_xDg@mail.gmail.com>
 <CAA4eK1LGV8PME4KfZanF16gE1HDb+nPn06TTxv1OtV0466oJ-w@mail.gmail.com>
 <Z8rNiT6H2/Mdb60v@ip-10-97-1-34.eu-west-3.compute.internal>
In-Reply-To: <Z8rNiT6H2/Mdb60v@ip-10-97-1-34.eu-west-3.compute.internal>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Fri, 7 Mar 2025 17:44:00 +0530
Message-ID: 
 <CAA4eK1Lbma+Gve+zV_Vt801a4ot-zvnmABLrfxbxQCdAxvDN7Q@mail.gmail.com>
Subject: Re: Add contrib/pg_logicalsnapinspect
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>,
 Andres Freund <andres@anarazel.de>,
	Peter Smith <smithpb2250@gmail.com>, Peter Eisentraut <peter@eisentraut.org>,
	shveta malik <shveta.malik@gmail.com>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
 pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAA4eK1Lbma%2BGve%2BzV_Vt801a4ot-zvnmABLrfxbxQCdAxvDN7Q%40mail.gmail.com>
Precedence: bulk

On Fri, Mar 7, 2025 at 4:12=E2=80=AFPM Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
>
> On Fri, Mar 07, 2025 at 10:26:23AM +0530, Amit Kapila wrote:
>
> > Your proposed change in the test sounds better than what we have now
> > but I think we should also avoid autovacuum to perform analyze as that
> > may add additional counts. For test_decoding, we keep
> > autovacuum_naptime =3D 1d in logical.conf file, we can either use the
> > same here or simply keep autovacuum off.
>
> When writing the attached, I initially added extra paranoia in the tests =
by
> using ">=3D", does that also address your autovacuum concern?
>

Yes, that will address the autovacuum concern.

--=20
With Regards,
Amit Kapila.