MIME-Version: 1.0
References: 
 <CAFPTHDbsZ+pxAubb9d9BwVNt5OB3_2s77bG6nHcAgUPPhEVmMQ@mail.gmail.com>
 <CAJpy0uBqS_HD30mBR0yD1SVCvUZDrw1=dwn1xH8ANEQw7gnPdw@mail.gmail.com>
 <CAA4eK1Lxvfq9RwOEsguiMCrKPUc1He9UGz1_wi0N0cJaXFa4Eg@mail.gmail.com>
 <OS0PR01MB5716E304C26E6ACE0BE84925947A2@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <ZbIT9Kj3d8TFD8h6@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAA4eK1K0jRXa2AhKXRVDY+Y42MG4RTbfAEcTBEGN2ov=Yjco+A@mail.gmail.com>
 <OS0PR01MB571623B1D01003F99A7BB983947A2@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAA4eK1+3jV839U3+DGgHrgrhtDguaVwAyb0Hucz9UbpjjVL=Sg@mail.gmail.com>
 <OS0PR01MB5716DE2A364CB23F9144AED194782@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAJpy0uBX2tyF4bQn-rd8zqoVLr+j53uWp+fh3qbLfXwCnKed4A@mail.gmail.com>
 <ZbdnPrB8XOJU6z2p@ip-10-97-1-34.eu-west-3.compute.internal>
In-Reply-To: <ZbdnPrB8XOJU6z2p@ip-10-97-1-34.eu-west-3.compute.internal>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Mon, 29 Jan 2024 14:35:52 +0530
Message-ID: 
 <CAA4eK1LumO2+A7RLkEW2ViA_KkgYpDgv9BbqSNGu0w3osanH4g@mail.gmail.com>
Subject: Re: Synchronizing slots from primary to standby
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: shveta malik <shveta.malik@gmail.com>,
 "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>,
	Ajin Cherian <itsajin@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>,
	Dilip Kumar <dilipbalaut@gmail.com>, Peter Smith <smithpb2250@gmail.com>,
	Nisha Moond <nisha.moond412@gmail.com>,
	"Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
 Bruce Momjian <bruce@momjian.us>,
	Ashutosh Sharma <ashu.coek88@gmail.com>, Andres Freund <andres@anarazel.de>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAA4eK1LumO2%2BA7RLkEW2ViA_KkgYpDgv9BbqSNGu0w3osanH4g%40mail.gmail.com>
Precedence: bulk

On Mon, Jan 29, 2024 at 2:22=E2=80=AFPM Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
>
> On Mon, Jan 29, 2024 at 10:24:11AM +0530, shveta malik wrote:
> > On Sat, Jan 27, 2024 at 12:02=E2=80=AFPM Zhijie Hou (Fujitsu)
> > <houzj.fnst@fujitsu.com> wrote:
> > >
> > > Attach the V70 patch set which addressed above comments and Bertrand'=
s comments in [1]
> > >
> >
> > Since v70-0001 is pushed, rebased and attached v70_2 patches.  There
> > are no new changes.
>
> Thanks!
>
> Looking at 0001:
>
> +      When altering the
> +      <link linkend=3D"sql-createsubscription-params-with-slot-name"><li=
teral>slot_name</literal></link>,
> +      the <literal>failover</literal> property value of the named slot m=
ay differ from the
> +      <link linkend=3D"sql-createsubscription-params-with-failover"><lit=
eral>failover</literal></link>
> +      parameter specified in the subscription. When creating the slot,
> +      ensure the slot <literal>failover</literal> property matches the
> +      <link linkend=3D"sql-createsubscription-params-with-failover"><lit=
eral>failover</literal></link>
> +      parameter value of the subscription. Otherwise, the slot on the pu=
blisher may
> +      not be enabled to be synced to standbys.
>
> Not related to this patch series but while at it shouldn't we also add a =
few
> words about two_phase too? (I mean ensure the slot property matchs the
> subscription one).
>
> Or would it be better to create a dedicated patch (outside of this thread=
) for
> the "two_phase" remark? (If so I can take care of it).
>

I think it is better to create a separate patch for two_phase after
this patch gets committed.

--=20
With Regards,
Amit Kapila.