MIME-Version: 1.0
References: 
 <CALDaNm2VghC-CSyS6jwyMMcpwSWjQ09t9AkkL0Sz7dsb1VGF3A@mail.gmail.com>
 <CAJpy0uAX90WXUY4LDJfmKs4bWPn-OzFYi6grXJYh-Fdagb2w_w@mail.gmail.com>
 <TYRPR01MB1419559BE4B38E6EF24EF84BA942D2@TYRPR01MB14195.jpnprd01.prod.outlook.com>
In-Reply-To: 
 <TYRPR01MB1419559BE4B38E6EF24EF84BA942D2@TYRPR01MB14195.jpnprd01.prod.outlook.com>
From: Amit Kapila <amit.kapila16@gmail.com>
Date: Wed, 22 Apr 2026 17:02:01 +0530
Message-ID: 
 <CAA4eK1LvFapjAoDuFmpNi3yjiydk_K5d_QHK=gbiDJNqJOU=2A@mail.gmail.com>
Subject: Re: Skipping schema changes in publication
To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Cc: shveta malik <shveta.malik@gmail.com>, vignesh C <vignesh21@gmail.com>,
	Peter Smith <smithpb2250@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>,
	Dilip Kumar <dilipbalaut@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>,
	"Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
 Nisha Moond <nisha.moond412@gmail.com>,
	Ashutosh Sharma <ashu.coek88@gmail.com>,
 "David G. Johnston" <david.g.johnston@gmail.com>,
	YeXiu <1518981153@qq.com>, Ian Lawrence Barwick <barwick@gmail.com>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAA4eK1LvFapjAoDuFmpNi3yjiydk_K5d_QHK%3DgbiDJNqJOU%3D2A%40mail.gmail.com>
Precedence: bulk

On Wed, Apr 22, 2026 at 3:33=E2=80=AFPM Zhijie Hou (Fujitsu)
<houzj.fnst@fujitsu.com> wrote:
>
> On Wednesday, April 22, 2026 5:54 PM shveta malik <shveta.malik@gmail.com=
> wrote:
> > On Mon, Apr 20, 2026 at 5:43=E2=80=AFPM vignesh C <vignesh21@gmail.com>=
 wrote:
> > >
> > > Hi,
> > >
> > > When changing a table to UNLOGGED, tables that appear in publications
> > > via EXCEPT clauses (prexcept =3D true) are currently allowed, but the=
ir
> > > entries remain in pg_publication_rel.
> > >
> > > For example:
> > > postgres=3D# create table t1(c1 int);
> > > CREATE TABLE
> > > postgres=3D# create publication pub1 for all tables except (table t1)=
;
> > > CREATE PUBLICATION postgres=3D# alter table t1 set unlogged; ALTER TA=
BLE
> > > postgres=3D# \d t1
> > >             Unlogged table "public.t1"
> > >  Column |  Type   | Collation | Nullable | Default
> > > --------+---------+-----------+----------+---------
> > >  c1     | integer |           |          |
> > > Except publications:
> > >     "pub1"
> > >
> > > Since UNLOGGED tables are not supported in publications, this leaves
> > > stale catalog entries. This patch removes such entries from
> > > pg_publication_rel when the table is changed to UNLOGGED, and emits a
> > > NOTICE to inform the user.
> > >
> > > Another option considered was to throw an error when setting such
> > > tables to UNLOGGED. However, allowing the operation was preferred,
> > > since UNLOGGED tables do not generate WAL and are not replicated
> > > anyway, so blocking the operation would be unnecessarily restrictive.
> > >
> > > Attached patch has the changes for the same.
> > >
> >
> > The main concern of removal table form EXCEPT-list is that once the tab=
le is
> > changed back to LOGGED, there is no internal way to add it to the EXCEP=
T list
> > again.
> >
> > OTOH, raising an ERROR does not seem like a good solution either. When =
a
> > user converts a table to UNLOGGED, they are effectively excluding it fr=
om
> > publications. Therefore, throwing an error for the purpose that "table =
is part
> > of EXCEPT, cannot convert it to UNLOGGED" does not appear appropriate,
> > since both actions ultimately exclude the table from publication. I thi=
nk we
> > can keep the current behavior unchanged as it causes no harm.
>
> I also personally prefer keeping the current behavior, as there is no har=
m in
> doing so, and I'm not sure whether reporting one more ERROR would make us=
ers
> happy.
>

+1.

--=20
With Regards,
Amit Kapila.