MIME-Version: 1.0
References: <47aaf57e-1b7b-4e12-bda2-0316081ff50e@iki.fi>
 <acVEqGemyK-Yjswa@nathan>
 <adab98a3-a0e3-4455-9b63-ae6f1ecd18c9@iki.fi>
 <CAA5RZ0ueB84OUews-mS0+ojeWaDtcoV1qY4CNZD8PrdGcaXW-g@mail.gmail.com>
 <d78edccb-27c0-4c9c-baee-1ce7745c8cc4@iki.fi>
 <0ba6cb8c-a893-4445-b8fa-fa9f52be8f39@iki.fi>
 <CAA5RZ0s+-_d6RBSfmLvekGLTCi2EZ7hiHp3RhMVDEexGXq=7Vg@mail.gmail.com>
In-Reply-To: 
 <CAA5RZ0s+-_d6RBSfmLvekGLTCi2EZ7hiHp3RhMVDEexGXq=7Vg@mail.gmail.com>
From: Sami Imseih <samimseih@gmail.com>
Date: Thu, 26 Mar 2026 23:49:11 -0500
Message-ID: 
 <CAA5RZ0sLENRM+BicUjQFs_rP38oPx3gm0SsGrD0-jMhhM+HZ_w@mail.gmail.com>
Subject: Re: Clean up NamedLWLockTranche stuff
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
 Robert Haas <robertmhaas@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000094a267064dfa3932"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA5RZ0sLENRM%2BBicUjQFs_rP38oPx3gm0SsGrD0-jMhhM%2BHZ_w%40mail.gmail.com>
Precedence: bulk

--00000000000094a267064dfa3932
Content-Type: text/plain; charset="UTF-8"

> +/* backend-local copy of NamedLWLockTranches->num_user_defined */
> +static int  LocalNumUserDefinedTranches;

> The comment here should reference "LWLockTranches->num_user_defined "
> instead.

> Also, there are a few places in lwlock.c where "named tranches" is mentioned.
> Maybe we should just say "user-defined tranches" instead?

Like the attached.

--
Sami

--00000000000094a267064dfa3932
Content-Type: application/octet-stream;
	name="v1-0001-fix-some-comments-for-lwlock-tranches.patch"
Content-Disposition: attachment;
	filename="v1-0001-fix-some-comments-for-lwlock-tranches.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mn8f8on40>
X-Attachment-Id: f_mn8f8on40

RnJvbSAzZjgwNTNhZGRlMGRhMmM5OWZkMWUwMmY0NjRhNzI0N2M3M2YwODg3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTYW1pIEltc2VpaCA8c2FtaW1zZWloQGdtYWlsLmNvbT4KRGF0
ZTogRnJpLCAyNyBNYXIgMjAyNiAwNDo0Njo1NSArMDAwMApTdWJqZWN0OiBbUEFUQ0ggdjEgMS8x
XSBmaXggc29tZSBjb21tZW50cyBmb3IgbHdsb2NrIHRyYW5jaGVzCgotLS0KIHNyYy9iYWNrZW5k
L3N0b3JhZ2UvbG1nci9sd2xvY2suYyB8IDExICsrKysrKy0tLS0tCiAxIGZpbGUgY2hhbmdlZCwg
NiBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5k
L3N0b3JhZ2UvbG1nci9sd2xvY2suYyBiL3NyYy9iYWNrZW5kL3N0b3JhZ2UvbG1nci9sd2xvY2su
YwppbmRleCAyNDFmMWYwODQzMC4uMmVlMzg1Njk4ZTUgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5k
L3N0b3JhZ2UvbG1nci9sd2xvY2suYworKysgYi9zcmMvYmFja2VuZC9zdG9yYWdlL2xtZ3IvbHds
b2NrLmMKQEAgLTIwMCw3ICsyMDAsNyBAQCB0eXBlZGVmIHN0cnVjdCBMV0xvY2tUcmFuY2hlU2ht
ZW1EYXRhCiAKIHN0YXRpYyBMV0xvY2tUcmFuY2hlU2htZW1EYXRhICpMV0xvY2tUcmFuY2hlczsK
IAotLyogYmFja2VuZC1sb2NhbCBjb3B5IG9mIE5hbWVkTFdMb2NrVHJhbmNoZXMtPm51bV91c2Vy
X2RlZmluZWQgKi8KKy8qIGJhY2tlbmQtbG9jYWwgY29weSBvZiBMV0xvY2tUcmFuY2hlcy0+bnVt
X3VzZXJfZGVmaW5lZCAqLwogc3RhdGljIGludAlMb2NhbE51bVVzZXJEZWZpbmVkVHJhbmNoZXM7
CiAKIC8qCkBAIC00NjAsNyArNDYwLDcgQEAgTFdMb2NrU2htZW1Jbml0KHZvaWQpCiB9CiAKIC8q
Ci0gKiBJbml0aWFsaXplIExXTG9ja3MgdGhhdCBhcmUgZml4ZWQgYW5kIHRob3NlIGJlbG9uZ2lu
ZyB0byBuYW1lZCB0cmFuY2hlcy4KKyAqIEluaXRpYWxpemUgTFdMb2NrcyB0aGF0IGFyZSBmaXhl
ZCBhbmQgdGhvc2UgYmVsb25naW5nIHRvIHVzZXItZGVmaW5lZCB0cmFuY2hlcy4KICAqLwogc3Rh
dGljIHZvaWQKIEluaXRpYWxpemVMV0xvY2tzKGludCBudW1Mb2NrcykKQEAgLTQ4Nyw3ICs0ODcs
NyBAQCBJbml0aWFsaXplTFdMb2NrcyhpbnQgbnVtTG9ja3MpCiAJCUxXTG9ja0luaXRpYWxpemUo
Jk1haW5MV0xvY2tBcnJheVtwb3MrK10ubG9jaywgTFdUUkFOQ0hFX1BSRURJQ0FURV9MT0NLX01B
TkFHRVIpOwogCiAJLyoKLQkgKiBDb3B5IHRoZSBpbmZvIGFib3V0IGFueSBuYW1lZCB0cmFuY2hl
cyBpbnRvIHNoYXJlZCBtZW1vcnkgKHNvIHRoYXQKKwkgKiBDb3B5IHRoZSBpbmZvIGFib3V0IGFu
eSB1c2VyLWRlZmluZWQgdHJhbmNoZXMgaW50byBzaGFyZWQgbWVtb3J5IChzbyB0aGF0CiAJICog
b3RoZXIgcHJvY2Vzc2VzIGNhbiBzZWUgaXQpLCBhbmQgaW5pdGlhbGl6ZSB0aGUgcmVxdWVzdGVk
IExXTG9ja3MuCiAJICovCiAJQXNzZXJ0KHBvcyA9PSBOVU1fRklYRURfTFdMT0NLUyk7CkBAIC01
MzYsOCArNTM2LDkgQEAgR2V0TmFtZWRMV0xvY2tUcmFuY2hlKGNvbnN0IGNoYXIgKnRyYW5jaGVf
bmFtZSkKIAogCS8qCiAJICogT2J0YWluIHRoZSBwb3NpdGlvbiBvZiBiYXNlIGFkZHJlc3Mgb2Yg
TFdMb2NrIGJlbG9uZ2luZyB0byByZXF1ZXN0ZWQKLQkgKiB0cmFuY2hlX25hbWUgaW4gTWFpbkxX
TG9ja0FycmF5LiAgTFdMb2NrcyBmb3IgbmFtZWQgdHJhbmNoZXMgYXJlIHBsYWNlZAotCSAqIGlu
IE1haW5MV0xvY2tBcnJheSBhZnRlciBmaXhlZCBsb2Nrcy4KKwkgKiB0cmFuY2hlX25hbWUgaW4g
TWFpbkxXTG9ja0FycmF5LiAgTFdMb2NrcyBmb3IgdXNlci1kZWZpbmVkIHRyYW5jaGVzCisJICog
cmVxdWVzdGVkIHdpdGggUmVxdWVzdE5hbWVkTFdMb2NrVHJhbmNoZSgpIGFyZSBwbGFjZWQgaW4K
KwkgKiBNYWluTFdMb2NrQXJyYXkgYWZ0ZXIgZml4ZWQgbG9ja3MuCiAJICovCiAJZm9yIChpbnQg
aSA9IDA7IGkgPCBMb2NhbE51bVVzZXJEZWZpbmVkVHJhbmNoZXM7IGkrKykKIAl7Ci0tIAoyLjQ3
LjMKCg==
--00000000000094a267064dfa3932--