MIME-Version: 1.0
References: 
 <CAGnOmWqi1D9ycBgUeOGf6mOCd2Dcf=6sKhbf4sHLs5xAcKVCMQ@mail.gmail.com>
 <CABXr29GbJe7-vbm0Fn=HWx3vQonwFtv_zO1pSc5FZAvjLuUDVA@mail.gmail.com>
 <CABXr29Epj=23eYAWg_mTdiXYQQzJSVN22uk6tK8ei0ts5wXvSQ@mail.gmail.com>
 <CAA5RZ0s16eHrzcDupipAxC++e-p_n_M7Fpg-MG-V59fB=wykLw@mail.gmail.com>
 <ad1rubGPdHxNnDh5@paquier.xyz> <ad5l0sGiJwdkXI-L@paquier.xyz>
 <CAA5RZ0uM7_YPdSahGh1sGeewMb9SzKswyLaZty8aR+a7XpQydQ@mail.gmail.com>
 <aeVSPx7F3ghkZugb@paquier.xyz> <aegozMN-abH3ki-P@paquier.xyz>
In-Reply-To: <aegozMN-abH3ki-P@paquier.xyz>
From: Sami Imseih <samimseih@gmail.com>
Date: Wed, 22 Apr 2026 05:33:09 -0500
Message-ID: 
 <CAA5RZ0sQfnLyv2Ta-r6y==QwwUr+M0BxVbK0=0_HZZA1ywc3Bw@mail.gmail.com>
Subject: Re: [PATCH] Fix: Partitioned parent index remains invalid after child
 indexes are repaired
To: Michael Paquier <michael@paquier.xyz>
Cc: Haibo Yan <tristan.yim@gmail.com>, Mohamed ALi <moali.pg@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA5RZ0sQfnLyv2Ta-r6y%3D%3DQwwUr%2BM0BxVbK0%3D0_HZZA1ywc3Bw%40mail.gmail.com>
Precedence: bulk

> > One thing that I'm tempted to add is more scans to check indisvalid
> > across these commands, particularly after the individual ATTACH
> > PARTITION bits on each individual index.

That works.

> > A second thing.  Do you think that it would be worth adding a
> > partitioned table that has no leaves in some portion of the test?  I
> > was thinking about a partitioned table called idxpart2 attached to
> > idxpart in the first part of the test.  I've found this pattern
> > usually useful for this area of the code when recursing with
> > validatePartitionedIndex() from a parent.

Good idea.

> Both things have been added to the tests, and applied the result down
> to v14.  The patch was able to apply cleanly across the board, without
> conflicts.  That's rare, these days..

Sorry for the late reply, and thanks for getting this committed!

--
Sami Imseih
Amazon Web Services (AWS)