MIME-Version: 1.0
References: 
 <CA+fm-RMopta1Dmq8udiU5sp+zwTvhUf4+xfbr3rZDfczH+p-xw@mail.gmail.com>
 <DJ1FOVN3MWNT.1ZQ7NHQAVJPXY@partin.io>
 <CA+fm-RMwUuX7SimgfHZ1o3=RYWQT7wC+KC2+uAgbPqHij25mug@mail.gmail.com>
In-Reply-To: 
 <CA+fm-RMwUuX7SimgfHZ1o3=RYWQT7wC+KC2+uAgbPqHij25mug@mail.gmail.com>
From: Sami Imseih <samimseih@gmail.com>
Date: Sat, 6 Jun 2026 09:55:05 -0500
Message-ID: 
 <CAA5RZ0sb06bJecz1=0GtM69hO9HarCD_1+m0YOmyZ_PpEs_M6Q@mail.gmail.com>
Subject: Re: [PATCH] Fix memory leak in pgstat_progress_parallel_incr_param()
To: Baji Shaik <baji.pgdev@gmail.com>
Cc: Tristan Partin <tristan@partin.io>, bertranddrouvot.pg@gmail.com,
	pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA5RZ0sb06bJecz1%3D0GtM69hO9HarCD_1%2Bm0YOmyZ_PpEs_M6Q%40mail.gmail.com>
Precedence: bulk

Hi,

good find, and thanks for the patches!

>   0001: drop the redundant initStringInfo() call (backport candidate)

This one looks like an obvious fix to me.

>   0002: allocate the static buffer once per process via
>         pq_beginmessage_reuse / pq_endmessage_reuse, to avoid the
>         per-call allocation (master only)

I am less convinced this will have any benefits for the additional complexity.
The callers of pgstat_progress_parallel_incr_param() are not frequent enough
to make a measurable difference here. cost delay reporting for parallel workers
is throttled by PARALLEL_VACUUM_DELAY_REPORT_INTERVAL_NS and
index progress reporting does not happen very frequently either.

--
Sami Imseih
Amazon Web Services (AWS)