Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tfUGo-002lDW-Hf
	for pgsql-hackers@arkaria.postgresql.org; Wed, 05 Feb 2025 01:32:03 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tfUGn-00AUow-Ib
	for pgsql-hackers@arkaria.postgresql.org; Wed, 05 Feb 2025 01:32:01 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <samimseih@gmail.com>)
	id 1tfUGn-00AUoo-8o
	for pgsql-hackers@lists.postgresql.org; Wed, 05 Feb 2025 01:32:01 +0000
Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232])
	by magus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.96)
	(envelope-from <samimseih@gmail.com>)
	id 1tfUGk-003L3O-0K
	for pgsql-hackers@lists.postgresql.org;
	Wed, 05 Feb 2025 01:32:00 +0000
Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-30761be8fcfso60995671fa.0
        for <pgsql-hackers@lists.postgresql.org>; Tue, 04 Feb 2025 17:31:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1738719118; x=1739323918; darn=lists.postgresql.org;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=uLS9+fvhzfCc/bLi2tR6ht0XGXqjiaK8VHUjEf+BBDM=;
        b=JpeBxkcdjjPkrl7UBpzpyOPooNjK2E+lp1qjtcBlRwCagbeP8Ou86dzF/qon0IDDv7
         p2RDiO+Z5FJiyd7vPwJJbWtUtwVdrNbIUbLzhqJD+/uPTgpb8x183gKBvfc3KKB776VZ
         iwZwdxJRif5309bPd9g+n3Iv6SrojiHGuyH0GRGEC8+4PUFUZsI0cSuS61qfgtmDtHpE
         HyRT8ueb7hdPrCTPeJwVp2QVVusTRSZTUmINyxZIC+2RMkgl/K6gBtHJtCawhm4UjwKY
         gnLvLoAz9/WYqBzsdwIEGpvPMlsXpDYn7pjW2gqy0wenUgBPoqZszBaJsU5s5ESDg7xr
         d4oQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1738719118; x=1739323918;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=uLS9+fvhzfCc/bLi2tR6ht0XGXqjiaK8VHUjEf+BBDM=;
        b=w1tnCbrLpOXLYOADEL3mkuLMupjuZ4A7cNYr6ywY7HIdoZc2XQqcTLCKcewnbmse6K
         qeVnBcpguTNE49o2p2GQ2EVp3rMJbJ0EY2H/oO4VM3e/LL0ueKPet6Kf9a9bKdDrDkes
         b9tj852y3YfBd5ovnYggHMVeI/VeJ4hNkT4BaRbxXzVad/rtHI14QtRNcxyCdI23xVLx
         zGu3hrqbLI6080FV/ybdS+4UvWLb7UzdTQS+S1nyrXPuQsN5L5JwKhGUw/N3+77AULCG
         emjCHQPIZ/NL6Wyj4fHhq4gnjaPSI4UFW0/euOExGjXxyCeJNokfZlOKQx9F5WCs9awp
         Aaig==
X-Forwarded-Encrypted: i=1; AJvYcCWQUbxjSTj3M3/3k/dm6mFRuQkJI1UFUaxLBBqaaZImiUGlU5fHc8dWfvfo1FSlAGkqJ390V69eMDxRVqkS@lists.postgresql.org
X-Gm-Message-State: AOJu0YyzsPAKGKq/TQfarrwoFMXQktRimreKOKL8v4FeACPbc3TFd7vT
	FgWNwObk1GUemOTsguOiK8X1JY0LV4Su1UbEe0gavM9d2UZtdtEXTrec+WyJ8VlfntBZbBboL5q
	h5b2Q+/zqDoQ+M0b9FAWUDwT8p54=
X-Gm-Gg: ASbGncv4ZCxmP2hb7LSaZMIg7UvKoU0i1tZtpqx/vbXNMH6EsIUr8IcHu/CUIYpdc1B
	pLVRUr9QFNSnD3hrFQb9kWUzC6AYGvSwO27L533qn12jrvm1r9mnn6u8t/6GGScEIQiCIVG0=
X-Google-Smtp-Source: AGHT+IFO8QomtOjCfdOSGOu+yfgt/akQ3x6LIDDWbfDlHJOikYIb9ToQokNUQfgbreS4FIdPXrBkeFK4C5AV4Q2YU3M=
X-Received: by 2002:a2e:a584:0:b0:307:9648:65c3 with SMTP id
 38308e7fff4ca-307cf3145e0mr3011891fa.15.1738719117438; Tue, 04 Feb 2025
 17:31:57 -0800 (PST)
MIME-Version: 1.0
References: <CAP53Pkyow59ajFMHGpmb1BK9WHDypaWtUsS_5DoYUEfsa_Hktg@mail.gmail.com>
 <Z5A__Yuy23aXqUad@paquier.xyz> <CAA5RZ0sUPPOpkRZD=Za83op2ngcPC7dp249vcHA-X5YS7p3n8Q@mail.gmail.com>
 <CAP53PkwuFbo3NkwZgxwNRMjMfqPEqidD-SggaoQ4ijotBVLJAA@mail.gmail.com>
 <Z5cDQJM9nnoXuStO@paquier.xyz> <Z5xTb5iBHVGns35R@paquier.xyz>
 <CAP53Pkw1QJHH9UDjkArS=XdAxtK7XWMpZLGHnVMDmhRTp_HYYw@mail.gmail.com>
 <Z5xgmgyV-wnzMpkO@paquier.xyz> <CAA5RZ0vM9AsEqvKued2drKZJ1opt3wbYaDbxGzi-khkNzwn7og@mail.gmail.com>
 <Z6Ks3ta5089DXiPc@paquier.xyz>
In-Reply-To: <Z6Ks3ta5089DXiPc@paquier.xyz>
From: Sami Imseih <samimseih@gmail.com>
Date: Tue, 4 Feb 2025 19:31:46 -0600
X-Gm-Features: AWEUYZmb47DhVQyqSrFvtWYr0rtrkzbN-WWb25mYVDlJxxITbq3UvGceet7UgqA
Message-ID: <CAA5RZ0sfRbd1xcq_oHNA0TPr57yM8qkg-GoD6A0nUfyxZhs33Q@mail.gmail.com>
Subject: Re: [PATCH] Optionally record Plan IDs to track plan changes for a query
To: Michael Paquier <michael@paquier.xyz>
Cc: Lukas Fittl <lukas@fittl.com>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Marko M <marko@pganalyze.com>
Content-Type: text/plain; charset="UTF-8"
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/CAA5RZ0sfRbd1xcq_oHNA0TPr57yM8qkg-GoD6A0nUfyxZhs33Q%40mail.gmail.com>
Precedence: bulk

>> I can work on this if you agree.

> I'd welcome an extra patch to rework a bit the format of the comments
> for the Plan nodes, to ease the addition of pg_node_attr(), making any
> proposed patches more readable.

I'll take care of this also.

Regards,

Sami