MIME-Version: 1.0
From: Sami Imseih <samimseih@gmail.com>
Date: Thu, 12 Mar 2026 15:16:29 -0500
Message-ID: 
 <CAA5RZ0sieVNfniCKMDdDjuXGd1OuzMQfTS5=9vX3sa-iiujKUA@mail.gmail.com>
Subject: pg_plan_advice: rtekind uninitialized compilation waning
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000003fba45064cd96ed1"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA5RZ0sieVNfniCKMDdDjuXGd1OuzMQfTS5%3D9vX3sa-iiujKUA%40mail.gmail.com>
Precedence: bulk

--0000000000003fba45064cd96ed1
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

I just noticed $SUBJECT due to 5883ff30b0

[1/2] Compiling C object
contrib/pg_plan_advice/pg_plan_advice.so.p/pgpa_scan.c.o
In file included from ../src/include/postgres.h:49:0,
                 from ../contrib/pg_plan_advice/pgpa_scan.c:12:
../contrib/pg_plan_advice/pgpa_scan.c: In function =E2=80=98unique_nonjoin_=
rtekind=E2=80=99:
../src/include/utils/elog.h:241:18: warning: =E2=80=98rtekind=E2=80=99 may =
be used
uninitialized in this function [-Wmaybe-uninitialized]
  ereport(elevel, errmsg_internal(__VA_ARGS__))
                  ^~~~~~~~~~~~~~~
../contrib/pg_plan_advice/pgpa_scan.c:246:11: note: =E2=80=98rtekind=E2=80=
=99 was declared here
  RTEKind  rtekind;
           ^~~~~~~

Attached initializes rtekind to RTE_RELATION to keep the compiler happy.
The value is set correctly inside the loop before it's used.


--
Sami Imseih
Amazon Web Services (AWS)

--0000000000003fba45064cd96ed1
Content-Type: application/octet-stream;
	name="v1-0001-pg_plan_advice-Fix-compilation-waning.patch"
Content-Disposition: attachment;
	filename="v1-0001-pg_plan_advice-Fix-compilation-waning.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmnwqr0x0>
X-Attachment-Id: f_mmnwqr0x0

RnJvbSBmYTFmMTVmOWFiNmRkMzBjY2E0ZDc2NzI4OGEzNDIwYTQ2NDY3MDFiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiAiU2FtaSBJbXNlaWggKEFXUykiCiA8c2ltc2VpaEBkZXYtZHNr
LXNpbXNlaWgtMWUtZDMyZjI2N2UudXMtZWFzdC0xLmFtYXpvbi5jb20+CkRhdGU6IFRodSwgMTIg
TWFyIDIwMjYgMjA6MDE6MzQgKzAwMDAKU3ViamVjdDogW1BBVENIIHYxIDEvMV0gcGdfcGxhbl9h
ZHZpY2U6IEZpeCBjb21waWxhdGlvbiB3YW5pbmcKCjU4ODNmZjMwYjAgZGVjbGFyZWQgYW4gUlRF
S2luZCB2YXJpYWJsZQp1bmluaXRpYWxpemVkLiBJbml0aWFsaXplIGl0IHRvIFJURV9SRUxBVElP
TiB0bwpzdXBwcmVzcyB0aGUgY29tcGlsZXIgd2FybmluZywgYXMgaXQgd2lsbCBhbHdheXMKYmUg
c2V0IGNvcnJlY3RseSBpbiB0aGUgbG9vcCBiZWZvcmUgdXNlLgotLS0KIGNvbnRyaWIvcGdfcGxh
bl9hZHZpY2UvcGdwYV9zY2FuLmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24o
KyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9jb250cmliL3BnX3BsYW5fYWR2aWNlL3Bn
cGFfc2Nhbi5jIGIvY29udHJpYi9wZ19wbGFuX2FkdmljZS9wZ3BhX3NjYW4uYwppbmRleCAxNGJk
ZTNlMTQ5YS4uMDU0NzljNTM1YTkgMTAwNjQ0Ci0tLSBhL2NvbnRyaWIvcGdfcGxhbl9hZHZpY2Uv
cGdwYV9zY2FuLmMKKysrIGIvY29udHJpYi9wZ19wbGFuX2FkdmljZS9wZ3BhX3NjYW4uYwpAQCAt
MjQzLDcgKzI0Myw3IEBAIHVuaXF1ZV9ub25qb2luX3J0ZWtpbmQoQml0bWFwc2V0ICpyZWxpZHMs
IExpc3QgKnJ0YWJsZSkKIHsKIAlpbnQJCQlydGkgPSAtMTsKIAlib29sCQlmaXJzdCA9IHRydWU7
Ci0JUlRFS2luZAkJcnRla2luZDsKKwlSVEVLaW5kCQlydGVraW5kID0gUlRFX1JFTEFUSU9OOyAv
KiBrZWVwIGNvbXBpbGVyIGhhcHB5ICovCiAKIAlBc3NlcnQocmVsaWRzICE9IE5VTEwpOwogCi0t
IAoyLjQ3LjMKCg==
--0000000000003fba45064cd96ed1--