Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ufKMI-005aIf-IV for pgsql-hackers@arkaria.postgresql.org; Fri, 25 Jul 2025 15:29:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1ufKMH-0020Rz-Kw for pgsql-hackers@arkaria.postgresql.org; Fri, 25 Jul 2025 15:29:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ufKMH-0020Rr-BK for pgsql-hackers@lists.postgresql.org; Fri, 25 Jul 2025 15:29:17 +0000 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1ufKME-000nYe-1V for pgsql-hackers@postgresql.org; Fri, 25 Jul 2025 15:29:17 +0000 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-32f1aaf0d60so25476681fa.1 for ; Fri, 25 Jul 2025 08:29:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753457354; x=1754062154; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=F78yn8MNyDoO7bTjvWum7KouRDLfOGKGsj20TZSNB+8=; b=Nzhls8p02tyvmmeYSvZCQC1+WxOF4BMhnV42MgKnZYSAQIk6sA5x2KcY5qj+/ra1+3 GaghWtyfDQkWlqOr1Ve4ct6zv59dkewdU1qel2X7zlRHZFMApOPb1Y6XQPeUhgosb2f4 gzOMx7c43yMey4WZy7Fpat13k+86MGUzKVVO47u4TLIbYdJxLoqCaaRjqcUSZThtcV6a uTem3pDcQu3MZMch6h4DRYiNwIPAohzGgqboUdSjW3NEXw3sgN5IUCZo/bHmEW6MlYbx wMpt3hS0hkMjzwp8SKUfpWcAGQkQOF5FtD1hH3YpKI3u0+KinyCfWMgwxj7DwOFmtFJN U7SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753457354; x=1754062154; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F78yn8MNyDoO7bTjvWum7KouRDLfOGKGsj20TZSNB+8=; b=hN0e5DuEbarsfs9djlz/Uw1Sb85r79s6naz438XZqnoUYt03igbPkubLNVJTRDhKsl 7bKbcl8vAwPovneC/Zxpv8V231uQgJmh9NGeKW9BjON2/LiJmQvWrHtBYrvS33HiwoKF j0rpUbSJX7HkSRA0XwbJ5JQZbV3GkUTj9vaKSZLYc8E54KPdZadPOTyzQZV/cRsjZTAi kBKT5whdt7+lOxRS9DSUuHeSq/2ocZw0cEJwowjHgT/zJsJrghHQy38cJWbOzh0UpCau Zz1A9qkRBtQWBsFBBshdXqrXO+tUroCv5x8U+ctV7i4mB3Vvg1E56c1BhXmr+z/D/SZe YW8A== X-Forwarded-Encrypted: i=1; AJvYcCVUFiUj/drVoPiCKdRCb/nXXqbHK7t1ymr3hry8izIaoqMWpTM9nqvxa2f9jg0JK27iwrdt7MUOa5v5IOQr@postgresql.org X-Gm-Message-State: AOJu0YzxiDRfisccw1GhLxepfcL47QsoFx2xc/JqyQgPn7TRoH6UKs0x WBog5RPIUTW8+zBSwF2kHhgR8k8d1M4K2Lp/LrQrbTWLWvtsFmMah1shigjRgMftdnxSlJ0e+t4 XAFG9lkH6Ohh3kUevOAnz6jCNYNO5QFQ= X-Gm-Gg: ASbGncu741we+WzhackUW/wsUH2GaXNVZ4pNV+vheM4reHzK+9SwzExFy6lGBnLla4E 8s+zOzZNV8xITlvZ7N1keAiWkYBeFxjRIwCUhnKoj7ZX9FUP95+0w8dGR7KDqdbUYaZCxl3XYP3 Y4CY01Jne4gMxEbZrLNrLdAO35Qdy5n33SjY8VOzwWTpyc5VA/m9TG2o1/a7HR/GVDrR2GZ5ssZ ajeZw== X-Google-Smtp-Source: AGHT+IFYIs9ksHTKSX5Chi+pZRjdnrPNJQIKJ5k+MOCqV7tkt6jcCHUvgHQCZV03Y+h/Cr87KTfv4m2TpgVyxJW1P50= X-Received: by 2002:a2e:91d6:0:b0:32c:a097:414b with SMTP id 38308e7fff4ca-331ee75d433mr8326491fa.19.1753457353351; Fri, 25 Jul 2025 08:29:13 -0700 (PDT) MIME-Version: 1.0 References: <1647760.1753369510@sss.pgh.pa.us> <1673684.1753379027@sss.pgh.pa.us> In-Reply-To: From: Sami Imseih Date: Fri, 25 Jul 2025 10:29:01 -0500 X-Gm-Features: Ac12FXxuS-GdQaEYBUJJnuZ2C7k9Pv2i093ngTinm0FecpWUYUgwvYgsjiQ3rUg Message-ID: Subject: Re: track generic and custom plans in pg_stat_statements To: Michael Paquier Cc: Tom Lane , Andrei Lepikhov , Greg Sabino Mullane , pgsql-hackers , Nikolay Samokhvalov , Ilia Evdokimov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > Perhaps CachedPlanType is > misnamed, though, would it be more suited to name that as a sort of > "origin" or "source" field concept? We want to know which which > source we have retrieved a plan that a PlannedStmt refers to. Hmm, I=E2=80=99m not sure I see this as an improvement. In my opinion, CachedPlanType is a clear name that describes its purpose. -- Sami