MIME-Version: 1.0
References: 
 <CALj2ACVnQRS=T8SY2zegfft=Nku1n6w5609JPdd9jqiM+G_gGg@mail.gmail.com>
 <acwTxpz3Toxt0ty8@nathan>
 <CAA5RZ0uVZLsX_k33QoWt8iRes73jyqs+EjypL9+1wW1v8NsYbg@mail.gmail.com>
 <ac00otrpVnWzZ_i4@nathan>
 <CAA5RZ0vFtDKAOZALeLp3vLyhWcLntaqS-Oh36Xxgx5_8sYeSKQ@mail.gmail.com>
 <CAA5RZ0tOJjUuJidUQYAeoUD4VGjOSjuB7ox4dtLAsyoCZqSN+Q@mail.gmail.com>
 <ac2ODZSOjWNzueHZ@nathan>
 <CAA5RZ0uVg0L3vVvkOiHaY9ZJ+K9ZcsyQH0TVQ5rXSd-ZEeVFNg@mail.gmail.com>
 <ac_vLKVgs4RYK1P-@nathan>
 <CAA5RZ0sCRjH3xkHFdSXnKysdMZXFyaS_094+K-O_rr4Fkmwc=Q@mail.gmail.com>
 <adB6FQeoUst6gHA0@nathan>
In-Reply-To: <adB6FQeoUst6gHA0@nathan>
From: Sami Imseih <samimseih@gmail.com>
Date: Sat, 4 Apr 2026 08:25:26 -0500
Message-ID: 
 <CAA5RZ0t6bCR6Pasd_eWqXvyUmrNDWmHUy1yN_Po-c4+b9BtBqQ@mail.gmail.com>
Subject: Re: Add pg_stat_autovacuum_priority
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
 Robert Treat <rob@xzilla.net>,
	satyanarlapuram@gmail.com, pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000086cafa064ea25eaf"
Archived-At: 
 <https://www.postgresql.org/message-id/CAA5RZ0t6bCR6Pasd_eWqXvyUmrNDWmHUy1yN_Po-c4%2Bb9BtBqQ%40mail.gmail.com>
Precedence: bulk

--00000000000086cafa064ea25eaf
Content-Type: text/plain; charset="UTF-8"

> WDYT?

"Scores greater than or equal to <literal>1.0</literal>" in the comments
of each field are misleading. This conflates scoring with vacuum/analyze
eligibility and it's possible with a autovacuum_*_weight < 1.0 to trigger an
autovacuum/analyze.

I suggest the attached changes on top of v9.

--
Sami

--00000000000086cafa064ea25eaf
Content-Type: application/octet-stream; name="0001-sami_doc_fix.patch"
Content-Disposition: attachment; filename="0001-sami_doc_fix.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnkd4hwy0>
X-Attachment-Id: f_mnkd4hwy0

RnJvbSAwZmU3YmUyZTBjNGQ5NzBkMGVjMjFhZjAwN2Q2MDBjNWJiOTRkOTA0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTYW1pIEltc2VpaCA8c2FtaW1zZWloQGdtYWlsLmNvbT4KRGF0
ZTogU2F0LCA0IEFwciAyMDI2IDEzOjA4OjA0ICswMDAwClN1YmplY3Q6IFtQQVRDSCAxLzFdIHNh
bWlfZG9jX2ZpeAoKLS0tCiBkb2Mvc3JjL3NnbWwvbW9uaXRvcmluZy5zZ21sIHwgMjggKysrKysr
KysrLS0tLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwg
MTkgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21sL21vbml0b3Jpbmcuc2dt
bCBiL2RvYy9zcmMvc2dtbC9tb25pdG9yaW5nLnNnbWwKaW5kZXggMzRlMzA1MWM0MDAuLjQ3ZWQ3
NzY4MzQ1IDEwMDY0NAotLS0gYS9kb2Mvc3JjL3NnbWwvbW9uaXRvcmluZy5zZ21sCisrKyBiL2Rv
Yy9zcmMvc2dtbC9tb25pdG9yaW5nLnNnbWwKQEAgLTQ1MjIsNyArNDUyMiw5IEBAIGRlc2NyaXB0
aW9uIHwgV2FpdGluZyBmb3IgYSBuZXdseSBpbml0aWFsaXplZCBXQUwgZmlsZSB0byByZWFjaCBk
dXJhYmxlIHN0b3JhZ2UKICAgPHBhcmE+CiAgICBUaGUgPHN0cnVjdG5hbWU+cGdfc3RhdF9hdXRv
dmFjdXVtX3Njb3Jlczwvc3RydWN0bmFtZT4gdmlldyB3aWxsIGNvbnRhaW4gb25lCiAgICByb3cg
Zm9yIGVhY2ggdGFibGUgaW4gdGhlIGN1cnJlbnQgZGF0YWJhc2UgKGluY2x1ZGluZyBUT0FTVCB0
YWJsZXMpLCBzaG93aW5nCi0gICB0aGUgY3VycmVudCBhdXRvdmFjdXVtIHNjb3JlcyBmb3IgdGhh
dCBzcGVjaWZpYyB0YWJsZS4gIFNlZQorICAgdGhlIGN1cnJlbnQgYXV0b3ZhY3V1bSBzY29yZXMg
Zm9yIHRoYXQgc3BlY2lmaWMgdGFibGUuIFRhYmxlcyBlbGlnaWJsZSBmb3IKKyAgIGF1dG92YWN1
dW0gYXJlIHByaW9yaXRpemVkIGZvciBwcm9jZXNzaW5nIGJhc2VkIG9uIHRoZWlyIHNjb3JlLCB3
aXRoIGhpZ2hlcgorICAgc2NvcmVzIGluZGljYXRpbmcgaGlnaGVyIHByaW9yaXR5LiAgU2VlCiAg
ICA8eHJlZiBsaW5rZW5kPSJhdXRvdmFjdXVtLXByaW9yaXR5Ii8+IGZvciBtb3JlIGluZm9ybWF0
aW9uLgogICA8L3BhcmE+CiAKQEAgLTQ1NzQsMTEgKzQ1NzYsNyBAQCBkZXNjcmlwdGlvbiB8IFdh
aXRpbmcgZm9yIGEgbmV3bHkgaW5pdGlhbGl6ZWQgV0FMIGZpbGUgdG8gcmVhY2ggZHVyYWJsZSBz
dG9yYWdlCiAgICAgICA8L3BhcmE+CiAgICAgICA8cGFyYT4KICAgICAgICBNYXhpbXVtIHZhbHVl
IG9mIGFsbCBjb21wb25lbnQgc2NvcmVzLiAgVGhpcyBpcyB0aGUgdmFsdWUgdGhhdAotICAgICAg
IGF1dG92YWN1dW0gdXNlcyB0byBzb3J0IHRoZSBsaXN0IG9mIHRhYmxlcyB0byBwcm9jZXNzLiAg
U2NvcmVzIGdyZWF0ZXIKLSAgICAgICB0aGFuIG9yIGVxdWFsIHRvIDxsaXRlcmFsPjEuMDwvbGl0
ZXJhbD4gaW5kaWNhdGUgdGhlIHRhYmxlIHdpbGwgYmUKLSAgICAgICBwcm9jZXNzZWQgKHVubGVz
cyBhdXRvdmFjdXVtIGlzIGRpc2FibGVkIGFuZCBuZWl0aGVyCi0gICAgICAgPGxpdGVyYWw+eGlk
X3Njb3JlPC9saXRlcmFsPiBub3IgPGxpdGVyYWw+bXhpZF9zY29yZTwvbGl0ZXJhbD4gYXJlCi0g
ICAgICAgZ3JlYXRlciB0aGFuIG9yIGVxdWFsIHRvIDxsaXRlcmFsPjEuMDwvbGl0ZXJhbD4pLgor
ICAgICAgIGF1dG92YWN1dW0gdXNlcyB0byBzb3J0IHRoZSBsaXN0IG9mIHRhYmxlcyB0byBwcm9j
ZXNzLgogICAgICAgPC9wYXJhPjwvZW50cnk+CiAgICAgIDwvcm93PgogCkBAIC00NTg3LDggKzQ1
ODUsNyBAQCBkZXNjcmlwdGlvbiB8IFdhaXRpbmcgZm9yIGEgbmV3bHkgaW5pdGlhbGl6ZWQgV0FM
IGZpbGUgdG8gcmVhY2ggZHVyYWJsZSBzdG9yYWdlCiAgICAgICAgPHN0cnVjdGZpZWxkPnhpZF9z
Y29yZTwvc3RydWN0ZmllbGQ+IDx0eXBlPmRvdWJsZSBwcmVjaXNpb248L3R5cGU+CiAgICAgICA8
L3BhcmE+CiAgICAgICA8cGFyYT4KLSAgICAgICBUcmFuc2FjdGlvbiBJRCBhZ2UgY29tcG9uZW50
IHNjb3JlLiAgU2NvcmVzIGdyZWF0ZXIgdGhhbiBvciBlcXVhbCB0bwotICAgICAgIDxsaXRlcmFs
PjEuMDwvbGl0ZXJhbD4gaW5kaWNhdGUgdGhlIHRhYmxlIHdpbGwgYmUgdmFjdXVtZWQuCisgICAg
ICAgVHJhbnNhY3Rpb24gSUQgYWdlIGNvbXBvbmVudCBzY29yZS4KICAgICAgIDwvcGFyYT48L2Vu
dHJ5PgogICAgICA8L3Jvdz4KIApAQCAtNDU5Nyw4ICs0NTk0LDcgQEAgZGVzY3JpcHRpb24gfCBX
YWl0aW5nIGZvciBhIG5ld2x5IGluaXRpYWxpemVkIFdBTCBmaWxlIHRvIHJlYWNoIGR1cmFibGUg
c3RvcmFnZQogICAgICAgIDxzdHJ1Y3RmaWVsZD5teGlkX3Njb3JlPC9zdHJ1Y3RmaWVsZD4gPHR5
cGU+ZG91YmxlIHByZWNpc2lvbjwvdHlwZT4KICAgICAgIDwvcGFyYT4KICAgICAgIDxwYXJhPgot
ICAgICAgIE11bHRpeGFjdCBJRCBhZ2UgY29tcG9uZW50IHNjb3JlLiAgU2NvcmVzIGdyZWF0ZXIg
dGhhbiBvciBlcXVhbCB0bwotICAgICAgIDxsaXRlcmFsPjEuMDwvbGl0ZXJhbD4gaW5kaWNhdGUg
dGhlIHRhYmxlIHdpbGwgYmUgdmFjdXVtZWQuCisgICAgICAgTXVsdGl4YWN0IElEIGFnZSBjb21w
b25lbnQgc2NvcmUuCiAgICAgICA8L3BhcmE+PC9lbnRyeT4KICAgICAgPC9yb3c+CiAKQEAgLTQ2
MDcsOSArNDYwMyw3IEBAIGRlc2NyaXB0aW9uIHwgV2FpdGluZyBmb3IgYSBuZXdseSBpbml0aWFs
aXplZCBXQUwgZmlsZSB0byByZWFjaCBkdXJhYmxlIHN0b3JhZ2UKICAgICAgICA8c3RydWN0Zmll
bGQ+dmFjdXVtX3Njb3JlPC9zdHJ1Y3RmaWVsZD4gPHR5cGU+ZG91YmxlIHByZWNpc2lvbjwvdHlw
ZT4KICAgICAgIDwvcGFyYT4KICAgICAgIDxwYXJhPgotICAgICAgIFZhY3V1bSBjb21wb25lbnQg
c2NvcmUuICBTY29yZXMgZ3JlYXRlciB0aGFuIG9yIGVxdWFsIHRvCi0gICAgICAgPGxpdGVyYWw+
MS4wPC9saXRlcmFsPiBpbmRpY2F0ZSB0aGUgdGFibGUgd2lsbCBiZSB2YWN1dW1lZCAodW5sZXNz
Ci0gICAgICAgYXV0b3ZhY3V1bSBpcyBkaXNhYmxlZCkuCisgICAgICAgVmFjdXVtIGNvbXBvbmVu
dCBzY29yZS4KICAgICAgIDwvcGFyYT48L2VudHJ5PgogICAgICA8L3Jvdz4KIApAQCAtNDYxOCw5
ICs0NjEyLDcgQEAgZGVzY3JpcHRpb24gfCBXYWl0aW5nIGZvciBhIG5ld2x5IGluaXRpYWxpemVk
IFdBTCBmaWxlIHRvIHJlYWNoIGR1cmFibGUgc3RvcmFnZQogICAgICAgIDxzdHJ1Y3RmaWVsZD52
YWN1dW1faW5zZXJ0X3Njb3JlPC9zdHJ1Y3RmaWVsZD4gPHR5cGU+ZG91YmxlIHByZWNpc2lvbjwv
dHlwZT4KICAgICAgIDwvcGFyYT4KICAgICAgIDxwYXJhPgotICAgICAgIFZhY3V1bSBpbnNlcnQg
Y29tcG9uZW50IHNjb3JlLiAgU2NvcmVzIGdyZWF0ZXIgdGhhbiBvciBlcXVhbCB0bwotICAgICAg
IDxsaXRlcmFsPjEuMDwvbGl0ZXJhbD4gaW5kaWNhdGUgdGhlIHRhYmxlIHdpbGwgYmUgdmFjdXVt
ZWQgKHVubGVzcwotICAgICAgIGF1dG92YWN1dW0gaXMgZGlzYWJsZWQpLgorICAgICAgIFZhY3V1
bSBpbnNlcnQgY29tcG9uZW50IHNjb3JlLgogICAgICAgPC9wYXJhPjwvZW50cnk+CiAgICAgIDwv
cm93PgogCkBAIC00NjI5LDkgKzQ2MjEsNyBAQCBkZXNjcmlwdGlvbiB8IFdhaXRpbmcgZm9yIGEg
bmV3bHkgaW5pdGlhbGl6ZWQgV0FMIGZpbGUgdG8gcmVhY2ggZHVyYWJsZSBzdG9yYWdlCiAgICAg
ICAgPHN0cnVjdGZpZWxkPmFuYWx5emVfc2NvcmU8L3N0cnVjdGZpZWxkPiA8dHlwZT5kb3VibGUg
cHJlY2lzaW9uPC90eXBlPgogICAgICAgPC9wYXJhPgogICAgICAgPHBhcmE+Ci0gICAgICAgQW5h
bHl6ZSBjb21wb25lbnQgc2NvcmUuICBTY29yZXMgZ3JlYXRlciB0aGFuIG9yIGVxdWFsIHRvCi0g
ICAgICAgPGxpdGVyYWw+MS4wPC9saXRlcmFsPiBpbmRpY2F0ZSB0aGUgdGFibGUgd2lsbCBiZSBh
bmFseXplZCAodW5sZXNzCi0gICAgICAgYXV0b3ZhY3V1bSBpcyBkaXNhYmxlZCkuCisgICAgICAg
QW5hbHl6ZSBjb21wb25lbnQgc2NvcmUuCiAgICAgICA8L3BhcmE+PC9lbnRyeT4KICAgICAgPC9y
b3c+CiAgICAgPC90Ym9keT4KLS0gCjIuNTAuMQoK
--00000000000086cafa064ea25eaf--