MIME-Version: 1.0
References: <CAK7ymc+FxoVswo1ok_xDW-xPG-ZEZ8SAqCUkJ7WF04=0aQDvVQ@mail.gmail.com>
 <CAA5RZ0uyvnNuHRj=73jZhocnLxE07oM-AeSLS=FUuuZ_hy7fKA@mail.gmail.com>
 <em5be966c3-9086-4f3f-b516-97444b854fdf@10e48d49.com> <CAA5RZ0u6qdcLoWJJz5mUB_VYZqT__U-HJJ5_ioYO7XGsUfXfpw@mail.gmail.com>
 <aYIh7I9khvoewwH_@msg.df7cb.de>
In-Reply-To: <aYIh7I9khvoewwH_@msg.df7cb.de>
From: Sami Imseih <samimseih@gmail.com>
Date: Tue, 3 Feb 2026 20:37:31 -0600
Message-ID: <CAA5RZ0tH_+3JGMCktkp8EMyvKaRAJf-xRh+y_UoZ8azvuUEAYQ@mail.gmail.com>
Subject: Re: Re[2]: [PATCH] Add last_executed timestamp to pg_stat_statements
To: Christoph Berg <myon@debian.org>
Cc: Pavlo Golub <pavlo.golub@cybertec.at>, pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAA5RZ0tH_%2B3JGMCktkp8EMyvKaRAJf-xRh%2By_UoZ8azvuUEAYQ%40mail.gmail.com>
Precedence: bulk

> > I wonder if we can use GetCurrentStatementStartTimestamp()
> > instead?
>
> The main use case for this column is being able to retrieve the stats
> that were updated since the last time one was looking. That only works
> if it's the statement end time, or else long-running statements
> spanning more than one poll interval would be missed.

Sure, I get it is not perfect for the polling use-case due to the scenario
you mention,  but I don't think it will be acceptable to call
GetCurrentTimeStamp() at the end of every execution and especially
with a SpinLock held.

This will probably be worse for nested_tacking as well, due to
multiple GetCurrentTimeStamp() calls.

What do you think?

--
Sami Imseih
Amazon Web Services (AWS)